linux/drivers/staging/comedi
Ian Abbott 647a6002cb staging: comedi: cb_pcidas: Allow 2-channel commands for AO subdevice
The "cb_pcidas" driver supports asynchronous commands on the analog
output (AO) subdevice for those boards that have an AO FIFO.  The code
(in `cb_pcidas_ao_check_chanlist()` and `cb_pcidas_ao_cmd()`) to
validate and set up the command supports output to a single channel or
to two channels simultaneously (the boards have two AO channels).
However, the code in `cb_pcidas_auto_attach()` that initializes the
subdevices neglects to initialize the AO subdevice's `len_chanlist`
member, leaving it set to 0, but the Comedi core will "correct" it to 1
if the driver neglected to set it.  This limits commands to use a single
channel (either channel 0 or 1), but the limit should be two channels.
Set the AO subdevice's `len_chanlist` member to be the same value as the
`n_chan` member, which will be 2.

Cc: <stable@vger.kernel.org>
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20201021122142.81628-1-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-10-27 13:19:01 +01:00
..
drivers staging: comedi: cb_pcidas: Allow 2-channel commands for AO subdevice 2020-10-27 13:19:01 +01:00
kcomedilib staging: add missing SPDX lines to Makefile files 2019-04-03 11:10:15 +02:00
comedi_buf.c staging: comedi: use dma_mmap_coherent for DMA-able buffer mmap 2019-06-26 09:32:13 +08:00
comedi_fops.c staging: comedi: Replace HTTP links with HTTPS ones 2020-07-25 15:27:24 +02:00
comedi_internal.h Staging/IIO driver patches for 5.8-rc1 2020-06-07 10:45:08 -07:00
comedi_pci.c staging: comedi: Replace HTTP links with HTTPS ones 2020-07-25 15:27:24 +02:00
comedi_pci.h Staging: comedi: comedi_pci.h: fixed missing or malformed SPDX-License-Identifier 2018-06-18 10:55:11 +02:00
comedi_pcmcia.c staging: comedi: Replace HTTP links with HTTPS ones 2020-07-25 15:27:24 +02:00
comedi_pcmcia.h Staging: comedi: comedi_pcmcia.h: fixed missing or malformed SPDX-License-Identifier 2018-06-18 10:55:11 +02:00
comedi_usb.c staging: comedi: Replace HTTP links with HTTPS ones 2020-07-25 15:27:24 +02:00
comedi_usb.h staging: comedi: comedi_usb.h: SPDX License Identifier is added in the first line 2018-05-31 19:00:53 +02:00
comedi.h drivers: staging: comedi: fixed duplicate words from checkpatch 2020-08-28 12:19:16 +02:00
comedidev.h drivers: staging: comedi: fixed duplicate words from checkpatch 2020-08-28 12:19:16 +02:00
comedilib.h Staging: comedi: comedilib.h: fixed missing or malformed SPDX-License-Identifier 2018-06-18 10:55:11 +02:00
drivers.c staging: comedi: Add lockdep_assert_held() calls for dev->attach_lock 2019-04-19 14:33:41 +02:00
Kconfig staging: comedi: use help instead of ---help--- in Kconfig 2019-04-19 15:01:50 +02:00
Makefile comedi: move compat ioctl handling to native fops 2020-05-28 20:29:17 -04:00
proc.c proc: introduce proc_create_single{,_data} 2018-05-16 07:23:35 +02:00
range.c comedi: get rid of compat_alloc_user_space() mess in COMEDI_RANGEINFO compat 2020-05-28 20:31:19 -04:00
TODO