leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
b30bb89f0f
linux/drivers/platform/x86
History
Julia Lawall b30bb89f0f fujitsu-laptop: fix error return code 
These functions mix the use of result and error.  In acpi_fujitsu_add,
result does not seem useful; it would seem reasonable to propagate the
return value of acpi_bus_update_power in an error case.  On the other hand,
in the case of acpi_fujitsu_hotkey_add, there is an initialization of
result that can lead to what looks like a failure case, but that does not
abort the function.  The variable result is kept for this case.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
2014-01-21 08:44:17 -05:00
..
acer-wmi.c acer-wmi: avoid the warning of 'devices' may be used uninitialized 2013-02-27 08:30:41 -05:00
acerhdf.c Drivers: platform: x86: remove __dev* attributes. 2013-01-03 15:57:03 -08:00
amilo-rfkill.c amilo-rfkill: Enable using amilo-rfkill with the FSC Amilo L1310. 2013-09-05 08:52:12 -04:00
apple-gmux.c More ACPI and power management updates for 3.13-rc1 2013-11-20 13:25:04 -08:00
asus-laptop.c platform:x86: Remove OOM message after input_allocate_device 2013-11-20 18:51:03 -05:00
asus-nb-wmi.c asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. 1015E/U 2013-07-10 15:42:49 -04:00
asus-wmi.c asus-wmi: Convert to use devm_hwmon_device_register_with_groups 2014-01-21 08:44:03 -05:00
asus-wmi.h asus-wmi: always report brightness key events 2013-02-27 08:30:37 -05:00
classmate-laptop.c platform: replace strict_strto*() with kstrto*() 2013-09-05 08:51:52 -04:00
compal-laptop.c compal-laptop: Use devm_hwmon_device_register_with_groups 2014-01-21 08:44:03 -05:00
dell-laptop.c dell-laptop: Only install the i8042 filter when rfkill is active 2014-01-21 08:44:17 -05:00
dell-wmi-aio.c dell: add new dell WMI format for the AIO machines 2013-05-08 19:59:43 -04:00
dell-wmi.c dell-wmi: Add KEY_MICMUTE to bios_to_linux_keycode 2013-11-20 18:51:03 -05:00
eeepc-laptop.c eeepc-laptop: Convert to use devm_hwmon_device_register_with_groups 2014-01-21 08:44:03 -05:00
eeepc-wmi.c asus-wmi: always report brightness key events 2013-02-27 08:30:37 -05:00
fujitsu-laptop.c fujitsu-laptop: fix error return code 2014-01-21 08:44:17 -05:00
fujitsu-tablet.c ACPI: Remove useless type argument of driver .remove() operation 2013-01-26 00:37:24 +01:00
hdaps.c platform / x86 / PM: Fix unused function warnings for CONFIG_PM_SLEEP 2012-08-10 14:29:43 +02:00
hp_accel.c drivers: platform: Mark functions as static in hp_accel.c 2014-01-21 08:44:17 -05:00
hp-wmi.c hp-wmi: detect "2009 BIOS or later" flag by WMI 0x0d for wireless cmd 2013-11-20 18:51:03 -05:00
ibm_rtl.c efi: Make 'efi_enabled' a function to query EFI facilities 2013-01-30 11:51:59 -08:00
ideapad-laptop.c platform:x86: Remove OOM message after input_allocate_device 2013-11-20 18:51:03 -05:00
intel_baytrail.c X86 platform: New BayTrail IOSF-SB MBI driver 2014-01-21 08:44:17 -05:00
intel_baytrail.h X86 platform: New BayTrail IOSF-SB MBI driver 2014-01-21 08:44:17 -05:00
intel_ips.c drivers/platform/x86/intel_ips: Convert to module_pci_driver 2013-07-10 15:42:47 -04:00
intel_ips.h
intel_menlow.c intel_menlow: convert acpi_get_handle() to acpi_has_method() 2013-09-24 01:37:55 +02:00
intel_mid_powerbtn.c platform:x86: Remove OOM message after input_allocate_device 2013-11-20 18:51:03 -05:00
intel_mid_thermal.c platform: x86: remove unnecessary platform_set_drvdata() 2013-09-05 08:52:18 -04:00
intel_oaktrail.c Drivers: platform: x86: remove __dev* attributes. 2013-01-03 15:57:03 -08:00
intel_pmic_gpio.c x86 platform drivers: fix gpio leak 2013-07-10 15:42:51 -04:00
intel_scu_ipc.c ipc: simplify platform data approach 2014-01-21 08:44:17 -05:00
intel_scu_ipcutil.c intel_scu_ipc: Remove Moorestown support 2012-03-20 12:02:02 -04:00
intel-rst.c intel-rst: convert acpi_evaluate_object() to acpi_evaluate_integer() 2013-09-24 01:37:57 +02:00
intel-smartconnect.c intel-smartconnect: convert acpi_evaluate_object() to acpi_evaluate_integer() 2013-09-24 01:37:57 +02:00
Kconfig X86 platform: New BayTrail IOSF-SB MBI driver 2014-01-21 08:44:17 -05:00
Makefile X86 platform: New BayTrail IOSF-SB MBI driver 2014-01-21 08:44:17 -05:00
msi-laptop.c x86: msi-laptop: fix memleak 2013-07-10 15:42:40 -04:00
msi-wmi.c msi-wmi: Add MSI Wind support 2013-02-24 14:49:54 -08:00
mxm-wmi.c drivers: platform: Include appropriate header file in mxm-wmi.c 2014-01-21 08:44:17 -05:00
panasonic-laptop.c platform:x86: Remove OOM message after input_allocate_device 2013-11-20 18:51:03 -05:00
pvpanic.c pvpanic: pvpanic device driver 2013-05-08 19:59:52 -04:00
samsung-laptop.c samsung-laptop: Disable on EFI hardware 2013-01-30 11:52:11 -08:00
samsung-q10.c Merge branch 'for_linus' of git://cavan.codon.org.uk/platform-drivers-x86 2013-09-15 17:42:59 -04:00
sony-laptop.c sony-laptop: do not scribble keyboard backlight registers on resume 2013-11-26 13:03:36 +09:00
tc1100-wmi.c Drivers: platform: x86: remove __dev* attributes. 2013-01-03 15:57:03 -08:00
thinkpad_acpi.c thinkpad_acpi: Fix build error when CONFIG_SND_MAX_CARDS > 32 2013-11-20 18:51:15 -05:00
topstar-laptop.c platform:x86: Remove OOM message after input_allocate_device 2013-11-20 18:51:03 -05:00
toshiba_acpi.c platform:x86: Remove OOM message after input_allocate_device 2013-11-20 18:51:03 -05:00
toshiba_bluetooth.c ACPI: Remove useless type argument of driver .remove() operation 2013-01-26 00:37:24 +01:00
wmi.c x86, wmi fix modalias_show return values 2013-11-20 20:16:22 -05:00
xo1-rfkill.c Drivers: platform: x86: remove __dev* attributes. 2013-01-03 15:57:03 -08:00
xo15-ebook.c ACPI: Remove useless type argument of driver .remove() operation 2013-01-26 00:37:24 +01:00