leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
af7f388e74
linux/drivers/media/pci
History
David Howells af7f388e74 [media] cx23885: Always initialise dev->slock spinlock 
The slock spinlock in the cx23885_dev struct is only initialised if analogue
video is being used, but is used in other places too, leading to the attached
lockdep complaint.

Move the lock initialisation so that it is done unconditionally.

INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
CPU: 1 PID: 4413 Comm: scandvb Tainted: G        W       4.0.0-rc1-fsdevel+ #25
Hardware name: System manufacturer System Product Name/P5Q PRO TURBO, BIOS 0701    10/08/2012
 0000000000000000 ffff880129d779d8 ffffffff8162bbdf 0000000000000006
 0000000000000000 ffff880129d77aa8 ffffffff810780e3 0000000000000001
 0000000000000046 0000000000000004 ffffffff81c3f180 0000000000000000
Call Trace:
 [<ffffffff8162bbdf>] dump_stack+0x4c/0x65
 [<ffffffff810780e3>] __lock_acquire+0x7b5/0x1a0e
 [<ffffffff810799ee>] lock_acquire+0x97/0x10c
 [<ffffffffa006494e>] ? cx23885_buf_queue+0x69/0x142 [cx23885]
 [<ffffffff8102e9bc>] ? amd_set_subcaches+0x19b/0x19b
 [<ffffffff816313b4>] _raw_spin_lock_irqsave+0x36/0x4a
 [<ffffffffa006494e>] ? cx23885_buf_queue+0x69/0x142 [cx23885]
 [<ffffffffa006494e>] cx23885_buf_queue+0x69/0x142 [cx23885]
 [<ffffffffa00662cb>] buffer_queue+0x17/0x19 [cx23885]
 [<ffffffffa00382d5>] __enqueue_in_driver+0x6a/0x6f [videobuf2_core]
 [<ffffffffa0038ead>] vb2_start_streaming+0x37/0x129 [videobuf2_core]
 [<ffffffffa003a6c0>] vb2_internal_streamon+0xc5/0x105 [videobuf2_core]
 [<ffffffffa003b889>] __vb2_init_fileio+0x224/0x286 [videobuf2_core]
 [<ffffffffa003bcc0>] ? vb2_thread_start+0x7b/0x15f [videobuf2_core]
 [<ffffffffa0050182>] ? vb2_dvb_start_feed+0x86/0x86 [videobuf2_dvb]
 [<ffffffffa003bd06>] vb2_thread_start+0xc1/0x15f [videobuf2_core]
 [<ffffffff8150d393>] ? dmx_section_feed_start_filtering+0x2f/0x14f
 [<ffffffffa0050157>] vb2_dvb_start_feed+0x5b/0x86 [videobuf2_dvb]
 [<ffffffff8150d461>] dmx_section_feed_start_filtering+0xfd/0x14f
 [<ffffffff8150afc7>] dvb_dmxdev_filter_start+0x23f/0x315
 [<ffffffff8150b6ad>] dvb_demux_do_ioctl+0x1fb/0x556
 [<ffffffff81509e94>] dvb_usercopy+0xb4/0x11c
 [<ffffffff8150b4b2>] ? dvb_dmxdev_ts_callback+0xd0/0xd0
 [<ffffffff8150a11a>] dvb_demux_ioctl+0x10/0x14
 [<ffffffff81144ac4>] do_vfs_ioctl+0x3c1/0x474
 [<ffffffff8126f181>] ? file_has_perm+0x5b/0x7f
 [<ffffffff810bf6ca>] ? __audit_syscall_entry+0xbc/0xde
 [<ffffffff81144bcc>] SyS_ioctl+0x55/0x7a
 [<ffffffff81631d52>] system_call_fastpath+0x12/0x17

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
2015-04-08 06:28:01 -03:00
..
b2c2
bt8xx [media] bttv: Improve TEA575x support 2015-01-27 10:14:20 -02:00
cx18 [media] cx18: embed video_device 2015-04-03 00:05:36 -03:00
cx88 [media] cx88: Fix possible leak in cx8802_probe() 2015-03-02 14:47:19 -03:00
cx23885 [media] cx23885: Always initialise dev->slock spinlock 2015-04-08 06:28:01 -03:00
cx25821 [media] cx25821: remove video output support 2014-12-23 10:22:00 -02:00
ddbridge [media] ddbridge: remove unneeded check before dvb_unregister_device() 2014-12-04 15:28:52 -02:00
dm1105 [media] dm1105: fix sparse warning 2014-09-03 10:32:59 -03:00
ivtv [media] ivtv: disable fbuf support if ivtvfb isn't loaded 2015-04-02 23:57:51 -03:00
mantis [media] media: pci: mantis: mantis_core.c: Remove unused function 2015-01-27 10:10:06 -02:00
meye [media] meye: embed video_device 2015-04-02 23:35:01 -03:00
ngene [media] ngene: properly handle __user ptr 2014-09-08 10:00:52 -03:00
pluto2
pt1 [media] media: earthsoft: logging neatening 2014-11-03 11:00:41 -02:00
pt3 [media] media: earthsoft: logging neatening 2014-11-03 11:00:41 -02:00
saa7134 [media] media: pci: saa7134: saa7134-video.c: Remove unused function 2015-01-27 10:10:23 -02:00
saa7146 [media] saa7146: embed video_device 2015-04-02 23:29:01 -03:00
saa7164 [media] saa7164: free_irq before pci_disable_device 2015-03-03 11:16:09 -03:00
smipcie [media] smipcie: switch ts2022 to ts2020 driver 2015-04-02 22:25:14 -03:00
solo6x10 [media] solo6x10: s/uint8_t/u8/ 2015-01-27 10:03:19 -02:00
sta2x11 [media] sta2x11: embed video_device 2015-04-02 23:56:44 -03:00
ttpci [media] saa7146: embed video_device 2015-04-02 23:29:01 -03:00
tw68 [media] tw68: remove unnecessary version.h inclusion 2015-01-27 10:08:49 -02:00
zoran media updates for v3.19-rc1 2014-12-11 11:49:23 -08:00
Kconfig [media] smipcie: SMI pcie bridge driver for DVBSky S950 V3 dvb-s/s2 cards 2014-11-03 18:06:45 -02:00
Makefile [media] smipcie: SMI pcie bridge driver for DVBSky S950 V3 dvb-s/s2 cards 2014-11-03 18:06:45 -02:00