linux/drivers/media/dvb
Laurent Pinchart f41ced8f10 Check fops_get() return value
Several subsystem open handlers dereference the fops_get() return value
without checking it for nullness.  This opens a race condition between the
open handler and module unloading.

A module can be marked as being unloaded (MODULE_STATE_GOING) before its
exit function is called and gets the chance to unregister the driver.
During that window open handlers can still be called, and fops_get() will
fail in try_module_get() and return a NULL pointer.

This change checks the fops_get() return value and returns -ENODEV if NULL.

Reported-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Signed-off-by: Laurent Pinchart <laurent.pinchart@skynet.be>
Acked-by: Takashi Iwai <tiwai@suse.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Dave Airlie <airlied@linux.ie>
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-01-06 15:59:11 -08:00
..
b2c2 V4L/DVB (9811): Add support for the CX24113 DVB-S tuner driver 2008-12-30 09:38:34 -02:00
bt8xx Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6 2008-12-28 12:49:40 -08:00
dm1105 V4L/DVB (9472): dm1105: fix the misuse of pci_dma_mapping_error 2008-12-29 17:53:24 -02:00
dvb-core Check fops_get() return value 2009-01-06 15:59:11 -08:00
dvb-usb V4L/DVB (10140): gp8psk: fix incorrect return code (EINVAL instead of -EINVAL) 2009-01-02 17:11:43 -02:00
frontends V4L/DVB (10165): Add FE_CAN_2G_MODULATION flag to frontends that support DVB-S2 2009-01-02 17:15:04 -02:00
pluto2 net: convert more to %pM 2008-10-27 17:47:26 -07:00
siano V4L/DVB (10168): sms1xxx: fix inverted gpio for lna control on tiger r2 2009-01-02 17:15:14 -02:00
ttpci V4L/DVB (10138): v4l2-ioctl: change to long return type to match unlocked_ioctl. 2009-01-02 17:11:34 -02:00
ttusb-budget V4L/DVB (10149): ttusb-budget: make it depend on PCI 2009-01-02 17:12:21 -02:00
ttusb-dec V4L/DVB (10150): ttusb-dec: make it depend on PCI 2009-01-02 17:12:24 -02:00
Kconfig V4L/DVB (9361): Dynamic DVB minor allocation 2008-12-29 17:53:12 -02:00
Makefile V4L/DVB (9107): Alternative version of Terratec Cinergy T2 driver 2008-10-12 09:37:14 -02:00