leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
ac831a379d
linux/drivers/video
History
Geert Uytterhoeven ac831a379d fbdev: controlfb: Add missing modes to fix out of bounds access 
Dan's static analysis says:

    drivers/video/fbdev/controlfb.c:560 control_setup()
    error: buffer overflow 'control_mac_modes' 20 <= 21

Indeed, control_mac_modes[] has only 20 elements, while VMODE_MAX is 22,
which may lead to an out of bounds read when parsing vmode commandline
options.

The bug was introduced in v2.4.5.6, when 2 new modes were added to
macmodes.h, but control_mac_modes[] wasn't updated:

https://kernel.opensuse.org/cgit/kernel/diff/include/video/macmodes.h?h=v2.5.2&id=29f279c764808560eaceb88fef36cbc35c529aad

Augment control_mac_modes[] with the two new video modes to fix this.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
2017-11-09 18:09:33 +01:00
..
backlight dmi: Mark all struct dmi_system_id instances const 2017-09-14 11:59:30 +02:00
console fbdev changes for v4.14: 2017-09-14 13:33:33 -07:00
fbdev fbdev: controlfb: Add missing modes to fix out of bounds access 2017-11-09 18:09:33 +01:00
logo video/logo: tidyup fb_logo_late_init initcall timing 2017-03-20 18:31:00 +01:00
display_timing.c
hdmi.c video: Add new aspect ratios for HDMI 2.0 2016-10-17 14:23:46 +02:00
Kconfig fbdev: sh_mipi_dsi: remove driver 2016-05-10 11:53:38 +03:00
Makefile fbdev: sti: don't select CONFIG_VT 2017-05-05 17:25:12 +02:00
of_display_timing.c video: fbdev: Convert to using %pOF instead of full_name 2017-08-07 17:22:13 +02:00
of_videomode.c video: fbdev: Convert to using %pOF instead of full_name 2017-08-07 17:22:13 +02:00
vgastate.c
videomode.c