forked from Minki/linux
49281a222a
The recent refactoring to break out OF code to its own file
contained a bug letting the need_valid_mask
be overridden by the need of the device tree range check,
and if there were no ranges, but device tree was active
and the reserved GPIO used in another way, things likely
crash.
Cc: Mark Brown <broonie@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Stephen Boyd <swboyd@chromium.org>
Fixes: f626d6dfb7 ("gpio: of: Break out OF-only code")
Reported-by: Mark Brown <broonie@kernel.org>
Suggested-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
46 lines
1.3 KiB
C
46 lines
1.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
|
|
#ifndef GPIOLIB_OF_H
|
|
#define GPIOLIB_OF_H
|
|
|
|
struct gpio_chip;
|
|
enum of_gpio_flags;
|
|
|
|
#ifdef CONFIG_OF_GPIO
|
|
struct gpio_desc *of_find_gpio(struct device *dev,
|
|
const char *con_id,
|
|
unsigned int idx,
|
|
unsigned long *lookupflags);
|
|
struct gpio_desc *of_get_named_gpiod_flags(struct device_node *np,
|
|
const char *list_name, int index, enum of_gpio_flags *flags);
|
|
int of_gpiochip_add(struct gpio_chip *gc);
|
|
void of_gpiochip_remove(struct gpio_chip *gc);
|
|
int of_gpio_get_count(struct device *dev, const char *con_id);
|
|
bool of_gpio_need_valid_mask(const struct gpio_chip *gc);
|
|
#else
|
|
static inline struct gpio_desc *of_find_gpio(struct device *dev,
|
|
const char *con_id,
|
|
unsigned int idx,
|
|
unsigned long *lookupflags)
|
|
{
|
|
return ERR_PTR(-ENOENT);
|
|
}
|
|
static inline struct gpio_desc *of_get_named_gpiod_flags(struct device_node *np,
|
|
const char *list_name, int index, enum of_gpio_flags *flags)
|
|
{
|
|
return ERR_PTR(-ENOENT);
|
|
}
|
|
static inline int of_gpiochip_add(struct gpio_chip *gc) { return 0; }
|
|
static inline void of_gpiochip_remove(struct gpio_chip *gc) { }
|
|
static inline int of_gpio_get_count(struct device *dev, const char *con_id)
|
|
{
|
|
return 0;
|
|
}
|
|
static inline bool of_gpio_need_valid_mask(const struct gpio_chip *gc)
|
|
{
|
|
return false;
|
|
}
|
|
#endif /* CONFIG_OF_GPIO */
|
|
|
|
#endif /* GPIOLIB_OF_H */
|