Wolfgang Ocker aaacf4bb51 spi: avoid spidev crash when device is removed ... I saw a kernel oops in spidev_remove() when a spidev device was registered and I unloaded the SPI master driver: Unable to handle kernel paging request for data at address 0x00000004 Faulting instruction address: 0xc01c0c50 Oops: Kernel access of bad area, sig: 11 [#1] CDSPR Modules linked in: spi_ppc4xx(-) NIP: c01c0c50 LR: c01bf9e4 CTR: c01c0c34 REGS: cec89c30 TRAP: 0300 Not tainted (2.6.27.3izt) MSR: 00021000 <ME> CR: 24000228 XER: 20000007 DEAR: 00000004, ESR: 00800000 TASK = cf889040[2070] 'rmmod' THREAD: cec88000 GPR00: 00000000 cec89ce0 cf889040 cec8e000 00000004 cec8e000 ffffffff 00000000 GPR08: 0000001c c0336380 00000000 c01c0c34 00000001 1001a338 100e0000 100df49c GPR16: 100b54c0 100df49c 100ddd20 100f05a8 100b5340 100efd68 00000000 00000000 GPR24: 100ec008 100f0428 c0327788 c0327794 cec8e0ac cec8e000 c0336380 00000000 NIP [c01c0c50] spidev_remove+0x1c/0xe4 LR [c01bf9e4] spi_drv_remove+0x2c/0x3c Call Trace: [cec89d00] [c01bf9e4] spi_drv_remove+0x2c/0x3c [cec89d10] [c01859a0] __device_release_driver+0x78/0xb4 [cec89d20] [c0185ab0] device_release_driver+0x28/0x44 [cec89d40] [c0184be8] bus_remove_device+0xac/0xd8 [cec89d60] [c0183094] device_del+0x100/0x194 [cec89d80] [c0183140] device_unregister+0x18/0x30 [cec89da0] [c01bf30c] __unregister+0x20/0x34 [cec89db0] [c0182778] device_for_each_child+0x38/0x74 [cec89de0] [c01bf2d0] spi_unregister_master+0x28/0x44 [cec89e00] [c01bfeac] spi_bitbang_stop+0x1c/0x58 [cec89e20] [d908a5e0] spi_ppc4xx_of_remove+0x24/0x7c [spi_ppc4xx] [...] IMHO a call to spi_set_drvdata() is missing in spidev_probe(). The patch below helped. Signed-off-by: Wolfgang Ocker <weo@reccoware.de> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2008-12-01 19:55:24 -08:00
..
at25.c	spi: at25 driver is for EEPROM not FLASH	2007-12-05 09:21:18 -08:00
atmel_spi.c	atmel_spi: work-around required for new HW bug in AT91SAM9263 Rev.B SPI controller	2008-11-12 17:17:17 -08:00
atmel_spi.h
au1550_spi.c	dma-mapping: add the device argument to dma_mapping_error()	2008-07-26 12:00:03 -07:00
Kconfig	spi: new orion_spi driver	2008-08-05 14:33:46 -07:00
Makefile	spi: new orion_spi driver	2008-08-05 14:33:46 -07:00
mpc52xx_psc_spi.c	mpc52xx_psc_spi: remove code associated with !CONFIG_PPC_MERGE	2008-10-16 11:21:38 -07:00
omap2_mcspi.c	[ARM] omap: convert OMAP drivers to use ioremap()	2008-09-05 17:02:30 +01:00
omap_uwire.c	[ARM] omap: convert OMAP drivers to use ioremap()	2008-09-05 17:02:30 +01:00
orion_spi.c	orion_spi: handle 88F6183 erratum	2008-10-16 11:21:38 -07:00
pxa2xx_spi.c	pxa2xx_spi: bugfix full duplex dma data corruption	2008-11-19 18:49:58 -08:00
spi_bfin5xx.c	spi_bfin5xx: use PIO for full duplex, not DMA	2008-05-01 08:04:01 -07:00
spi_bitbang.c	spi: replace remaining __FUNCTION__ occurrences	2008-04-28 08:58:31 -07:00
spi_butterfly.c	minor spi_butterfly cleanup	2007-05-08 11:15:15 -07:00
spi_imx.c	spi_imx: full duplex dma corruption bugfix	2008-11-19 18:49:58 -08:00
spi_lm70llp.c	spi doesn't need class_device	2007-10-16 09:43:10 -07:00
spi_mpc83xx.c	spi_mpc83xx: reject invalid transfer sizes	2008-09-13 14:41:51 -07:00
spi_s3c24xx_gpio.c	[ARM] Move include/asm-arm/arch-* to arch/arm/*/include/mach	2008-08-07 09:55:48 +01:00
spi_s3c24xx.c	spi_s3c24xx: pin configuration updates	2008-10-16 11:21:38 -07:00
spi_sh_sci.c	spi: fix platform driver hotplug/coldplug	2008-04-11 08:06:43 -07:00
spi_txx9.c	spi: fix platform driver hotplug/coldplug	2008-04-11 08:06:43 -07:00
spi.c	spi: core and gpio expanders use subsys_init	2008-10-16 11:21:38 -07:00
spidev.c	spi: avoid spidev crash when device is removed	2008-12-01 19:55:24 -08:00
tle62x0.c	tle62x0 driver stops ignoring read errors	2007-11-14 18:45:42 -08:00
xilinx_spi.c	xilinx_spi: test below 0 on unsigned irq in xilinx_spi_probe()	2008-07-24 10:47:30 -07:00