forked from Minki/linux
3b7a8ec2de
Check the program id within the signal handler on polling xdp samples that were previously converted to libbpf usage. Avoid the situation of unloading the program that was not attached by sample that is exiting. Handle also the case where bpf_get_link_xdp_id didn't exit with an error but the xdp program was not found on an interface. Reported-by: Michal Papaj <michal.papaj@intel.com> Reported-by: Jakub Spizewski <jakub.spizewski@intel.com> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
177 lines
4.1 KiB
C
177 lines
4.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0
|
|
* Copyright (c) 2018 Facebook
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of version 2 of the GNU General Public
|
|
* License as published by the Free Software Foundation.
|
|
*/
|
|
#include <linux/bpf.h>
|
|
#include <linux/if_link.h>
|
|
#include <assert.h>
|
|
#include <errno.h>
|
|
#include <signal.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <sys/resource.h>
|
|
#include <arpa/inet.h>
|
|
#include <netinet/ether.h>
|
|
#include <unistd.h>
|
|
#include <time.h>
|
|
#include "bpf/bpf.h"
|
|
#include "bpf/libbpf.h"
|
|
|
|
#define STATS_INTERVAL_S 2U
|
|
|
|
static int ifindex = -1;
|
|
static __u32 xdp_flags = XDP_FLAGS_UPDATE_IF_NOEXIST;
|
|
static __u32 prog_id;
|
|
|
|
static void int_exit(int sig)
|
|
{
|
|
__u32 curr_prog_id = 0;
|
|
|
|
if (ifindex > -1) {
|
|
if (bpf_get_link_xdp_id(ifindex, &curr_prog_id, xdp_flags)) {
|
|
printf("bpf_get_link_xdp_id failed\n");
|
|
exit(1);
|
|
}
|
|
if (prog_id == curr_prog_id)
|
|
bpf_set_link_xdp_fd(ifindex, -1, xdp_flags);
|
|
else if (!curr_prog_id)
|
|
printf("couldn't find a prog id on a given iface\n");
|
|
else
|
|
printf("program on interface changed, not removing\n");
|
|
}
|
|
exit(0);
|
|
}
|
|
|
|
/* simple "icmp packet too big sent" counter
|
|
*/
|
|
static void poll_stats(unsigned int map_fd, unsigned int kill_after_s)
|
|
{
|
|
time_t started_at = time(NULL);
|
|
__u64 value = 0;
|
|
int key = 0;
|
|
|
|
|
|
while (!kill_after_s || time(NULL) - started_at <= kill_after_s) {
|
|
sleep(STATS_INTERVAL_S);
|
|
|
|
assert(bpf_map_lookup_elem(map_fd, &key, &value) == 0);
|
|
|
|
printf("icmp \"packet too big\" sent: %10llu pkts\n", value);
|
|
}
|
|
}
|
|
|
|
static void usage(const char *cmd)
|
|
{
|
|
printf("Start a XDP prog which send ICMP \"packet too big\" \n"
|
|
"messages if ingress packet is bigger then MAX_SIZE bytes\n");
|
|
printf("Usage: %s [...]\n", cmd);
|
|
printf(" -i <ifindex> Interface Index\n");
|
|
printf(" -T <stop-after-X-seconds> Default: 0 (forever)\n");
|
|
printf(" -S use skb-mode\n");
|
|
printf(" -N enforce native mode\n");
|
|
printf(" -F force loading prog\n");
|
|
printf(" -h Display this help\n");
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
|
|
struct bpf_prog_load_attr prog_load_attr = {
|
|
.prog_type = BPF_PROG_TYPE_XDP,
|
|
};
|
|
unsigned char opt_flags[256] = {};
|
|
const char *optstr = "i:T:SNFh";
|
|
struct bpf_prog_info info = {};
|
|
__u32 info_len = sizeof(info);
|
|
unsigned int kill_after_s = 0;
|
|
int i, prog_fd, map_fd, opt;
|
|
struct bpf_object *obj;
|
|
struct bpf_map *map;
|
|
char filename[256];
|
|
int err;
|
|
|
|
for (i = 0; i < strlen(optstr); i++)
|
|
if (optstr[i] != 'h' && 'a' <= optstr[i] && optstr[i] <= 'z')
|
|
opt_flags[(unsigned char)optstr[i]] = 1;
|
|
|
|
while ((opt = getopt(argc, argv, optstr)) != -1) {
|
|
|
|
switch (opt) {
|
|
case 'i':
|
|
ifindex = atoi(optarg);
|
|
break;
|
|
case 'T':
|
|
kill_after_s = atoi(optarg);
|
|
break;
|
|
case 'S':
|
|
xdp_flags |= XDP_FLAGS_SKB_MODE;
|
|
break;
|
|
case 'N':
|
|
xdp_flags |= XDP_FLAGS_DRV_MODE;
|
|
break;
|
|
case 'F':
|
|
xdp_flags &= ~XDP_FLAGS_UPDATE_IF_NOEXIST;
|
|
break;
|
|
default:
|
|
usage(argv[0]);
|
|
return 1;
|
|
}
|
|
opt_flags[opt] = 0;
|
|
}
|
|
|
|
for (i = 0; i < strlen(optstr); i++) {
|
|
if (opt_flags[(unsigned int)optstr[i]]) {
|
|
fprintf(stderr, "Missing argument -%c\n", optstr[i]);
|
|
usage(argv[0]);
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
if (setrlimit(RLIMIT_MEMLOCK, &r)) {
|
|
perror("setrlimit(RLIMIT_MEMLOCK, RLIM_INFINITY)");
|
|
return 1;
|
|
}
|
|
|
|
snprintf(filename, sizeof(filename), "%s_kern.o", argv[0]);
|
|
prog_load_attr.file = filename;
|
|
|
|
if (bpf_prog_load_xattr(&prog_load_attr, &obj, &prog_fd))
|
|
return 1;
|
|
|
|
map = bpf_map__next(NULL, obj);
|
|
if (!map) {
|
|
printf("finding a map in obj file failed\n");
|
|
return 1;
|
|
}
|
|
map_fd = bpf_map__fd(map);
|
|
|
|
if (!prog_fd) {
|
|
printf("load_bpf_file: %s\n", strerror(errno));
|
|
return 1;
|
|
}
|
|
|
|
signal(SIGINT, int_exit);
|
|
signal(SIGTERM, int_exit);
|
|
|
|
if (bpf_set_link_xdp_fd(ifindex, prog_fd, xdp_flags) < 0) {
|
|
printf("link set xdp fd failed\n");
|
|
return 1;
|
|
}
|
|
|
|
err = bpf_obj_get_info_by_fd(prog_fd, &info, &info_len);
|
|
if (err) {
|
|
printf("can't get prog info - %s\n", strerror(errno));
|
|
return 1;
|
|
}
|
|
prog_id = info.id;
|
|
|
|
poll_stats(map_fd, kill_after_s);
|
|
int_exit(0);
|
|
|
|
return 0;
|
|
}
|