forked from Minki/linux
b610281358
Instead of using CAP_SYS_ADMIN which is restricted to the root user, check the file mode for write permissions before executing commands that can affect the platform. This allows for more fine-grained access control to the SEV ioctl interface. This would allow a SEV-only user or group the ability to administer the platform without requiring them to be root or granting them overly powerful permissions. For example: chown root:root /dev/sev chmod 600 /dev/sev setfacl -m g:sev:r /dev/sev setfacl -m g:sev-admin:rw /dev/sev In this instance, members of the "sev-admin" group have the ability to perform all ioctl calls (including the ones that modify platform state). Members of the "sev" group only have access to the ioctls that do not modify the platform state. This also makes opening "/dev/sev" more consistent with how file descriptors are usually handled. By only checking for CAP_SYS_ADMIN, the file descriptor could be opened read-only but could still execute ioctls that modify the platform state. This patch enforces that the file descriptor is opened with write privileges if it is going to be used to modify the platform state. This flexibility is completely opt-in, and if it is not desirable by the administrator then they do not need to give anyone else access to /dev/sev. Signed-off-by: Connor Kuehl <ckuehl@redhat.com> Reviewed-by: Brijesh Singh <brijesh.singh@amd.com> Reviewed-by: Bandan Das <bsd@redhat.com> Acked-by: David Rientjes <rientjes@google.com> Acked-by: Tom Lendacky <thomas.lendacky@amd.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
||
|---|---|---|
| .. | ||
| ccp-crypto-aes-cmac.c | ||
| ccp-crypto-aes-galois.c | ||
| ccp-crypto-aes-xts.c | ||
| ccp-crypto-aes.c | ||
| ccp-crypto-des3.c | ||
| ccp-crypto-main.c | ||
| ccp-crypto-rsa.c | ||
| ccp-crypto-sha.c | ||
| ccp-crypto.h | ||
| ccp-debugfs.c | ||
| ccp-dev-v3.c | ||
| ccp-dev-v5.c | ||
| ccp-dev.c | ||
| ccp-dev.h | ||
| ccp-dmaengine.c | ||
| ccp-ops.c | ||
| Kconfig | ||
| Makefile | ||
| psp-dev.c | ||
| psp-dev.h | ||
| sev-dev.c | ||
| sev-dev.h | ||
| sp-dev.c | ||
| sp-dev.h | ||
| sp-pci.c | ||
| sp-platform.c | ||
| tee-dev.c | ||
| tee-dev.h | ||