Hans de Goede a2fd46cd3d Input: goodix - try not to touch the reset-pin on x86/ACPI devices ... Unless the controller is not responding at boot or after suspend/resume, the driver never resets the controller on x86/ACPI platforms. The driver still requesting the reset pin at probe() though in case it needs it. Until now the driver has always requested the reset pin with GPIOD_IN as type. The idea being to put the pin in high-impedance mode to save power until the driver actually wants to issue a reset. But this means that just requesting the pin can cause issues, since requesting it in another mode then GPIOD_ASIS may cause the pinctrl driver to touch the pin settings. We have already had issues before due to a bug in the pinctrl-cherryview.c driver which has been fixed in commit 921daeeca9 ("pinctrl: cherryview: Preserve CHV_PADCTRL1_INVRXTX_TXDATA flag on GPIOs"). And now it turns out that requesting the reset-pin as GPIOD_IN also stops the touchscreen from working on the GPD P2 max mini-laptop. The behavior of putting the pin in high-impedance mode relies on there being some external pull-up to keep it high and there seems to be no pull-up on the GPD P2 max, causing things to break. This commit fixes this by requesting the reset pin as is when using the x86/ACPI code paths to lookup the GPIOs; and by not dropping it back into input-mode in case the driver does end up issuing a reset for error-recovery. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=209061 Fixes: a7d4b17166 ("Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices") Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20211206091116.44466-2-hdegoede@redhat.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>		2021-12-06 23:18:24 -08:00
..
gameport	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
joystick	Merge branch 'next' into for-linus	2021-11-11 21:58:54 -08:00
keyboard	Merge branch 'next' into for-linus	2021-11-11 21:58:54 -08:00
misc	Input: iqs626a - prohibit inlining of channel parsing functions	2021-11-28 23:59:35 -08:00
mouse	Input: elantech - fix stack out of bound access in elantech_change_report_id()	2021-11-29 00:11:15 -08:00
rmi4	Input: synaptics-rmi4 - Fix device hierarchy	2021-11-05 19:46:21 -07:00
serio	Input: i8042 - enable deferred probe quirk for ASUS UM325UA	2021-12-06 23:18:22 -08:00
tablet	Input: aiptek - convert sysfs sprintf/snprintf family to sysfs_emit	2021-02-22 21:22:50 -08:00
touchscreen	Input: goodix - try not to touch the reset-pin on x86/ACPI devices	2021-12-06 23:18:24 -08:00
apm-power.c
evbug.c	Input: evbug - remove an empty comment block	2021-05-24 21:06:39 -07:00
evdev.c	Input: evdev - per-client waitgroups	2020-10-06 18:34:15 -07:00
ff-core.c
ff-memless.c	Input: ff-memless - kill timer in destroy()	2019-11-15 11:45:03 -08:00
input-compat.c
input-compat.h
input-leds.c
input-mt.c	Input: MT - avoid comma separated statements	2020-08-25 10:26:05 -07:00
input-poller.c	Input: use input_device_enabled()	2020-12-02 22:10:33 -08:00
input-poller.h
input.c	Input: Add "inhibited" property	2020-12-02 22:10:35 -08:00
joydev.c	Input: joydev - prevent use of not validated data in JSIOCSBTNMAP ioctl	2021-07-04 23:02:10 -07:00
Kconfig	Input: remove input_polled_dev implementation	2020-12-02 12:35:14 -08:00
Makefile	Input: touchscreen - move helper functions to core	2021-03-25 11:14:09 -07:00
matrix-keymap.c
mousedev.c
sparse-keymap.c	Input: Use fallthrough pseudo-keyword	2020-07-07 11:25:54 -07:00
touchscreen.c	Input: touchscreen - avoid bitwise vs logical OR warning	2021-10-15 22:22:54 -07:00