linux/drivers/media/IR/ir-raw-event.c
Mauro Carvalho Chehab 9f1547829a V4L/DVB: saa7134: don't wait too much to generate an IR event on raw_decode
At raw_decode mode, the key is processed after the end of a timer. The
previous code resets the timer every time something is received at the IR
port. While this works fine with IR's that don't implement repeat, like
Avermedia RM-JX IR, it keeps waiting until keydown, on IR's that implement
NEC repeat command, like the Terratec yellow.

The solution is to change the behaviour to do the timeout after the first
received data.

The timeout is currently set to 15 ms, as it works fine with NEC protcocol.
It may need some adjustments to support other protocols and to better handle
spurious detections that may happen with some IR sensors.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2010-05-18 00:52:58 -03:00

132 lines
3.3 KiB
C

/* ir-raw-event.c - handle IR Pulse/Space event
*
* Copyright (C) 2010 by Mauro Carvalho Chehab <mchehab@redhat.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
#include <media/ir-core.h>
/* Define the max number of bit transitions per IR keycode */
#define MAX_IR_EVENT_SIZE 256
static void ir_keyup_timer(unsigned long data)
{
struct input_dev *input_dev = (struct input_dev *)data;
ir_keyup(input_dev);
}
int ir_raw_event_register(struct input_dev *input_dev)
{
struct ir_input_dev *ir = input_get_drvdata(input_dev);
int rc, size;
ir->raw = kzalloc(sizeof(*ir->raw), GFP_KERNEL);
size = sizeof(struct ir_raw_event) * MAX_IR_EVENT_SIZE * 2;
size = roundup_pow_of_two(size);
init_timer(&ir->raw->timer_keyup);
ir->raw->timer_keyup.function = ir_keyup_timer;
ir->raw->timer_keyup.data = (unsigned long)input_dev;
set_bit(EV_REP, input_dev->evbit);
rc = kfifo_alloc(&ir->raw->kfifo, size, GFP_KERNEL);
return rc;
}
EXPORT_SYMBOL_GPL(ir_raw_event_register);
void ir_raw_event_unregister(struct input_dev *input_dev)
{
struct ir_input_dev *ir = input_get_drvdata(input_dev);
if (!ir->raw)
return;
del_timer_sync(&ir->raw->timer_keyup);
kfifo_free(&ir->raw->kfifo);
kfree(ir->raw);
ir->raw = NULL;
}
EXPORT_SYMBOL_GPL(ir_raw_event_unregister);
int ir_raw_event_store(struct input_dev *input_dev, enum raw_event_type type)
{
struct ir_input_dev *ir = input_get_drvdata(input_dev);
struct timespec ts;
struct ir_raw_event event;
int rc;
if (!ir->raw)
return -EINVAL;
event.type = type;
event.delta.tv_sec = 0;
event.delta.tv_nsec = 0;
ktime_get_ts(&ts);
if (timespec_equal(&ir->raw->last_event, &event.delta))
event.type |= IR_START_EVENT;
else
event.delta = timespec_sub(ts, ir->raw->last_event);
memcpy(&ir->raw->last_event, &ts, sizeof(ts));
if (event.delta.tv_sec) {
event.type |= IR_START_EVENT;
event.delta.tv_sec = 0;
event.delta.tv_nsec = 0;
}
kfifo_in(&ir->raw->kfifo, &event, sizeof(event));
return rc;
}
EXPORT_SYMBOL_GPL(ir_raw_event_store);
int ir_raw_event_handle(struct input_dev *input_dev)
{
struct ir_input_dev *ir = input_get_drvdata(input_dev);
int rc;
struct ir_raw_event *evs;
int len, i;
/*
* Store the events into a temporary buffer. This allows calling more than
* one decoder to deal with the received data
*/
len = kfifo_len(&ir->raw->kfifo) / sizeof(*evs);
if (!len)
return 0;
evs = kmalloc(len * sizeof(*evs), GFP_ATOMIC);
for (i = 0; i < len; i++) {
rc = kfifo_out(&ir->raw->kfifo, &evs[i], sizeof(*evs));
if (rc != sizeof(*evs)) {
IR_dprintk(1, "overflow error: received %d instead of %zd\n",
rc, sizeof(*evs));
return -EINVAL;
}
IR_dprintk(2, "event type %d, time before event: %07luus\n",
evs[i].type, (evs[i].delta.tv_nsec + 500) / 1000);
}
rc = ir_nec_decode(input_dev, evs, len);
kfree(evs);
return rc;
}
EXPORT_SYMBOL_GPL(ir_raw_event_handle);