leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
9b00bc7b90
linux/arch/arm/mach-pxa
History
Linus Walleij 9b00bc7b90
spi: spi-gpio: Rewrite to use GPIO descriptors 
This converts the bit-banged GPIO SPI driver to looking up and
using GPIO descriptors to get a handle on GPIO lines for SCK,
MOSI, MISO and all CS lines.

All existing board files are converted in one go to keep it all
consistent. With these conversions I rarely find any interrim
steps that makes any sense.

Device tree probing and GPIO handling should work like before
also after this patch.

For board files, we stop using controller data to pass the GPIO
line for chip select, instead we pass this as a GPIO descriptor
lookup like everything else.

In some s3c24xx machines the names of the SPI devices were set to
"spi-gpio" rather than "spi_gpio" which can never have worked, I
fixed it working (I guess) as part of this patch set. Sometimes
I wonder how this code got upstream in the first place, it
obviously is not tested.

mach-s3c64xx/mach-smartq.c has the same problem and additionally
defines the *same* GPIO line for MOSI and MISO which is not going
to be accepted by gpiolib. As the lines were number 1,2,2 I assumed
it was a typo and use lines 1,2,3. A comment gives awat that line 0
is chip select though no actual SPI device is provided for the LCD
supposed to be on this bit-banged SPI bus. I left it intact instead
of just deleting the bus though.

Kill off board file code that try to initialize the SPI lines
to the same values that they will later be set by the spi_gpio
driver anyways. Given the huge number of weird things in these
board files I do not think this code is very tested or put in
with much afterthought anyways.

In order to assert that we do not get performance regressions on
this crucial bing-banged driver, a ran a script like this dumping the
Ilitek ILI9322 regmap 10000 times (it has no caching obviously) on
an otherwise idle system in two iterations before and after the
patches:

 #!/bin/sh
 for run in `seq 10000`
 do
     cat /debug/regmap/spi0.0/registers > /dev/null
 done

Before the patch:

time test.sh
real    3m 41.03s
user    0m 29.41s
sys     3m 7.22s

time test.sh
real    3m 44.24s
user    0m 32.31s
sys     3m 7.60s

After the patch:

time test.sh
real    3m 41.32s
user    0m 28.92s
sys     3m 8.08s

time test.sh
real    3m 39.92s
user    0m 30.20s
sys     3m 5.56s

So any performance differences seems to be in the error margin.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Olof Johansson <olof@lixom.net>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2018-02-14 16:02:41 +00:00
..
include/mach License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
am200epd.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
am300epd.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
balloon3.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
capc7117.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
cm-x2xx-pci.c genirq: Remove irq argument from irq flow handlers 2015-09-16 15:47:51 +02:00
cm-x2xx-pci.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
cm-x2xx.c ARM: pxa: cm-x2xx: avoid duplicate macro warnings 2015-12-15 23:50:00 +01:00
cm-x255.c mtd: nand: gpio: Convert to use GPIO descriptors 2017-10-07 11:27:48 +02:00
cm-x270.c rtc: v3020: move rtc-v3020.h to platform_data 2016-07-09 10:24:21 +02:00
cm-x300.c spi: spi-gpio: Rewrite to use GPIO descriptors 2018-02-14 16:02:41 +00:00
colibri-evalboard.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
colibri-pxa3xx.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
colibri-pxa270-income.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
colibri-pxa270.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
colibri-pxa300.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
colibri-pxa320.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
colibri.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
corgi_pm.c ARM: pxa: fix GPIO double shifts 2016-09-09 18:07:59 +02:00
corgi.c ARM: pxa/corgi: Remove hardcoded partitioning, use sharpslpart parser 2017-11-28 22:52:50 +01:00
csb701.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
csb726.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
csb726.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
devices.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
devices.h ARM: pxa: move declarations to proper place 2017-11-28 22:47:22 +01:00
em-x270.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
eseries-irq.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
eseries.c mtd: nand: Rename nand.h into rawnand.h 2017-08-13 10:11:49 +02:00
ezx.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
generic.c ARM: sa11x0/pxa: get rid of get_clock_tick_rate 2016-10-18 09:12:37 +02:00
generic.h ARM: pxa: remove irq init from dt machines 2016-09-09 18:08:01 +02:00
gumstix.c ARM: pxa: define clock registers as __iomem 2016-02-01 21:43:41 +01:00
gumstix.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
h5000.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
h5000.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
himalaya.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
hx4700.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
icontrol.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
idp.c ARM: pxa: include linux/leds.h 2017-01-18 19:21:17 +01:00
idp.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
irq.c ARM: kill off set_irq_flags usage 2015-07-28 13:58:13 +02:00
Kconfig ARM: pxa/lubbock: add GPIO driver for LUB_MISC_WR register 2017-12-20 21:53:27 +01:00
littleton.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
littleton.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
lpd270.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
lpd270.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
lubbock.c ARM: pxa/lubbock: add GPIO driver for LUB_MISC_WR register 2017-12-20 21:53:27 +01:00
magician.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
mainstone.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
Makefile.boot ARM: 7022/1: allow to detect conflicting zreladdrs 2011-10-17 09:12:40 +01:00
mfp-pxa2xx.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
mfp-pxa2xx.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mfp-pxa3xx.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
mfp-pxa3xx.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mfp-pxa25x.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mfp-pxa27x.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mfp-pxa300.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
mfp-pxa320.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
mfp-pxa930.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
mioa701_bootresume.S ARM: align .data section 2017-08-14 16:22:55 +01:00
mioa701.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
mioa701.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mp900.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
mxm8x10.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
mxm8x10.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
palm27x.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
palm27x.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
palmld.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
palmt5.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
palmt5.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
palmtc.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
palmte2.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
palmte2.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
palmtreo.c ARM: SoC multiplatform code changes for v4.5 2016-01-20 18:03:56 -08:00
palmtreo.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
palmtx.c mtd: nand: Rename nand.h into rawnand.h 2017-08-13 10:11:49 +02:00
palmz72.c i2c: gpio: Augment all boardfiles to use open drain 2017-10-30 08:42:43 +01:00
palmz72.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
pcm027.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
pcm027.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
pcm990_baseboard.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
pcm990-baseboard.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
pm.c ARM: pxa: Delete an error message for a failed memory allocation in pxa_pm_init() 2017-06-14 08:32:21 +02:00
pm.h ARM: pxa: move extern declarations to pm.h 2016-02-01 21:44:27 +01:00
poodle.c ARM: pxa/poodle: Remove hardcoded partitioning, use sharpslpart parser 2017-11-28 22:53:00 +01:00
pxa2xx.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
pxa3xx-ulpi.c ARM: pxa: Delete an error message for a failed memory allocation in pxa3xx_u2d_probe() 2017-06-14 08:32:21 +02:00
pxa3xx.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
pxa3xx.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
pxa25x.c ARM: 8641/1: treewide: Replace uses of virt_to_phys with __pa_symbol 2017-02-28 11:06:10 +00:00
pxa25x.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
pxa27x-udc.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
pxa27x.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
pxa27x.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
pxa300.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
pxa300.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
pxa320.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
pxa320.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
pxa930.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
pxa930.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
pxa_cplds_irqs.c ARM: pxa: pxa_cplds: honor probe deferral 2016-10-18 09:12:37 +02:00
pxa-dt.c ARM: pxa: remove irq init from dt machines 2016-09-09 18:08:01 +02:00
raumfeld.c spi: spi-gpio: Rewrite to use GPIO descriptors 2018-02-14 16:02:41 +00:00
regs-rtc.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
regs-u2d.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
reset.c ARM: pxa: prevent PXA270 occasional reboot freezes 2013-12-11 16:35:16 -08:00
saar.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
sharpsl_pm.c treewide: Use DEVICE_ATTR_RO 2018-01-09 16:34:34 +01:00
sharpsl_pm.h ARM: pxa: fix GPIO double shifts 2016-09-09 18:07:59 +02:00
sleep.S ARM: pxa: correct errata number for PXA270 2014-07-04 20:30:42 +08:00
smemc.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
spitz_pm.c ARM: pxa: fix GPIO double shifts 2016-09-09 18:07:59 +02:00
spitz.c ARM: pxa/spitz: Remove hardcoded partitioning, use sharpslpart parser 2017-11-28 22:52:57 +01:00
standby.S ARM: convert all "mov.* pc, reg" to "bx reg" for ARMv6+ 2014-07-18 12:29:04 +01:00
stargate2.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
tavorevb.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
tosa_bt.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
tosa-bt.c ARM: pxa/tosa-bt: add MODULE_LICENSE tag 2018-01-22 12:36:03 +01:00
tosa.c ARM: pxa/tosa: Remove hardcoded partitioning, use sharpslpart parser 2017-11-28 22:52:54 +01:00
trizeps4.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
udc.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
viper.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
viper.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
vpac270.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
xcep.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
z2.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
zeus.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
zeus.h ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
zylonite_pxa300.c ARM: pxa: move header file out of I2C realm 2017-11-28 22:49:30 +01:00
zylonite_pxa320.c ARM: pxa: make more mach/*.h files local 2015-12-01 21:52:50 +01:00
zylonite.c ARM: pxa: Don't rely on public mmc header to include leds.h 2017-02-13 13:20:17 +01:00
zylonite.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00