linux/drivers/media/platform/vsp1
Kieran Bingham 639fa43d59 media: vsp1: Fix BRx conditional path in WPF
When a BRx is provided by a pipeline, the WPF must determine the master
layer. Currently the condition to check this identifies pipe->bru ||
pipe->num_inputs > 1.

The code then moves on to dereference pipe->bru, thus the check fails
static analysers on the possibility that pipe->num_inputs could be
greater than 1 without pipe->bru being set.

The reality is that the pipeline must have a BRx to support more than
one input, thus this could never cause a fault - however it also
identifies that the num_inputs > 1 check is redundant.

Remove the redundant check - and always configure the master layer
appropriately when we have a BRx configured in our pipeline.

Fixes: 6134148f60 ("v4l: vsp1: Add support for the BRS entity")

Cc: stable@vger.kernel.org
Suggested-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2018-04-04 06:27:28 -04:00
..
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
vsp1_bru.c
vsp1_bru.h
vsp1_clu.c
vsp1_clu.h
vsp1_dl.c media: v4l: vsp1: Fix header display list status check in continuous mode 2018-02-26 10:23:00 -05:00
vsp1_dl.h
vsp1_drm.c media: v4l: vsp1: Print the correct blending unit name in debug messages 2018-02-26 10:24:12 -05:00
vsp1_drm.h
vsp1_drv.c media: vsp1: Prevent suspending and resuming DRM pipelines 2017-12-08 10:40:10 -05:00
vsp1_entity.c
vsp1_entity.h media updates for v4.14-rc1 2017-09-07 12:53:14 -07:00
vsp1_hgo.c
vsp1_hgo.h
vsp1_hgt.c
vsp1_hgt.h
vsp1_histo.c
vsp1_histo.h
vsp1_hsit.c
vsp1_hsit.h
vsp1_lif.c media: v4l: vsp1: Fix video output on R8A77970 2018-02-26 10:27:28 -05:00
vsp1_lif.h
vsp1_lut.c
vsp1_lut.h
vsp1_pipe.c media updates for v4.14-rc1 2017-09-07 12:53:14 -07:00
vsp1_pipe.h media updates for v4.14-rc1 2017-09-07 12:53:14 -07:00
vsp1_regs.h media: v4l: vsp1: Fix video output on R8A77970 2018-02-26 10:27:28 -05:00
vsp1_rpf.c media: v4l: vsp1: Allow entities to participate in the partition algorithm 2017-08-20 09:32:49 -04:00
vsp1_rwpf.c
vsp1_rwpf.h
vsp1_sru.c media: v4l: vsp1: Allow entities to participate in the partition algorithm 2017-08-20 09:32:49 -04:00
vsp1_sru.h
vsp1_uds.c media: v4l: vsp1: Allow entities to participate in the partition algorithm 2017-08-20 09:32:49 -04:00
vsp1_uds.h
vsp1_video.c media updates for v4.14-rc1 2017-09-07 12:53:14 -07:00
vsp1_video.h
vsp1_wpf.c media: vsp1: Fix BRx conditional path in WPF 2018-04-04 06:27:28 -04:00
vsp1.h