Ignat Korchagin 8abec36d12 dm crypt: do not wait for backlogged crypto request completion in softirq ... Commit 39d42fa96b ("dm crypt: add flags to optionally bypass kcryptd workqueues") made it possible for some code paths in dm-crypt to be executed in softirq context, when the underlying driver processes IO requests in interrupt/softirq context. When Crypto API backlogs a crypto request, dm-crypt uses wait_for_completion to avoid sending further requests to an already overloaded crypto driver. However, if the code is executing in softirq context, we might get the following stacktrace: [ 210.235213][ C0] BUG: scheduling while atomic: fio/2602/0x00000102 [ 210.236701][ C0] Modules linked in: [ 210.237566][ C0] CPU: 0 PID: 2602 Comm: fio Tainted: G W 5.10.0+ #50 [ 210.239292][ C0] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 [ 210.241233][ C0] Call Trace: [ 210.241946][ C0] <IRQ> [ 210.242561][ C0] dump_stack+0x7d/0xa3 [ 210.243466][ C0] __schedule_bug.cold+0xb3/0xc2 [ 210.244539][ C0] __schedule+0x156f/0x20d0 [ 210.245518][ C0] ? io_schedule_timeout+0x140/0x140 [ 210.246660][ C0] schedule+0xd0/0x270 [ 210.247541][ C0] schedule_timeout+0x1fb/0x280 [ 210.248586][ C0] ? usleep_range+0x150/0x150 [ 210.249624][ C0] ? unpoison_range+0x3a/0x60 [ 210.250632][ C0] ? ____kasan_kmalloc.constprop.0+0x82/0xa0 [ 210.251949][ C0] ? unpoison_range+0x3a/0x60 [ 210.252958][ C0] ? __prepare_to_swait+0xa7/0x190 [ 210.254067][ C0] do_wait_for_common+0x2ab/0x370 [ 210.255158][ C0] ? usleep_range+0x150/0x150 [ 210.256192][ C0] ? bit_wait_io_timeout+0x160/0x160 [ 210.257358][ C0] ? blk_update_request+0x757/0x1150 [ 210.258582][ C0] ? _raw_spin_lock_irq+0x82/0xd0 [ 210.259674][ C0] ? _raw_read_unlock_irqrestore+0x30/0x30 [ 210.260917][ C0] wait_for_completion+0x4c/0x90 [ 210.261971][ C0] crypt_convert+0x19a6/0x4c00 [ 210.263033][ C0] ? _raw_spin_lock_irqsave+0x87/0xe0 [ 210.264193][ C0] ? kasan_set_track+0x1c/0x30 [ 210.265191][ C0] ? crypt_iv_tcw_ctr+0x4a0/0x4a0 [ 210.266283][ C0] ? kmem_cache_free+0x104/0x470 [ 210.267363][ C0] ? crypt_endio+0x91/0x180 [ 210.268327][ C0] kcryptd_crypt_read_convert+0x30e/0x420 [ 210.269565][ C0] blk_update_request+0x757/0x1150 [ 210.270563][ C0] blk_mq_end_request+0x4b/0x480 [ 210.271680][ C0] blk_done_softirq+0x21d/0x340 [ 210.272775][ C0] ? _raw_spin_lock+0x81/0xd0 [ 210.273847][ C0] ? blk_mq_stop_hw_queue+0x30/0x30 [ 210.275031][ C0] ? _raw_read_lock_irq+0x40/0x40 [ 210.276182][ C0] __do_softirq+0x190/0x611 [ 210.277203][ C0] ? handle_edge_irq+0x221/0xb60 [ 210.278340][ C0] asm_call_irq_on_stack+0x12/0x20 [ 210.279514][ C0] </IRQ> [ 210.280164][ C0] do_softirq_own_stack+0x37/0x40 [ 210.281281][ C0] irq_exit_rcu+0x110/0x1b0 [ 210.282286][ C0] common_interrupt+0x74/0x120 [ 210.283376][ C0] asm_common_interrupt+0x1e/0x40 [ 210.284496][ C0] RIP: 0010:_aesni_enc1+0x65/0xb0 Fix this by making crypt_convert function reentrant from the point of a single bio and make dm-crypt defer further bio processing to a workqueue, if Crypto API backlogs a request in interrupt context. Fixes: 39d42fa96b ("dm crypt: add flags to optionally bypass kcryptd workqueues") Cc: stable@vger.kernel.org # v5.9+ Signed-off-by: Ignat Korchagin <ignat@cloudflare.com> Acked-by: Mikulas Patocka <mpatocka@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com>		2021-01-04 15:02:32 -05:00
..
accessibility	speakup: fix uninitialized flush_lock	2020-12-09 15:38:13 +01:00
acpi	libnvdimm for 5.11	2020-12-24 12:18:11 -08:00
amba
android	Merge branch 'exec-for-v5.11' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2020-12-15 19:29:43 -08:00
ata
atm
auxdisplay
base	Power management updates for 5.11-rc1	2020-12-15 16:30:31 -08:00
bcma
block	block-5.11-2020-12-23	2020-12-24 12:28:35 -08:00
bluetooth
bus	ARM: SoC drivers for v5.11	2020-12-16 16:38:41 -08:00
cdrom	cdrom: Reset sector_size back it is not 2048.	2020-12-12 11:12:25 -07:00
char	UAPI Changes:	2020-12-18 12:38:28 -08:00
clk	The core framework got some nice improvements this time around. We gained the	2020-12-21 10:39:37 -08:00
clocksource	asm-generic: cross-architecture timer cleanup	2020-12-16 00:07:17 -08:00
connector	net/connector: Add const qualifier to cb_id	2020-12-16 11:06:49 -08:00
counter
cpufreq	cpufreq: intel_pstate: Fix fast-switch fallback path	2020-12-30 18:22:17 +01:00
cpuidle	ARM: SoC drivers for v5.11	2020-12-16 16:38:41 -08:00
crypto	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2020-12-27 09:14:32 -08:00
dax	libnvdimm for 5.11	2020-12-24 12:18:11 -08:00
dca
devfreq	Merge branches 'pm-devfreq' and 'pm-tools'	2020-12-15 15:27:16 +01:00
dio
dma	dmaengine updates for v5.11-rc1	2020-12-17 12:52:23 -08:00
dma-buf	drm fixes for 5.11-rc1	2020-12-24 12:14:29 -08:00
edac	Merge branch 'akpm' (patches from Andrew)	2020-12-15 12:53:37 -08:00
eisa
extcon	extcon: max77693: Fix modalias string	2020-12-11 17:18:10 +09:00
firewire
firmware	EFI updates collected by Ard Biesheuvel:	2020-12-24 12:40:07 -08:00
fpga
fsi	hwmon patches for v5.11	2020-12-15 16:06:14 -08:00
gnss
gpio	This is the bulk of the GPIO changes for the v5.11 kernel cycle:	2020-12-17 18:07:20 -08:00
gpu	drm/amd/display: avoid uninitialized variable warning	2020-12-25 15:41:13 -08:00
greybus
hid	Merge branch 'for-5.11/wacom' into for-linus	2020-12-16 11:44:38 +01:00
hsi
hv	hyperv-next for 5.11	2020-12-16 11:49:46 -08:00
hwmon	hwmon: (k10temp) Remove support for displaying voltage and current on Zen CPUs	2020-12-22 08:18:36 -08:00
hwspinlock	hwspinlock: sirf: Remove the redundant 'of_match_ptr'	2020-12-10 13:34:40 -06:00
hwtracing	Char / Misc driver updates for 5.11-rc1	2020-12-15 14:10:09 -08:00
i2c	Power management updates for 5.11-rc1	2020-12-15 16:30:31 -08:00
i3c	i3c/master/mipi-i3c-hci: quiet maybe-unused variable warning	2020-12-17 10:31:30 +01:00
ide	SCSI fixes on 20210101	2021-01-01 12:58:07 -08:00
idle	intel_idle: add SnowRidge C-state table	2020-12-30 18:25:34 +01:00
iio	Staging / IIO driver patches for 5.11-rc1	2020-12-15 14:18:40 -08:00
infiniband	block/rnbd-clt: Does not request pdu to rtrs-clt	2020-12-16 14:56:09 -07:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2020-12-15 16:18:23 -08:00
interconnect	ARM: device tree updates for 5.11	2020-12-16 16:27:35 -08:00
iommu	IOMMU updates for 5.11	2020-12-16 13:58:47 -08:00
ipack
irqchip	ARM:	2020-12-20 10:44:05 -08:00
isdn
leds
lightnvm	drivers/lightnvm: fix a null-ptr-deref bug in pblk-core.c	2020-12-08 10:02:45 -07:00
macintosh
mailbox	mailbox: arm_mhuv2: Add driver	2020-12-09 19:26:02 -06:00
mcb
md	dm crypt: do not wait for backlogged crypto request completion in softirq	2021-01-04 15:02:32 -05:00
media	ARM: SoC drivers for v5.11	2020-12-16 16:38:41 -08:00
memory	Merge tag 'memory-controller-drv-tegra-5.11-3' of git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-mem-ctrl into arm/drivers	2020-12-09 00:40:02 +01:00
memstick
message	SCSI misc on 20201216	2020-12-16 13:34:31 -08:00
mfd	mfd: ab8500-debugfs: Remove extraneous seq_putc	2020-12-26 09:19:49 -08:00
misc	powerpc updates for 5.11	2020-12-17 13:34:25 -08:00
mmc	MMC core:	2020-12-15 15:57:25 -08:00
most
mtd	This pull request contains changes for JFFS2, UBI and UBIFS:	2020-12-17 17:46:34 -08:00
mux
net	A treewide cleanup of interrupt descriptor (ab)use with all sorts of racy	2020-12-24 13:50:23 -08:00
nfc	nfc: s3fwrn5: Remove unused NCI prop commands	2020-12-16 13:09:35 -08:00
ntb	Big fix for IDT NTB and Intel NTB LTR management support	2020-12-27 09:22:55 -08:00
nubus
nvdimm	libnvdimm/label: Return -ENXIO for no slot in __blk_label_update	2020-12-16 16:53:00 -08:00
nvme	RDMA 5.11 pull request	2020-12-16 13:42:26 -08:00
nvmem
of	Driver core updates for 5.11-rc1	2020-12-15 14:02:26 -08:00
opp	opp: Call the missing clk_put() on error	2020-12-28 10:56:22 +05:30
oprofile
parisc
parport
pci	pci-v5.11-fixes-1	2020-12-25 20:17:40 -08:00
pcmcia	Merge branch 'pcmcia-next' of git://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux	2020-12-19 12:50:10 -08:00
perf	perf/imx_ddr: Add system PMU identifier for userspace	2020-12-09 14:14:02 +00:00
phy	Char / Misc driver updates for 5.11-rc1	2020-12-15 14:10:09 -08:00
pinctrl	A treewide cleanup of interrupt descriptor (ab)use with all sorts of racy	2020-12-24 13:50:23 -08:00
platform	chrome platform changes for 5.11	2020-12-23 15:06:22 -08:00
pnp
power	power: supply: Fix a typo in warning message	2020-12-13 01:00:10 +01:00
powercap	Merge branches 'pm-sleep', 'pm-acpi', 'pm-domains' and 'powercap'	2020-12-15 15:26:14 +01:00
pps
ps3	powerpc/ps3: use dma_mapping_error()	2020-12-15 22:50:12 +11:00
ptp	ptp: clockmatrix: deprecate firmware older than 4.8.7	2020-12-09 15:00:55 -08:00
pwm	pwm: Changes for v5.11-rc1	2020-12-19 11:51:32 -08:00
rapidio	rapidio: remove unused rio_get_asm() and rio_get_device()	2020-12-15 22:46:18 -08:00
ras
regulator	Merge remote-tracking branch 'regulator/for-5.11' into regulator-next	2020-12-11 17:48:32 +00:00
remoteproc	ARM: SoC drivers for v5.11	2020-12-16 16:38:41 -08:00
reset	ARM: SoC drivers for v5.11	2020-12-16 16:38:41 -08:00
rpmsg
rtc	RTC for 5.11	2020-12-20 10:12:06 -08:00
s390	block-5.11-2020-12-23	2020-12-24 12:28:35 -08:00
sbus
scsi	SCSI fixes on 20210101	2021-01-01 12:58:07 -08:00
sfi
sh
siox	siox: Make remove callback return void	2020-12-10 16:17:15 +01:00
slimbus	slimbus: qcom: fix potential NULL dereference in qcom_slim_prg_slew()	2020-12-10 16:23:56 +01:00
soc	OpenRISC updates for 5.11	2020-12-17 13:41:27 -08:00
soundwire
spi	Merge remote-tracking branch 'spi/for-5.11' into spi-next	2020-12-11 17:49:01 +00:00
spmi	spmi: Add driver shutdown support	2020-12-10 10:45:36 +01:00
ssb
staging	UAPI Changes:	2020-12-18 12:38:28 -08:00
target	SCSI misc on 20201216	2020-12-16 13:34:31 -08:00
tc
tee	ARM: SoC drivers for v5.11	2020-12-16 16:38:41 -08:00
thermal	- Add Alder Lake support ACPI ids (Srinivas Pandruvada)	2020-12-18 12:19:37 -08:00
thunderbolt
tty	OpenRISC updates for 5.11	2020-12-17 13:41:27 -08:00
uio	uio: uio_hv_generic: use devm_kzalloc() for private data alloc	2020-12-09 19:59:00 +01:00
usb	powerpc updates for 5.11	2020-12-17 13:34:25 -08:00
vdpa	virtio,vdpa: features, cleanups, fixes	2020-12-24 12:06:46 -08:00
vfio	ARM:	2020-12-20 10:44:05 -08:00
vhost	virtio,vdpa: features, cleanups, fixes	2020-12-24 12:06:46 -08:00
video	UAPI Changes:	2020-12-18 12:38:28 -08:00
virt
virtio	virtio,vdpa: features, cleanups, fixes	2020-12-24 12:06:46 -08:00
visorbus
vlynq
vme	vme: switch from 'pci_' to 'dma_' API	2020-12-09 19:44:34 +01:00
w1
watchdog	linux-watchdog 5.11-rc1 tag	2020-12-23 15:01:49 -08:00
xen	A treewide cleanup of interrupt descriptor (ab)use with all sorts of racy	2020-12-24 13:50:23 -08:00
zorro
Kconfig
Makefile	asm-generic: cross-architecture timer cleanup	2020-12-16 00:07:17 -08:00