Fred Oh 8a473c39ae ASoC: Intel: Boards: cml_rt1011_rt5682: use statically define codec config ... When the cml_rt1011_rt5682_dailink[].codecs pointer is overridden by a quirk with a devm allocated structure and the probe is deferred, in the next probe we will see an use-after-free condition (verified with KASAN). This can be avoided by using statically allocated configurations - which simplifies the code quite a bit as well. KASAN issue fixed. [ 23.301373] cml_rt1011_rt5682 cml_rt1011_rt5682: sof_rt1011_quirk = f [ 23.301875] ================================================================== [ 23.302018] BUG: KASAN: use-after-free in snd_cml_rt1011_probe+0x23a/0x3d0 [snd_soc_cml_rt1011_rt5682] [ 23.302178] Read of size 8 at addr ffff8881ec6acae0 by task kworker/0:2/105 [ 23.302320] CPU: 0 PID: 105 Comm: kworker/0:2 Not tainted 5.7.0-rc7-test+ #3 [ 23.302322] Hardware name: Google Helios/Helios, BIOS 01/21/2020 [ 23.302329] Workqueue: events deferred_probe_work_func [ 23.302331] Call Trace: [ 23.302339] dump_stack+0x76/0xa0 [ 23.302345] print_address_description.constprop.0.cold+0xd3/0x43e [ 23.302351] ? _raw_spin_lock_irqsave+0x7b/0xd0 [ 23.302355] ? _raw_spin_trylock_bh+0xf0/0xf0 [ 23.302362] ? snd_cml_rt1011_probe+0x23a/0x3d0 [snd_soc_cml_rt1011_rt5682] [ 23.302365] __kasan_report.cold+0x37/0x86 [ 23.302371] ? snd_cml_rt1011_probe+0x23a/0x3d0 [snd_soc_cml_rt1011_rt5682] [ 23.302375] kasan_report+0x38/0x50 [ 23.302382] snd_cml_rt1011_probe+0x23a/0x3d0 [snd_soc_cml_rt1011_rt5682] [ 23.302389] platform_drv_probe+0x66/0xc0 Fixes: 629ba12e99 ("ASoC: Intel: boards: split woofer and tweeter support") Suggested-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by: Fred Oh <fred.oh@linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> Link: https://lore.kernel.org/r/20200625191308.3322-12-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>		2020-06-26 13:35:20 +01:00
..
ac97	ALSA: ac97: Constify snd_ac97_bus_ops definitions	2020-01-03 09:24:11 +01:00
aoa	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
arm	ASoC: arm: use asoc_rtd_to_cpu() / asoc_rtd_to_codec() macro for DAI pointer	2020-03-27 14:44:56 +00:00
atmel	ALSA: atmel: Constify snd_ac97_bus_ops definitions	2020-01-03 09:24:12 +01:00
core	sound fixes for 5.8-rc1	2020-06-11 12:38:11 -07:00
drivers	powerpc updates for 5.8	2020-06-05 12:39:30 -07:00
firewire	Merge branch 'for-linus' into for-next	2020-05-28 10:08:50 +02:00
hda	ASoC: Updates for v5.8	2020-06-01 20:26:07 +02:00
i2c	ALSA: i2c: Constify snd_kcontrol_new items	2020-01-03 09:24:24 +01:00
isa	ALSA: es1688: Add the missed snd_card_free()	2020-06-03 11:40:55 +02:00
mips	ALSA: sgio2audio: Remove usage of dropped hw_params/hw_free functions	2020-03-06 12:06:41 +01:00
oss	.gitignore: add SPDX License Identifier	2020-03-25 11:50:48 +01:00
parisc	sound updates for 5.6-rc1	2020-01-28 16:26:57 -08:00
pci	sound fixes for 5.8-rc1	2020-06-11 12:38:11 -07:00
pcmcia	ALSA: pdaudiocf: More constification	2020-01-05 16:15:13 +01:00
ppc	powerpc updates for 5.8	2020-06-05 12:39:30 -07:00
sh	ALSA: sh: Fix compile warning wrt const	2020-01-05 16:15:14 +01:00
soc	ASoC: Intel: Boards: cml_rt1011_rt5682: use statically define codec config	2020-06-26 13:35:20 +01:00
sparc	ALSA: sparc: More constifications	2020-01-05 16:14:56 +01:00
spi	ALSA: spi: More constification	2020-01-05 16:15:13 +01:00
synth	ALSA: emux: More constifications	2020-01-05 16:14:46 +01:00
usb	ALSA: usb-audio: Manage auto-pm of all bundled interfaces	2020-06-08 19:34:49 +02:00
x86	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
xen	ALSA: xen: Drop superfluous ioctl PCM ops	2019-12-11 07:25:35 +01:00
ac97_bus.c	ALSA: ac97: Treat snd_ac97_bus_ops as const	2020-01-03 09:24:08 +01:00
Kconfig
last.c
Makefile
sound_core.c