linux/drivers/net/ethernet/natsemi
Finn Thain 89ba879e95 net/sonic: Fix receive buffer replenishment
As soon as the driver is finished with a receive buffer it allocs a new
one and overwrites the corresponding RRA entry with a new buffer pointer.

Problem is, the buffer pointer is split across two word-sized registers.
It can't be updated in one atomic store. So this operation races with the
chip while it stores received packets and advances its RRP register.
This could result in memory corruption by a DMA write.

Avoid this problem by adding buffers only at the location given by the
RWP register, in accordance with the National Semiconductor datasheet.

Re-factor this code into separate functions to calculate a RRA pointer
and to update the RWP.

Fixes: efcce83936 ("[PATCH] macsonic/jazzsonic network drivers update")
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-01-23 21:24:37 +01:00
..
jazzsonic.c net/sonic: Replace custom debug logging with netif_* calls 2018-02-26 14:40:02 -05:00
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
macsonic.c net/sonic: Replace custom debug logging with netif_* calls 2018-02-26 14:40:02 -05:00
Makefile ethernet: natsemi: correct spelling 2018-03-06 11:14:08 -05:00
natsemi.c net: natsemi: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles 2019-02-14 11:56:36 -05:00
ns83820.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13 2019-05-21 11:28:45 +02:00
sonic.c net/sonic: Fix receive buffer replenishment 2020-01-23 21:24:37 +01:00
sonic.h net/sonic: Fix receive buffer replenishment 2020-01-23 21:24:37 +01:00
xtsonic.c net/sonic: Replace custom debug logging with netif_* calls 2018-02-26 14:40:02 -05:00