forked from Minki/linux
83bd01024b
cf http://lkml.org/lkml/2007/10/3/41 To summarize: on Linux, SA_ONSTACK decides whether you are already on the signal stack based on the value of the SP at the time of a signal. If you are not already inside the range, you are not "on the signal stack" and so the new signal handler frame starts over at the base of the signal stack. sigaltstack (and sigstack before it) was invented in BSD. There, the SA_ONSTACK behavior has always been different. It uses a kernel state flag to decide, rather than the SP value. When you first take an SA_ONSTACK signal and switch to the alternate signal stack, it sets the SS_ONSTACK flag in the thread's sigaltstack state in the kernel. Thereafter you are "on the signal stack" and don't switch SP before pushing a handler frame no matter what the SP value is. Only when you sigreturn from the original handler context do you clear the SS_ONSTACK flag so that a new handler frame will start over at the base of the alternate signal stack. The undesireable effect of the Linux behavior is that an overflow of the alternate signal stack can not only go undetected, but lead to a ring buffer effect of clobbering the original handler frame at the base of the signal stack for each successive signal that comes just after the overflow. This is what Shi Weihua's test case demonstrates. Normally this does not come up because of the signal mask, but the test case uses SA_NODEFER for its SIGSEGV handler. The other subtle part of the existing Linux semantics is that a simple longjmp out of a signal handler serves to take you off the signal stack in a safe and reliable fashion without having used sigreturn (nor having just returned from the handler normally, which means the same). After the longjmp (or even informal stack switching not via any proper libc or kernel interface), the alternate signal stack stands ready to be used again. A paranoid program would allocate a PROT_NONE red zone around its alternate signal stack. Then a small overflow would trigger a SIGSEGV in handler setup, and be fatal (core dump) whether or not SIGSEGV is blocked. As with thread stack red zones, that cannot catch all overflows (or underflows). e.g., a local array as large as page size allocated in a function called from a handler, but not actually touched before more calls push more stack, could cause an overflow that silently pushes into some unrelated allocated pages. The BSD behavior does not do anything in particular about overflow. But it does at least avoid the wraparound or "ring buffer effect", so you'll just get a straightforward all-out overflow down your address space past the low end of the alternate signal stack. I don't know what the BSD behavior is for longjmp out of an SA_ONSTACK handler. The POSIX wording relating to sigaltstack is pretty minimal. I don't think it speaks to this issue one way or another. (The program that overflows its stack is clearly in undefined behavior territory of one sort or another anyhow.) Given the longjmp issue and the potential for highly subtle complications in existing programs relying on this in arcane ways deep in their code, I am very dubious about changing the behavior to the BSD style persistent flag. I think Shi Weihua's patches have a similar effect by tracking the SP used in the last handler setup. I think it would be sensible for the signal handler setup code to detect when it would itself be causing a stack overflow. Maybe something like the following patch (untested). This issue exists in the same way on all machines, so ideally they would all do a similar check. When it's the handler function itself or its callees that cause the overflow, rather than the signal handler frame setup alone crossing the boundary, this still won't help. But I don't see any way to distinguish that from the valid longjmp case. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> |
||
|---|---|---|
| .. | ||
| acpi | ||
| cpu | ||
| .gitignore | ||
| alternative.c | ||
| aperture_64.c | ||
| apic_32.c | ||
| apic_64.c | ||
| apm_32.c | ||
| asm-offsets_32.c | ||
| asm-offsets_64.c | ||
| asm-offsets.c | ||
| audit_64.c | ||
| bootflag.c | ||
| bugs_64.c | ||
| cpuid.c | ||
| crash_dump_32.c | ||
| crash_dump_64.c | ||
| crash.c | ||
| doublefault_32.c | ||
| e820_32.c | ||
| e820_64.c | ||
| early_printk.c | ||
| early-quirks.c | ||
| efi_32.c | ||
| efi_stub_32.S | ||
| entry_32.S | ||
| entry_64.S | ||
| genapic_64.c | ||
| genapic_flat_64.c | ||
| geode_32.c | ||
| head64.c | ||
| head_32.S | ||
| head_64.S | ||
| hpet.c | ||
| i386_ksyms_32.c | ||
| i387_32.c | ||
| i387_64.c | ||
| i8237.c | ||
| i8253.c | ||
| i8259_32.c | ||
| i8259_64.c | ||
| init_task.c | ||
| io_apic_32.c | ||
| io_apic_64.c | ||
| io_delay.c | ||
| ioport_32.c | ||
| ioport_64.c | ||
| irq_32.c | ||
| irq_64.c | ||
| k8.c | ||
| kprobes_32.c | ||
| kprobes_64.c | ||
| ldt_32.c | ||
| ldt_64.c | ||
| machine_kexec_32.c | ||
| machine_kexec_64.c | ||
| Makefile | ||
| Makefile_32 | ||
| Makefile_64 | ||
| mca_32.c | ||
| mfgpt_32.c | ||
| microcode.c | ||
| module_32.c | ||
| module_64.c | ||
| mpparse_32.c | ||
| mpparse_64.c | ||
| msr.c | ||
| nmi_32.c | ||
| nmi_64.c | ||
| numaq_32.c | ||
| paravirt_32.c | ||
| pci-calgary_64.c | ||
| pci-dma_32.c | ||
| pci-dma_64.c | ||
| pci-gart_64.c | ||
| pci-nommu_64.c | ||
| pci-swiotlb_64.c | ||
| pcspeaker.c | ||
| pmtimer_64.c | ||
| process_32.c | ||
| process_64.c | ||
| ptrace_32.c | ||
| ptrace_64.c | ||
| quirks.c | ||
| reboot_32.c | ||
| reboot_64.c | ||
| reboot_fixups_32.c | ||
| relocate_kernel_32.S | ||
| relocate_kernel_64.S | ||
| scx200_32.c | ||
| setup64.c | ||
| setup_32.c | ||
| setup_64.c | ||
| sigframe_32.h | ||
| signal_32.c | ||
| signal_64.c | ||
| smp_32.c | ||
| smp_64.c | ||
| smpboot_32.c | ||
| smpboot_64.c | ||
| smpcommon_32.c | ||
| srat_32.c | ||
| stacktrace.c | ||
| summit_32.c | ||
| suspend_64.c | ||
| suspend_asm_64.S | ||
| sys_i386_32.c | ||
| sys_x86_64.c | ||
| syscall_64.c | ||
| syscall_table_32.S | ||
| sysenter_32.c | ||
| tce_64.c | ||
| time_32.c | ||
| time_64.c | ||
| topology.c | ||
| trampoline_32.S | ||
| trampoline_64.S | ||
| traps_32.c | ||
| traps_64.c | ||
| tsc_32.c | ||
| tsc_64.c | ||
| tsc_sync.c | ||
| verify_cpu_64.S | ||
| vm86_32.c | ||
| vmi_32.c | ||
| vmiclock_32.c | ||
| vmlinux_32.lds.S | ||
| vmlinux_64.lds.S | ||
| vmlinux.lds.S | ||
| vsmp_64.c | ||
| vsyscall_32.lds.S | ||
| vsyscall_32.S | ||
| vsyscall_64.c | ||
| vsyscall-int80_32.S | ||
| vsyscall-note_32.S | ||
| vsyscall-sigreturn_32.S | ||
| vsyscall-sysenter_32.S | ||
| x8664_ksyms_64.c | ||