forked from Minki/linux
5b361328ca
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293
("cxgb3/l2t: Fix undefined behaviour")
Link: https://lore.kernel.org/r/20200213010425.GA13068@embeddedor.com
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> # added a few more
96 lines
3.0 KiB
C
96 lines
3.0 KiB
C
/*
|
|
* Copyright (c) 2013, Cisco Systems, Inc. All rights reserved.
|
|
*
|
|
* This software is available to you under a choice of one of two
|
|
* licenses. You may choose to be licensed under the terms of the GNU
|
|
* General Public License (GPL) Version 2, available from the file
|
|
* COPYING in the main directory of this source tree, or the
|
|
* BSD license below:
|
|
*
|
|
* Redistribution and use in source and binary forms, with or
|
|
* without modification, are permitted provided that the following
|
|
* conditions are met:
|
|
*
|
|
* - Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer.
|
|
*
|
|
* - Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer in the documentation and/or other materials
|
|
* provided with the distribution.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
|
|
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
|
|
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
|
|
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
* SOFTWARE.
|
|
*
|
|
*/
|
|
|
|
#ifndef USNIC_UIOM_H_
|
|
#define USNIC_UIOM_H_
|
|
|
|
#include <linux/list.h>
|
|
#include <linux/scatterlist.h>
|
|
|
|
#include "usnic_uiom_interval_tree.h"
|
|
|
|
struct ib_ucontext;
|
|
|
|
#define USNIC_UIOM_READ (1)
|
|
#define USNIC_UIOM_WRITE (2)
|
|
|
|
#define USNIC_UIOM_MAX_PD_CNT (1000)
|
|
#define USNIC_UIOM_MAX_MR_CNT (1000000)
|
|
#define USNIC_UIOM_MAX_MR_SIZE (~0UL)
|
|
#define USNIC_UIOM_PAGE_SIZE (PAGE_SIZE)
|
|
|
|
struct usnic_uiom_dev {
|
|
struct device *dev;
|
|
struct list_head link;
|
|
};
|
|
|
|
struct usnic_uiom_pd {
|
|
struct iommu_domain *domain;
|
|
spinlock_t lock;
|
|
struct rb_root_cached root;
|
|
struct list_head devs;
|
|
int dev_cnt;
|
|
};
|
|
|
|
struct usnic_uiom_reg {
|
|
struct usnic_uiom_pd *pd;
|
|
unsigned long va;
|
|
size_t length;
|
|
int offset;
|
|
int page_size;
|
|
int writable;
|
|
struct list_head chunk_list;
|
|
struct work_struct work;
|
|
struct mm_struct *owning_mm;
|
|
};
|
|
|
|
struct usnic_uiom_chunk {
|
|
struct list_head list;
|
|
int nents;
|
|
struct scatterlist page_list[];
|
|
};
|
|
|
|
struct usnic_uiom_pd *usnic_uiom_alloc_pd(void);
|
|
void usnic_uiom_dealloc_pd(struct usnic_uiom_pd *pd);
|
|
int usnic_uiom_attach_dev_to_pd(struct usnic_uiom_pd *pd, struct device *dev);
|
|
void usnic_uiom_detach_dev_from_pd(struct usnic_uiom_pd *pd,
|
|
struct device *dev);
|
|
struct device **usnic_uiom_get_dev_list(struct usnic_uiom_pd *pd);
|
|
void usnic_uiom_free_dev_list(struct device **devs);
|
|
struct usnic_uiom_reg *usnic_uiom_reg_get(struct usnic_uiom_pd *pd,
|
|
unsigned long addr, size_t size,
|
|
int access, int dmasync);
|
|
void usnic_uiom_reg_release(struct usnic_uiom_reg *uiomr);
|
|
int usnic_uiom_init(char *drv_name);
|
|
#endif /* USNIC_UIOM_H_ */
|