linux/arch/arm64/kvm/hyp
Jamie Iles 7bab16a607 KVM: arm64: Correctly align nVHE percpu data
The nVHE percpu data is partially linked but the nVHE linker script did
not align the percpu section.  The PERCPU_INPUT macro would then align
the data to a page boundary:

  #define PERCPU_INPUT(cacheline)					\
  	__per_cpu_start = .;						\
  	*(.data..percpu..first)						\
  	. = ALIGN(PAGE_SIZE);						\
  	*(.data..percpu..page_aligned)					\
  	. = ALIGN(cacheline);						\
  	*(.data..percpu..read_mostly)					\
  	. = ALIGN(cacheline);						\
  	*(.data..percpu)						\
  	*(.data..percpu..shared_aligned)				\
  	PERCPU_DECRYPTED_SECTION					\
  	__per_cpu_end = .;

but then when the final vmlinux linking happens the hypervisor percpu
data is included after page alignment and so the offsets potentially
don't match.  On my build I saw that the .hyp.data..percpu section was
at address 0x20 and then the percpu data would begin at 0x1000 (because
of the page alignment in PERCPU_INPUT), but when linked into vmlinux,
everything would be shifted down by 0x20 bytes.

This manifests as one of the CPUs getting lost when running
kvm-unit-tests or starting any VM and subsequent soft lockup on a Cortex
A72 device.

Fixes: 30c953911c ("kvm: arm64: Set up hyp percpu data for nVHE")
Signed-off-by: Jamie Iles <jamie@nuviainc.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Acked-by: David Brazdil <dbrazdil@google.com>
Cc: David Brazdil <dbrazdil@google.com>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20201113150406.14314-1-jamie@nuviainc.com
2020-11-16 09:30:42 +00:00
..
include/hyp KVM/arm64 updates for Linux 5.10 2020-10-20 08:14:25 -04:00
nvhe KVM: arm64: Correctly align nVHE percpu data 2020-11-16 09:30:42 +00:00
vhe Merge branch 'kvm-arm64/hyp-pcpu' into kvmarm-master/next 2020-09-30 14:05:35 +01:00
aarch32.c Merge branch 'kvm-arm64/misc-5.9' into kvmarm-master/next-WIP 2020-07-28 16:26:16 +01:00
entry.S Merge branch 'kvm-arm64/hyp-pcpu' into kvmarm-master/next 2020-09-30 14:05:35 +01:00
fpsimd.S KVM: arm64: Remove __hyp_text macro, use build rules instead 2020-07-05 18:38:45 +01:00
hyp-entry.S Merge branch 'kvm-arm64/hyp-pcpu' into kvmarm-master/next 2020-09-30 14:05:35 +01:00
Makefile Merge branch 'kvm-arm64/hyp-pcpu' into kvmarm-master/next 2020-09-30 14:05:35 +01:00
pgtable.c KVM: arm64: Fix masks in stage2_pte_cacheable() 2020-10-29 19:49:03 +00:00
smccc_wa.S KVM: arm64: Move __smccc_workaround_1_smc to .rodata 2020-07-05 18:37:48 +01:00
vgic-v2-cpuif-proxy.c KVM: arm64: Remove __hyp_text macro, use build rules instead 2020-07-05 18:38:45 +01:00
vgic-v3-sr.c treewide: Use fallthrough pseudo-keyword 2020-08-23 17:36:59 -05:00