José Roberto de Souza 7b19914383 drm/mst: Don't do atomic checks over disabled managers ... When a main MST port is disconnected drivers should call drm_dp_mst_topology_mgr_set_mst() disabling the MST manager, this function will set manager mst_primary to NULL and it will cause the crash bellow on the next atomic check when trying to access mst_primary->port. As there is no use in running checks over managers that are not active this patch will skip it. [ 305.616450] [drm:drm_dp_mst_atomic_check] [MST PORT:00000000cc2049e9] releases all VCPI slots [ 305.625085] [drm:drm_dp_mst_atomic_check] [MST PORT:00000000020ab43e] releases all VCPI slots [ 305.633729] [drm:drm_dp_mst_atomic_check] [MST MGR:00000000cdd467d4] mst state 00000000b67672eb VCPI avail=63 used=0 [ 305.644405] BUG: kernel NULL pointer dereference, address: 0000000000000030 [ 305.651448] #PF: supervisor read access in kernel mode [ 305.656640] #PF: error_code(0x0000) - not-present page [ 305.661807] PGD 0 P4D 0 [ 305.664396] Oops: 0000 [#1] PREEMPT SMP NOPTI [ 305.668789] CPU: 3 PID: 183 Comm: kworker/3:2 Not tainted 5.5.0-rc6+ #1404 [ 305.675703] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.3201.A00.1905140358 05/14/2019 [ 305.689425] Workqueue: events drm_dp_delayed_destroy_work [ 305.694874] RIP: 0010:drm_dp_mst_atomic_check+0x138/0x2c0 [ 305.700306] Code: 00 00 00 41 29 d9 41 89 d8 4c 89 fa 4c 89 f1 48 c7 c6 b0 b1 34 82 bf 10 00 00 00 45 31 ed e8 3f 99 02 00 4d 8b bf 80 04 00 00 <49> 8b 47 30 49 8d 5f 30 4c 8d 60 e8 48 39 c3 74 35 49 8b 7c 24 28 [ 305.719169] RSP: 0018:ffffc90001687b58 EFLAGS: 00010246 [ 305.724434] RAX: 0000000000000000 RBX: 000000000000003f RCX: 0000000000000000 [ 305.731611] RDX: 0000000000000000 RSI: ffff88849fba8cb8 RDI: 00000000ffffffff [ 305.738785] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000001 [ 305.745962] R10: ffffc900016879a0 R11: ffffc900016879a5 R12: 0000000000000000 [ 305.753139] R13: 0000000000000000 R14: ffff8884905c9bc0 R15: 0000000000000000 [ 305.760315] FS: 0000000000000000(0000) GS:ffff88849fb80000(0000) knlGS:0000000000000000 [ 305.768452] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 305.774263] CR2: 0000000000000030 CR3: 0000000005610006 CR4: 0000000000760ee0 [ 305.781441] PKRU: 55555554 [ 305.784228] Call Trace: [ 305.786739] intel_atomic_check+0xb2e/0x2560 [i915] [ 305.791678] ? printk+0x53/0x6a [ 305.794856] ? drm_atomic_check_only+0x3e/0x810 [ 305.799417] ? __drm_dbg+0x82/0x90 [ 305.802848] drm_atomic_check_only+0x56a/0x810 [ 305.807322] drm_atomic_commit+0xe/0x50 [ 305.811185] drm_client_modeset_commit_atomic+0x1e2/0x250 [ 305.816619] drm_client_modeset_commit_force+0x4d/0x180 [ 305.821921] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0 [ 305.827963] drm_fb_helper_set_par+0x2b/0x40 [ 305.832265] drm_fb_helper_hotplug_event.part.0+0xb2/0xd0 [ 305.837755] drm_kms_helper_hotplug_event+0x21/0x30 [ 305.842694] process_one_work+0x25b/0x5b0 [ 305.846735] worker_thread+0x4b/0x3b0 [ 305.850439] kthread+0x100/0x140 [ 305.853690] ? process_one_work+0x5b0/0x5b0 [ 305.857901] ? kthread_park+0x80/0x80 [ 305.861588] ret_from_fork+0x24/0x50 [ 305.865202] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic i915 btusb btrtl btbcm btintel bluetooth prime_numbers snd_hda_intel snd_intel_dspcfg snd_hda_codec e1000e snd_hwdep snd_hda_core thunderbolt mei_hdcp mei_me asix cdc_ether x86_pkg_temp_thermal r8152 mei coretemp usbnet snd_pcm mii crct10dif_pclmul ptp crc32_pclmul ecdh_generic ghash_clmulni_intel pps_core ecc i2c_i801 intel_lpss_pci [ 305.903096] CR2: 0000000000000030 [ 305.906431] ---[ end trace 70ee364eed801cb0 ]--- [ 305.940816] RIP: 0010:drm_dp_mst_atomic_check+0x138/0x2c0 [ 305.946261] Code: 00 00 00 41 29 d9 41 89 d8 4c 89 fa 4c 89 f1 48 c7 c6 b0 b1 34 82 bf 10 00 00 00 45 31 ed e8 3f 99 02 00 4d 8b bf 80 04 00 00 <49> 8b 47 30 49 8d 5f 30 4c 8d 60 e8 48 39 c3 74 35 49 8b 7c 24 28 [ 305.965125] RSP: 0018:ffffc90001687b58 EFLAGS: 00010246 [ 305.970382] RAX: 0000000000000000 RBX: 000000000000003f RCX: 0000000000000000 [ 305.977571] RDX: 0000000000000000 RSI: ffff88849fba8cb8 RDI: 00000000ffffffff [ 305.984747] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000001 [ 305.991921] R10: ffffc900016879a0 R11: ffffc900016879a5 R12: 0000000000000000 [ 305.999099] R13: 0000000000000000 R14: ffff8884905c9bc0 R15: 0000000000000000 [ 306.006271] FS: 0000000000000000(0000) GS:ffff88849fb80000(0000) knlGS:0000000000000000 [ 306.014407] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 306.020185] CR2: 0000000000000030 CR3: 000000048b3aa003 CR4: 0000000000760ee0 [ 306.027404] PKRU: 55555554 [ 306.030127] BUG: sleeping function called from invalid context at include/linux/percpu-rwsem.h:38 [ 306.039049] in_atomic(): 0, irqs_disabled(): 1, non_block: 0, pid: 183, name: kworker/3:2 [ 306.047272] INFO: lockdep is turned off. [ 306.051217] irq event stamp: 77505 [ 306.054647] hardirqs last enabled at (77505): [<ffffffff81a0c147>] _raw_spin_unlock_irqrestore+0x47/0x60 [ 306.064270] hardirqs last disabled at (77504): [<ffffffff81a0bedf>] _raw_spin_lock_irqsave+0xf/0x50 [ 306.073404] softirqs last enabled at (77402): [<ffffffff81e00389>] __do_softirq+0x389/0x47f [ 306.081885] softirqs last disabled at (77395): [<ffffffff810b83a9>] irq_exit+0xa9/0xc0 [ 306.089859] CPU: 3 PID: 183 Comm: kworker/3:2 Tainted: G D 5.5.0-rc6+ #1404 [ 306.098167] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.3201.A00.1905140358 05/14/2019 [ 306.111882] Workqueue: events drm_dp_delayed_destroy_work [ 306.117314] Call Trace: [ 306.119780] dump_stack+0x71/0xa0 [ 306.123135] ___might_sleep.cold+0xf7/0x10b [ 306.127399] exit_signals+0x2b/0x360 [ 306.131014] do_exit+0xa7/0xc70 [ 306.134189] ? kthread+0x100/0x140 [ 306.137615] rewind_stack_do_exit+0x17/0x20 Fixes: cd82d82cbc ("drm/dp_mst: Add branch bandwidth validation to MST atomic check") Cc: Mikita Lipski <mikita.lipski@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Lyude Paul <lyude@redhat.com> Acked-by: Mikita Lipski <mikita.lipski@amd.com> Reviewed-by: Lyude Paul <lyude@redhat.com> Signed-off-by: José Roberto de Souza <jose.souza@intel.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>		2020-01-17 16:04:19 -05:00
..
amd	drm/amdgpu: add the lost mutex_init back	2020-01-17 16:03:09 -05:00
arc	DRM: ARC: PGU: add ARGB8888 format to supported format list	2019-12-16 13:53:05 +03:00
arm	drm-misc-next for v5.6:	2020-01-03 11:43:44 +10:00
armada	drm: constify fb ops across all drivers	2019-12-05 10:57:42 +02:00
aspeed
ast	drm/vram-helper: Remove BO device from public interface	2020-01-07 11:53:19 +01:00
atmel-hlcdc	Revert "drm: atmel-hlcdc: enable sys_clk during initalization."	2020-01-06 19:54:27 +01:00
bochs	drm/bochs: Remove unneeded semicolon	2019-12-16 12:39:50 +01:00
bridge	Revert "drm/bridge: Patch atomic hooks to take a drm_bridge_state"	2020-01-08 00:34:28 +01:00
cirrus	drm/simple-kms: Standardize arguments for callbacks	2019-10-24 13:55:56 +02:00
etnaviv	Merge tag 'amd-drm-next-5.6-2020-01-09' of git://people.freedesktop.org/~agd5f/linux into drm-next	2020-01-13 16:49:02 +10:00
exynos	drm/exynos: dsi: Fix bridge chain handling	2020-01-08 09:09:48 +01:00
fsl-dcu	drm/panel: decouple connector from drm_panel	2019-12-09 22:57:26 +01:00
gma500	drm/gma500: remove set but not used variables 'hist_reg'	2020-01-08 10:07:58 +01:00
hisilicon	drm/vram-helper: Remove BO device from public interface	2020-01-07 11:53:19 +01:00
i2c	drm: tda998x: use cec_notifier_conn_(un)register	2019-10-21 14:23:25 +02:00
i810	drm/i810: Don't include <drm/drm_pci.h>	2019-12-05 08:44:12 +01:00
i915	Merge tag 'amd-drm-next-5.6-2020-01-10-dp-mst-dsc' of git://people.freedesktop.org/~agd5f/linux into drm-next	2020-01-13 17:14:34 +10:00
imx	drm/panel: decouple connector from drm_panel	2019-12-09 22:57:26 +01:00
ingenic	gpu/drm: ingenic: Add support for the JZ4770	2019-12-14 19:26:55 +01:00
lib
lima	Merge tag 'amd-drm-next-5.6-2020-01-09' of git://people.freedesktop.org/~agd5f/linux into drm-next	2020-01-13 16:49:02 +10:00
mcde	drm-misc-next for v5.6:	2020-01-03 11:43:44 +10:00
mediatek	drm-misc-next for v5.6:	2020-01-03 11:43:44 +10:00
meson	drm: meson: fix address type confusion	2020-01-08 13:51:56 +01:00
mga	drm/mga: Don't include <drm/drm_pci.h>	2019-12-05 08:44:16 +01:00
mgag200	drm/mgag200: Add module parameter to pin all buffers at offset 0	2020-01-07 11:53:19 +01:00
msm	drm-misc-next for v5.6:	2020-01-03 11:43:44 +10:00
mxsfb	drm/panel: decouple connector from drm_panel	2019-12-09 22:57:26 +01:00
nouveau	drm/dp_mst: Manually overwrite PBN divider for calculating timeslots	2020-01-09 18:07:47 -05:00
omapdrm	drm/omapdrm: use BUG_ON macro for error debugging.	2020-01-08 18:35:36 +01:00
panel	drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support	2020-01-09 20:27:06 +01:00
panfrost	drm/scheduler: rework entity creation	2019-12-18 16:09:12 -05:00
pl111	drm: get drm_bridge_panel connector via helper	2019-12-09 22:57:26 +01:00
qxl	drm/qxl: Complete exception handling in qxl_device_init()	2019-11-29 13:09:11 +01:00
r128	drm/r128: Don't include <drm/drm_pci.h>	2019-12-05 08:44:23 +01:00
radeon	drm/dp_mst: Add PBN calculation for DSC modes	2020-01-09 18:07:46 -05:00
rcar-du	Revert "drm/bridge: Patch atomic hooks to take a drm_bridge_state"	2020-01-08 00:34:28 +01:00
rockchip	drm: rockchip: rk3066_hdmi: set edid fifo address	2020-01-06 12:22:29 +01:00
savage	drm/savage: Don't include <drm/drm_pci.h>	2019-12-05 08:44:34 +01:00
scheduler	drm/scheduler: fix documentation by replacing rq_list with sched_list	2020-01-16 13:41:00 -05:00
selftests	Merge tag 'amd-drm-next-5.6-2020-01-10-dp-mst-dsc' of git://people.freedesktop.org/~agd5f/linux into drm-next	2020-01-13 17:14:34 +10:00
shmobile
sis	drm/sis: Don't include <drm/drm_pci.h>	2019-12-05 08:44:55 +01:00
sti	drm/panel: decouple connector from drm_panel	2019-12-09 22:57:26 +01:00
stm	drm/stm: ltdc: move pinctrl to encoder mode set	2019-12-20 13:30:42 +01:00
sun4i	drm/sun4i: drc: Make sure we enforce the clock rate	2020-01-08 09:14:08 +01:00
tdfx	drm/tdfx: Don't include <drm/drm_pci.h>	2019-12-05 08:45:01 +01:00
tegra	drm/tegra: Provide ddc symlink in output connector sysfs directory	2020-01-07 20:25:24 +01:00
tilcdc	drm/tilcdc: Remove obsolete bundled tilcdc tfp410 driver	2019-12-16 10:45:43 +02:00
tiny	Merge tag 'topic/drm-mipi-dsi-dsc-updates-2019-11-11' of git://anongit.freedesktop.org/drm/drm-intel into drm-intel-next-queued	2019-11-20 15:54:38 +02:00
ttm	drm-misc-next for v5.6:	2019-12-17 13:57:54 +01:00
tve200	drm: get drm_bridge_panel connector via helper	2019-12-09 22:57:26 +01:00
udl	drm/udl: Make udl driver depend on CONFIG_USB	2020-01-09 15:02:48 +01:00
v3d	drm/scheduler: rework entity creation	2019-12-18 16:09:12 -05:00
vboxvideo	drm/vboxvideo: Use drm_gem_fb_create_with_dirty instead of drm_gem_fb_create	2019-10-29 13:10:07 +01:00
vc4	drm/vc4: dsi: Fix bridge chain handling	2020-01-08 09:09:48 +01:00
vgem
via	drm/via: Don't include <drm/drm_pci.h>	2019-12-05 08:45:13 +01:00
virtio	drm/virtio: move drm_connector_to_virtio_gpu_output to virtgpu_display	2019-12-19 07:13:46 +01:00
vkms	drm/vkms: Fix typo and preposion in function documentation	2019-12-05 18:55:55 -05:00
vmwgfx	drm-misc-next for v5.6:	2019-12-17 13:57:54 +01:00
xen	drm/xen: Simplify fb_create	2019-11-19 22:25:55 +01:00
zte	drm: zte: Provide ddc symlink in vga connector sysfs directory	2020-01-07 20:26:02 +01:00
drm_agpsupport.c	drm: use DIV_ROUND_UP helper macro for calculations	2019-11-04 18:17:36 +01:00
drm_atomic_helper.c	Revert "drm/bridge: Add a drm_bridge_state object"	2020-01-08 00:34:34 +01:00
drm_atomic_state_helper.c	drm: Add __drm_atomic_helper_crtc_state_reset() & co.	2019-12-18 16:47:34 +02:00
drm_atomic_uapi.c	drm/atomic: Spell CRTC consistently	2019-12-22 11:13:00 +01:00
drm_atomic.c	Revert "drm/bridge: Add a drm_bridge_state object"	2020-01-08 00:34:34 +01:00
drm_auth.c
drm_blend.c	drm: two planes with the same zpos have undefined ordering	2019-10-09 20:04:55 +02:00
drm_bridge.c	Revert "drm/bridge: Add a drm_bridge_state object"	2020-01-08 00:34:34 +01:00
drm_bufs.c
drm_cache.c	drm/gpu: Fix Memory barrier without comment Issue	2019-10-25 09:35:06 +02:00
drm_client_modeset.c	Revert "drm/fbdev: Fallback to non tiled mode if all tiles not present"	2019-11-25 16:55:40 +02:00
drm_client.c	drm/client: convert to drm device based logging	2019-12-19 15:52:44 +02:00
drm_color_mgmt.c	drm: Inline drm_color_lut_extract()	2019-11-29 21:29:17 +02:00
drm_connector.c	drm main pull for 5.5-rc1	2019-11-27 17:45:48 -08:00
drm_context.c
drm_crtc_helper_internal.h	drm/connector: Share with non-atomic drivers the function to get the single encoder	2019-09-16 15:13:02 -07:00
drm_crtc_helper.c	drm/crtc-helper: drm_connector_get_single_encoder prototype is missing	2019-12-03 17:42:57 +01:00
drm_crtc_internal.h
drm_crtc.c
drm_damage_helper.c	drm: damage_helper: Fix race checking plane->state->fb	2019-10-08 09:41:06 -04:00
drm_debugfs_crc.c	drm: Set crc->opened to false before setting crc source to NULL.	2020-01-07 15:29:40 -05:00
drm_debugfs.c
drm_dma.c
drm_dp_aux_dev.c	drm/dp_mst: Add MST support to DP DPCD R/W functions	2020-01-09 18:07:46 -05:00
drm_dp_cec.c	drm_dp_cec: drop use of drmP.h	2019-10-08 18:29:00 +02:00
drm_dp_dual_mode_helper.c
drm_dp_helper.c	drm: add dp helper to initialize remote aux channel.	2020-01-09 18:07:48 -05:00
drm_dp_mst_topology_internal.h	drm/dp_mst: Add sideband down request tracing + selftests	2019-09-03 19:30:06 -04:00
drm_dp_mst_topology.c	drm/mst: Don't do atomic checks over disabled managers	2020-01-17 16:04:19 -05:00
drm_drv.c	drm: remove duplicate check on parent and avoid BUG_ON	2019-12-17 17:26:08 +01:00
drm_dsc.c	drm/dsc: Fix bogus cpu_to_be16() usage	2019-09-30 20:15:53 +03:00
drm_dumb_buffers.c
drm_edid_load.c	drm/print: add drm_debug_enabled()	2019-10-02 16:28:55 +03:00
drm_edid.c	drm: Fix a couple of typos, punctation and whitespace issues	2019-12-22 11:09:46 +01:00
drm_encoder_slave.c
drm_encoder.c	drm/bridge: Make the bridge chain a double-linked list	2019-12-09 10:03:01 +01:00
drm_fb_cma_helper.c	drm/fb-cma-helpers: Fix include issue	2020-01-09 17:33:41 +01:00
drm_fb_helper.c	drm/fb-helper: convert to drm device based logging	2019-12-19 15:54:29 +02:00
drm_file.c	i915 features for v5.6:	2019-12-27 15:25:04 +10:00
drm_flip_work.c
drm_format_helper.c
drm_fourcc.c	drm/fourcc: Fill out all block sizes for P210	2019-11-28 11:19:32 +01:00
drm_framebuffer.c
drm_gem_cma_helper.c
drm_gem_framebuffer_helper.c	drm/gem-fb-helper: convert to drm device based logging	2019-12-19 15:55:10 +02:00
drm_gem_shmem_helper.c	drm: call drm_gem_object_funcs.mmap with fake offset	2019-12-06 11:18:11 +01:00
drm_gem_ttm_helper.c	drm/ttm: fix mmap refcounting	2019-11-15 08:00:08 +01:00
drm_gem_vram_helper.c	drm/vram-helper: Support struct drm_driver.gem_create_object	2020-01-07 11:53:19 +01:00
drm_gem.c	drm-misc-next for v5.6:	2019-12-17 13:57:54 +01:00
drm_hashtab.c
drm_hdcp.c
drm_internal.h	drm/pci: Only build drm_pci.c if CONFIG_PCI is set	2019-12-05 08:43:14 +01:00
drm_ioc32.c
drm_ioctl.c	drm: drop DRM_AUTH from PRIME_TO/FROM_HANDLE ioctls	2019-12-02 16:52:15 +00:00
drm_irq.c
drm_kms_helper_common.c
drm_lease.c
drm_legacy_misc.c
drm_legacy.h
drm_lock.c	gpu/drm: clean up white space in drm_legacy_lock_master_cleanup()	2020-01-08 19:51:11 +01:00
drm_memory.c	drm: Include prototype for drm_need_swiotlb()	2019-09-30 20:16:28 +03:00
drm_mipi_dbi.c	drm/mipi_dbi: Fix off-by-one bugs in mipi_dbi_blank()	2020-01-02 15:35:56 +01:00
drm_mipi_dsi.c	drm/dsi: add helpers for DSI compression mode and PPS packets	2019-11-07 15:00:16 +02:00
drm_mm.c	drm/mm: Use clear_bit_unlock() for releasing the drm_mm_node()	2019-10-04 13:43:43 +01:00
drm_mode_config.c	drm/modeset: Prime modeset lock vs dma_resv	2019-11-21 11:03:31 +01:00
drm_mode_object.c	drm/property: Enforce more lifetime rules	2019-11-04 18:17:36 +01:00
drm_modes.c	drm/modes: tag unused variables to avoid warnings	2020-01-09 17:17:28 +01:00
drm_modeset_helper.c
drm_modeset_lock.c
drm_of.c	drm: of: Add drm_of_lvds_get_dual_link_pixel_order	2019-12-18 02:40:16 +02:00
drm_panel_orientation_quirks.c
drm_panel.c	drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time	2019-12-17 20:39:33 +01:00
drm_pci.c	drm/pci: Hide legacy PCI functions from non-legacy code	2019-12-05 08:44:04 +01:00
drm_plane_helper.c
drm_plane.c
drm_prime.c	drm: share address space for dma bufs	2019-12-06 11:18:11 +01:00
drm_print.c	drm/print: convert debug category macros into an enum	2019-11-14 14:08:57 +02:00
drm_probe_helper.c	drm: Stop accessing encoder->bridge directly	2019-12-09 10:02:45 +01:00
drm_property.c	drm: limit to INT_MAX in create_blob ioctl	2019-12-04 19:44:13 -08:00
drm_rect.c	drm/rect: update kerneldoc for drm_rect_clip_scaled()	2019-11-28 13:15:43 +01:00
drm_scatter.c
drm_scdc_helper.c
drm_self_refresh_helper.c	drm/atomic: fix self-refresh helpers crtc state dereference	2019-11-06 13:00:21 -05:00
drm_simple_kms_helper.c	drm/simple-kms: Standardize arguments for callbacks	2019-10-24 13:55:56 +02:00
drm_syncobj.c	drm/syncobj: extend syncobj query ability v3	2019-10-18 12:24:56 +02:00
drm_sysfs.c
drm_trace_points.c
drm_trace.h	drm: Add high-precision time to vblank trace event	2019-09-03 09:46:18 +02:00
drm_vblank.c	drm/drm_vblank: Change EINVAL by the correct errno	2019-10-08 18:43:26 -04:00
drm_vm.c
drm_vma_manager.c
drm_vram_helper_common.c	drm/vram: Have VRAM MM call GEM VRAM functions directly	2019-09-12 19:54:42 +02:00
drm_writeback.c	drm: Clear the fence pointer when writeback job signaled	2019-09-23 15:32:53 +08:00
Kconfig	drm/Kconfig: add missing 'depends on DRM' for DRM_DP_CEC	2020-01-09 10:16:35 +01:00
Makefile	drm/pci: Only build drm_pci.c if CONFIG_PCI is set	2019-12-05 08:43:14 +01:00