79eec5b940
device_node np contains a garbage value from the stack and it is only set if chip->dev.parent->of_node is not null. Thus the check for a null np won't spot a garbage value of np from the stack if chip->dev.parent->of_node is null and if np contains an garbage non-null value. I believe the correct fix is to return -ENODEV if and only if chip->dev.parent->of_node is null. Found with static analysis by CoverityScan, CID 1377755 Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
60 lines
1.3 KiB
C
60 lines
1.3 KiB
C
/*
|
|
* Copyright 2012 IBM Corporation
|
|
*
|
|
* Author: Ashley Lai <ashleydlai@gmail.com>
|
|
* Nayna Jain <nayna@linux.vnet.ibm.com>
|
|
*
|
|
* Maintained by: <tpmdd-devel@lists.sourceforge.net>
|
|
*
|
|
* Read the event log created by the firmware on PPC64
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*
|
|
*/
|
|
|
|
#include <linux/slab.h>
|
|
#include <linux/of.h>
|
|
|
|
#include "tpm.h"
|
|
#include "tpm_eventlog.h"
|
|
|
|
int tpm_read_log_of(struct tpm_chip *chip)
|
|
{
|
|
struct device_node *np;
|
|
const u32 *sizep;
|
|
const u64 *basep;
|
|
struct tpm_bios_log *log;
|
|
|
|
log = &chip->log;
|
|
if (chip->dev.parent->of_node)
|
|
np = chip->dev.parent->of_node;
|
|
else
|
|
return -ENODEV;
|
|
|
|
sizep = of_get_property(np, "linux,sml-size", NULL);
|
|
if (sizep == NULL)
|
|
return -EIO;
|
|
|
|
if (*sizep == 0) {
|
|
dev_warn(&chip->dev, "%s: Event log area empty\n", __func__);
|
|
return -EIO;
|
|
}
|
|
|
|
basep = of_get_property(np, "linux,sml-base", NULL);
|
|
if (basep == NULL)
|
|
return -EIO;
|
|
|
|
log->bios_event_log = kmalloc(*sizep, GFP_KERNEL);
|
|
if (!log->bios_event_log)
|
|
return -ENOMEM;
|
|
|
|
log->bios_event_log_end = log->bios_event_log + *sizep;
|
|
|
|
memcpy(log->bios_event_log, __va(*basep), *sizep);
|
|
|
|
return 0;
|
|
}
|