leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
79d73346ac05bc31f2e96f899c4e9aaaa616a8d4
linux/drivers/ide
History
Hongxu Jia 79d73346ac ide:ide-cd: fix kernel panic resulting from missing scsi_req_init 
Since we split the scsi_request out of struct request, while the
standard prep_rq_fn builds 10 byte cmds, it missed to invoke
scsi_req_init() to initialize certain fields of a scsi_request
structure (.__cmd[], .cmd, .cmd_len and .sense_len but no other
members of struct scsi_request).

An example panic on virtual machines (qemu/virtualbox) to boot
from IDE cdrom:
...
[    8.754381] Call Trace:
[    8.755419]  blk_peek_request+0x182/0x2e0
[    8.755863]  blk_fetch_request+0x1c/0x40
[    8.756148]  ? ktime_get+0x40/0xa0
[    8.756385]  do_ide_request+0x37d/0x660
[    8.756704]  ? cfq_group_service_tree_add+0x98/0xc0
[    8.757011]  ? cfq_service_tree_add+0x1e5/0x2c0
[    8.757313]  ? ktime_get+0x40/0xa0
[    8.757544]  __blk_run_queue+0x3d/0x60
[    8.757837]  queue_unplugged+0x2f/0xc0
[    8.758088]  blk_flush_plug_list+0x1f4/0x240
[    8.758362]  blk_finish_plug+0x2c/0x40
...
[    8.770906] RIP: ide_cdrom_prep_fn+0x63/0x180 RSP: ffff92aec018bae8
[    8.772329] ---[ end trace 6408481e551a85c9 ]---
...

Fixes: 82ed4db499 ("block: split scsi_request out of struct request")

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2017-11-01 08:21:58 -06:00
..
aec62xx.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
ali14xx.c
sections: fix section conflicts in drivers/ide
2012-10-06 03:04:41 +09:00
alim15x3.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
amd74xx.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
atiixp.c
Drivers: ide: Remove typedef atiixp_ide_timing
2014-10-15 14:27:38 -04:00
au1xxx-ide.c
ide: drop owner assignment from platform_drivers
2014-10-20 16:20:38 +02:00
buddha.c
zorro: ZTWO_VADDR() should return "void __iomem *"
2013-11-26 11:09:07 +01:00
cmd64x.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
cmd640.c
cmd640: add __init attribute
2016-07-26 15:25:30 -07:00
cs5520.c
ide: remove deprecated use of pci api
2015-04-17 15:32:07 -04:00
cs5530.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
cs5535.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
cs5536.c
ide: cs5536: use module_pci_driver()
2013-11-14 18:21:25 -05:00
cy82c693.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
delkin_cb.c
drivers/ide/delkin_cb: Convert to module_pci_driver
2013-07-10 12:09:10 -07:00
dtc2278.c
sections: fix section conflicts in drivers/ide
2012-10-06 03:04:41 +09:00
falconide.c
…
gayle.c
ide: drop owner assignment from platform_drivers
2014-10-20 16:20:38 +02:00
hpt366.c
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
ht6560b.c
sections: fix section conflicts in drivers/ide
2012-10-06 03:04:41 +09:00
icside.c
ide: icside: remove incorrect initconst annotation
2016-03-20 16:59:27 -04:00
ide_platform.c
ide: drop owner assignment from platform_drivers
2014-10-20 16:20:38 +02:00
ide-4drives.c
module_param: make bool parameters really bool (drivers & misc)
2012-01-13 09:32:20 +10:30
ide-acpi.c
lib/vsprintf.c: remove %Z support
2017-02-27 18:43:47 -08:00
ide-atapi.c
block: Change argument type of scsi_req_init()
2017-06-20 19:27:14 -06:00
ide-cd_ioctl.c
block: Make most scsi_req_init() calls implicit
2017-06-20 19:27:14 -06:00
ide-cd_verbose.c
block: split scsi_request out of struct request
2017-01-27 15:08:35 -07:00
ide-cd.c
ide:ide-cd: fix kernel panic resulting from missing scsi_req_init
2017-11-01 08:21:58 -06:00
ide-cd.h
block: split out request-only flags into a new namespace
2016-10-28 08:45:17 -06:00
ide-cs.c
drivers/ide/ide-cs.c: adjust suspicious bit operation
2012-06-12 15:51:41 -07:00
ide-devsets.c
block: Make most scsi_req_init() calls implicit
2017-06-20 19:27:14 -06:00
ide-disk_ioctl.c
block: autoconvert trivial BKL users to private mutex
2010-10-05 15:01:10 +02:00
ide-disk_proc.c
procfs: new helper - PDE_DATA(inode)
2013-04-09 14:13:32 -04:00
ide-disk.c
block: Make most scsi_req_init() calls implicit
2017-06-20 19:27:14 -06:00
ide-disk.h
…
ide-dma-sff.c
ide/ata: Add export.h for EXPORT_SYMBOL/THIS_MODULE where needed
2011-10-31 19:31:37 -04:00
ide-dma.c
block: introduce new block status code type
2017-06-09 09:27:32 -06:00
ide-eh.c
block: introduce new block status code type
2017-06-09 09:27:32 -06:00
ide-floppy_ioctl.c
block: add and use scsi_blk_cmd_ioctl
2012-01-14 15:07:24 -08:00
ide-floppy_proc.c
procfs: new helper - PDE_DATA(inode)
2013-04-09 14:13:32 -04:00
ide-floppy.c
ide-floppy: Use blk_rq_is_scsi()
2017-08-18 08:36:58 -06:00
ide-floppy.h
…
ide-gd.c
block: convert to device_add_disk()
2016-06-27 12:26:08 -07:00
ide-gd.h
…
ide-generic.c
Revert "ide: Fix interface autodetection in legacy IDE driver (trial #2)"
2017-01-09 15:27:59 -05:00
ide-io-std.c
ide/ata: Add export.h for EXPORT_SYMBOL/THIS_MODULE where needed
2011-10-31 19:31:37 -04:00
ide-io.c
block: introduce new block status code type
2017-06-09 09:27:32 -06:00
ide-ioctls.c
block: Make most scsi_req_init() calls implicit
2017-06-20 19:27:14 -06:00
ide-iops.c
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
ide-legacy.c
ide/ata: Add export.h for EXPORT_SYMBOL/THIS_MODULE where needed
2011-10-31 19:31:37 -04:00
ide-lib.c
ide,ata: Rename ATA_IDX to ATA_SENSE
2015-03-27 11:59:22 -04:00
ide-park.c
block: Make most scsi_req_init() calls implicit
2017-06-20 19:27:14 -06:00
ide-pci-generic.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
ide-pio-blacklist.c
drivers: ide: Include appropriate header file in ide-pio-blacklist.c
2014-01-28 23:35:09 -08:00
ide-pm.c
block: Make most scsi_req_init() calls implicit
2017-06-20 19:27:14 -06:00
ide-pnp.c
PNP: ide/ide-pnp: Use module_pnp_driver to register driver
2015-03-18 22:39:17 +01:00
ide-probe.c
ide: free hwif->portdev on hwif_init() failure
2017-10-03 13:36:17 -05:00
ide-proc.c
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
ide-scan-pci.c
ide: fix IRQ assignment for PCI bus order probing
2017-10-03 14:03:31 -05:00
ide-sysfs.c
ide: convert bus code to use dev_groups
2013-10-16 18:40:57 -07:00
ide-tape.c
block: Make most scsi_req_init() calls implicit
2017-06-20 19:27:14 -06:00
ide-taskfile.c
block: Make most scsi_req_init() calls implicit
2017-06-20 19:27:14 -06:00
ide-timings.c
ide: avoid warning for timings calculation
2017-07-21 04:37:22 +01:00
ide-xfer-mode.c
ide/ata: Add export.h for EXPORT_SYMBOL/THIS_MODULE where needed
2011-10-31 19:31:37 -04:00
ide.c
ide: silence some underflow warnings
2016-01-18 14:12:33 -05:00
it821x.c
ide: constify ide_dma_ops structures
2016-01-18 14:12:33 -05:00
it8172.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
it8213.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
jmicron.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
Kconfig
block: make scsi_request and scsi ioctl support optional
2017-01-31 10:53:05 -07:00
macide.c
ide/ata: Add module.h to the implicit modular users
2011-10-31 19:31:37 -04:00
Makefile
Remove celleb-only SCC PATA drivers
2015-04-14 13:07:17 -04:00
ns87415.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
opti621.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
palm_bk3710.c
ide: palm_bk3710: add __initdata to palm_bk3710_port_info
2017-02-27 20:43:26 -05:00
pdc202xx_new.c
PCI: Remove includes of asm/pci-bridge.h
2016-02-05 16:29:28 -06:00
pdc202xx_old.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
piix.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
pmac.c
ide: pmac: Convert to using %pOF instead of full_name
2017-09-01 16:42:51 +10:00
q40ide.c
ide/ata: Add module.h to the implicit modular users
2011-10-31 19:31:37 -04:00
qd65xx.c
sections: fix section conflicts in drivers/ide
2012-10-06 03:04:41 +09:00
qd65xx.h
…
rapide.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
rz1000.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
sc1200.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
serverworks.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
setup-pci.c
ide: pci: free PCI BARs on initialization failure
2017-10-03 14:02:57 -05:00
sgiioc4.c
ide: remove deprecated use of pci api
2015-04-17 15:32:07 -04:00
siimage.c
block: introduce new block status code type
2017-06-09 09:27:32 -06:00
sis5513.c
block: split scsi_request out of struct request
2017-01-27 15:08:35 -07:00
sl82c105.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
slc90e66.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
tc86c001.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
triflex.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00
trm290.c
ide: constify ide_dma_ops structures
2016-01-18 14:12:33 -05:00
tx4938ide.c
ide: drop owner assignment from platform_drivers
2014-10-20 16:20:38 +02:00
tx4939ide.c
ide: drop owner assignment from platform_drivers
2014-10-20 16:20:38 +02:00
umc8672.c
sections: fix section conflicts in drivers/ide
2012-10-06 03:04:41 +09:00
via82cxxx.c
Drivers: ide: remove __dev* attributes.
2013-01-03 15:57:03 -08:00