linux

mainlining shenanigans

Go to file

Ondrej Mosnacek 78105c7e76 crypto: xts - Drop use of auxiliary buffer Since commit `acb9b159c7` ("crypto: gf128mul - define gf128mul_x_* in gf128mul.h"), the gf128mul_x_*() functions are very fast and therefore caching the computed XTS tweaks has only negligible advantage over computing them twice. In fact, since the current caching implementation limits the size of the calls to the child ecb(...) algorithm to PAGE_SIZE (usually 4096 B), it is often actually slower than the simple recomputing implementation. This patch simplifies the XTS template to recompute the XTS tweaks from scratch in the second pass and thus also removes the need to allocate a dynamic buffer using kmalloc(). As discussed at [1], the use of kmalloc causes deadlocks with dm-crypt. PERFORMANCE RESULTS I measured time to encrypt/decrypt a memory buffer of varying sizes with xts(ecb-aes-aesni) using a tool I wrote ([2]) and the results suggest that after this patch the performance is either better or comparable for both small and large buffers. Note that there is a lot of noise in the measurements, but the overall difference is easy to see. Old code: ALGORITHM KEY (b) DATA (B) TIME ENC (ns) TIME DEC (ns) xts(aes) 256 64 331 328 xts(aes) 384 64 332 333 xts(aes) 512 64 338 348 xts(aes) 256 512 889 920 xts(aes) 384 512 1019 993 xts(aes) 512 512 1032 990 xts(aes) 256 4096 2152 2292 xts(aes) 384 4096 2453 2597 xts(aes) 512 4096 3041 2641 xts(aes) 256 16384 9443 8027 xts(aes) 384 16384 8536 8925 xts(aes) 512 16384 9232 9417 xts(aes) 256 32768 16383 14897 xts(aes) 384 32768 17527 16102 xts(aes) 512 32768 18483 17322 New code: ALGORITHM KEY (b) DATA (B) TIME ENC (ns) TIME DEC (ns) xts(aes) 256 64 328 324 xts(aes) 384 64 324 319 xts(aes) 512 64 320 322 xts(aes) 256 512 476 473 xts(aes) 384 512 509 492 xts(aes) 512 512 531 514 xts(aes) 256 4096 2132 1829 xts(aes) 384 4096 2357 2055 xts(aes) 512 4096 2178 2027 xts(aes) 256 16384 6920 6983 xts(aes) 384 16384 8597 7505 xts(aes) 512 16384 7841 8164 xts(aes) 256 32768 13468 12307 xts(aes) 384 32768 14808 13402 xts(aes) 512 32768 15753 14636 [1] https://lkml.org/lkml/2018/8/23/1315 [2] https://gitlab.com/omos/linux-crypto-bench Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>		2018-09-21 13:24:50 +08:00
arch	crypto: arm64/aes-blk - improve XTS mask handling	2018-09-21 13:24:50 +08:00
block	block: bsg: move atomic_t ref_count variable to refcount API	2018-08-27 19:17:02 -06:00
certs
crypto	crypto: xts - Drop use of auxiliary buffer	2018-09-21 13:24:50 +08:00
Documentation	crypto: speck - remove Speck	2018-09-04 11:35:03 +08:00
drivers	crypto: cavium/nitrox - use dma_pool_zalloc()	2018-09-21 13:24:49 +08:00
firmware
fs	crypto: speck - remove Speck	2018-09-04 11:35:03 +08:00
include	crc-t10dif: Pick better transform if one becomes available	2018-09-04 11:37:05 +08:00
init	Kbuild updates for v4.19 (2nd)	2018-08-25 13:40:38 -07:00
ipc
kernel	Merge branch 'smp-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-09-02 10:09:35 -07:00
lib	crc-t10dif: crc_t10dif_mutex can be static	2018-09-14 14:08:52 +08:00
LICENSES
mm	notifier: Remove notifier header file wherever not used	2018-08-30 12:56:40 +02:00
net	Merge branch 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-09-02 09:41:45 -07:00
samples
scripts	Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-09-02 10:11:30 -07:00
security	+ Cleanups	2018-08-24 13:00:33 -07:00
sound	Merge branch 'akpm' (patches from Andrew)	2018-08-23 19:20:12 -07:00
tools	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-08-27 11:59:39 -07:00
usr
virt	ARM: Support for Group0 interrupts in guests, Cache management	2018-08-22 13:52:44 -07:00
.clang-format
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore
.mailmap	libnvdimm-for-4.19_misc	2018-08-25 18:13:10 -07:00
COPYING
CREDITS
Kbuild
Kconfig
MAINTAINERS	crypto: x86 - remove SHA multibuffer routines and mcryptd	2018-09-04 11:37:04 +08:00
Makefile	Linux 4.19-rc2	2018-09-02 14:37:30 -07:00
README

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.
See Documentation/00-INDEX for a list of what is contained in each file.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.