leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
75659c6fb5
linux/drivers/platform/x86/intel
History
Prarit Bhargava 2cdfa0c20d platform/x86/intel: Fix 'rmmod pmt_telemetry' panic 
'rmmod pmt_telemetry' panics with:

 BUG: kernel NULL pointer dereference, address: 0000000000000040
 #PF: supervisor read access in kernel mode
 #PF: error_code(0x0000) - not-present page
 PGD 0 P4D 0
 Oops: 0000 [#1] PREEMPT SMP NOPTI
 CPU: 4 PID: 1697 Comm: rmmod Tainted: G S      W        --------  ---  5.18.0-rc4 #3
 Hardware name: Intel Corporation Alder Lake Client Platform/AlderLake-P DDR5 RVP, BIOS ADLPFWI1.R00.3056.B00.2201310233 01/31/2022
 RIP: 0010:device_del+0x1b/0x3d0
 Code: e8 1a d9 e9 ff e9 58 ff ff ff 48 8b 08 eb dc 0f 1f 44 00 00 41 56 41 55 41 54 55 48 8d af 80 00 00 00 53 48 89 fb 48 83 ec 18 <4c> 8b 67 40 48 89 ef 65 48 8b 04 25 28 00 00 00 48 89 44 24 10 31
 RSP: 0018:ffffb520415cfd60 EFLAGS: 00010286
 RAX: 0000000000000070 RBX: 0000000000000000 RCX: 0000000000000000
 RDX: 0000000000000001 RSI: 0000000000000000 RDI: 0000000000000000
 RBP: 0000000000000080 R08: ffffffffffffffff R09: ffffb520415cfd78
 R10: 0000000000000002 R11: ffffb520415cfd78 R12: 0000000000000000
 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
 FS:  00007f7e198e5740(0000) GS:ffff905c9f700000(0000) knlGS:0000000000000000
 CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 CR2: 0000000000000040 CR3: 000000010782a005 CR4: 0000000000770ee0
 PKRU: 55555554
 Call Trace:
  <TASK>
  ? __xa_erase+0x53/0xb0
  device_unregister+0x13/0x50
  intel_pmt_dev_destroy+0x34/0x60 [pmt_class]
  pmt_telem_remove+0x40/0x50 [pmt_telemetry]
  auxiliary_bus_remove+0x18/0x30
  device_release_driver_internal+0xc1/0x150
  driver_detach+0x44/0x90
  bus_remove_driver+0x74/0xd0
  auxiliary_driver_unregister+0x12/0x20
  pmt_telem_exit+0xc/0xe4a [pmt_telemetry]
  __x64_sys_delete_module+0x13a/0x250
  ? syscall_trace_enter.isra.19+0x11e/0x1a0
  do_syscall_64+0x58/0x80
  ? syscall_exit_to_user_mode+0x12/0x30
  ? do_syscall_64+0x67/0x80
  ? syscall_exit_to_user_mode+0x12/0x30
  ? do_syscall_64+0x67/0x80
  ? syscall_exit_to_user_mode+0x12/0x30
  ? do_syscall_64+0x67/0x80
  ? exc_page_fault+0x64/0x140
  entry_SYSCALL_64_after_hwframe+0x44/0xae
 RIP: 0033:0x7f7e1803a05b
 Code: 73 01 c3 48 8b 0d 2d 4e 38 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa b8 b0 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d fd 4d 38 00 f7 d8 64 89 01 48

The probe function, pmt_telem_probe(), adds an entry for devices even if
they have not been initialized.  This results in the array of initialized
devices containing both initialized and uninitialized entries.  This
causes a panic in the remove function, pmt_telem_remove() which expects
the array to only contain initialized entries.

Only use an entry when a device is initialized.

Cc: "David E. Box" <david.e.box@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <markgross@kernel.org>
Cc: platform-driver-x86@vger.kernel.org
Signed-off-by: David Arcari <darcari@redhat.com>
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Reviewed-by: David E. Box <david.e.box@linux.intel.com>
Link: https://lore.kernel.org/r/20220429122322.2550003-1-prarit@redhat.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
2022-05-06 13:05:57 +02:00
..
atomisp2 platform/x86: intel_atomisp2: Move to intel sub-directory 2021-08-20 20:11:23 +02:00
int1092 platform/x86: int1092: Fix non sequential device mode handling 2021-10-11 16:38:32 +02:00
int3472 platform/x86: int3472: Add terminator to gpiod_lookup_table 2022-02-21 14:43:47 +01:00
pmc platform/x86/intel: pmc/core: change pmc_lpm_modes to static 2022-04-27 16:55:54 +02:00
pmt platform/x86/intel: Fix 'rmmod pmt_telemetry' panic 2022-05-06 13:05:57 +02:00
speed_select_if platform/x86: ISST: Fix possible circular locking dependency detected 2022-01-24 10:41:46 +01:00
telemetry platform/x86: intel_telemetry: Move to intel sub-directory 2021-08-20 20:08:09 +02:00
uncore-frequency platform/x86: intel-uncore-freq: Prevent driver loading in guests 2022-04-27 16:55:54 +02:00
wmi platform/x86: intel-wmi-thunderbolt: Move to intel sub-directory 2021-08-20 20:11:23 +02:00
bxtwc_tmu.c platform/x86: intel_bxtwc_tmu: Move to intel sub-directory 2021-08-20 20:00:02 +02:00
chtdc_ti_pwrbtn.c platform/x86: intel_chtdc_ti_pwrbtn: Move to intel sub-directory 2021-08-20 20:00:02 +02:00
chtwc_int33fe.c platform/x86: intel_cht_int33fe: Move to intel directory 2022-02-11 10:52:56 +01:00
crystal_cove_charger.c platform/x86: intel_crystal_cove_charger: Fix IRQ masking / unmasking 2022-01-24 10:41:46 +01:00
hid.c platform/x86: Replace acpi_bus_get_device() 2022-02-03 11:55:57 +01:00
int0002_vgpio.c platform/x86: intel_int0002_vgpio: Use the new soc_intel_is_byt()/_cht() helpers 2021-10-19 17:31:24 +02:00
ishtp_eclite.c HID: intel-ish-hid: fix module device-id handling 2021-11-11 22:45:40 +01:00
Kconfig platform/x86/intel/uncore-freq: Move to uncore-frequency folder 2022-02-17 13:20:30 +01:00
Makefile platform/x86/intel/uncore-freq: Move to uncore-frequency folder 2022-02-17 13:20:30 +01:00
mrfld_pwrbtn.c platform/x86: intel_mrfld_pwrbtn: Move to intel sub-directory 2021-08-20 20:00:02 +02:00
oaktrail.c platform/x86: intel_oaktrail: Move to intel sub-directory 2021-08-20 20:11:23 +02:00
punit_ipc.c platform/x86/intel: punit_ipc: Drop wrong use of ACPI_PTR() 2021-09-13 10:36:52 +02:00
rst.c platform/x86: intel-rst: Move to intel sub-directory 2021-08-20 20:09:43 +02:00
sdsi.c platform/x86/intel/sdsi: Fix bug in multi packet reads 2022-04-27 16:55:54 +02:00
smartconnect.c platform/x86: intel-smartconnect: Move to intel sub-directory 2021-08-20 20:11:12 +02:00
turbo_max_3.c platform/x86: intel_turbo_max_3: Move to intel sub-directory 2021-08-20 20:11:22 +02:00
vbtn.c platform/x86: Replace acpi_bus_get_device() 2022-02-03 11:55:57 +01:00
vsec.c platform/x86: Add Intel Software Defined Silicon driver 2022-02-14 11:45:20 +01:00
vsec.h platform/x86/intel: Move intel_pmt from MFD to Auxiliary Bus 2021-12-22 13:56:19 +01:00