linux/drivers/net/wireless/marvell
Brian Norris 755b37c93a mwifiex: catch mwifiex_fw_dpc() errors properly in reset
When resetting the device, we take a synchronous firmware-loading code
path, which borrows a lot from the asynchronous path used at probe time.
We don't catch errors correctly though, which means that in the PCIe
driver, we may try to dereference the 'adapter' struct after
mwifiex_fw_dpc() has freed it. See this (erronous) print in
mwifiex_pcie_reset_notify():

	mwifiex_dbg(adapter, INFO, "%s, successful\n", __func__);

Let's instead refactor the synchronous (or "!req_fw_nowait") path so
that we propagate errors and handle them properly.

This fixes a use-after-free issue in the PCIe driver, as well as a
misleading debug message ("successful"). It looks like the SDIO driver
doesn't have these problems, since it doesn't do anything after
mwifiex_reinit_sw().

Fixes: 4c5dae59d2 ("mwifiex: add PCIe function level reset support")
Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
2017-04-05 15:44:04 +03:00
..
libertas libertas: fix improper return value 2017-01-19 14:38:43 +02:00
libertas_tf net: wireless: marvell: libertas_tf: if_usb: don't print error when allocating urb fails 2016-08-13 14:53:41 -07:00
mwifiex mwifiex: catch mwifiex_fw_dpc() errors properly in reset 2017-04-05 15:44:04 +03:00
Kconfig
Makefile
mwl8k.c cfg80211: remove enum ieee80211_band 2016-04-12 15:56:15 +02:00