Arnd Bergmann 5eca2914f3 dsa: b53: avoid 'maybe-uninitialized' warning ... In some configurations, gcc produces a warning for correct code in this driver: drivers/net/dsa/b53/b53_mmap.c: In function 'b53_mmap_read64': drivers/net/dsa/b53/b53_mmap.c:107:10: error: 'hi' may be used uninitialized in this function [-Werror=maybe-uninitialized] *val = ((u64)hi << 32) | lo; ^~~~~~~ drivers/net/dsa/b53/b53_mmap.c: In function 'b53_mmap_read48': drivers/net/dsa/b53/b53_mmap.c:91:11: error: 'hi' may be used uninitialized in this function [-Werror=maybe-uninitialized] *val = ((u64)hi << 32) | lo; ^~~~~~~ drivers/net/dsa/b53/b53_mmap.c:83:11: error: 'hi' may be used uninitialized in this function [-Werror=maybe-uninitialized] *val = ((u64)hi << 16) | lo; I have seen the warning before and at the time thought I had fixed it with 55e7f6abe1 ("dsa: b53: fix big-endian register access"), however it now came back in a different randconfig build that happens to have different inlining decisions in the compiler. The mistake that gcc makes here is that it thinks the second call to readl() might fail because the address 'reg + 4' is not a multiple of four despite having knowing that 'reg' itself is a multiple of four. By open-coding the two reads without the redundant alignment check, we can avoid the warning and produce slightly better object code, but get slightly longer source code instead. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: David S. Miller <davem@davemloft.net>		2016-06-29 05:07:12 -04:00
..
b53_common.c	net: dsa: b53: Fix statistics readings	2016-06-23 15:13:48 -04:00
b53_mdio.c
b53_mmap.c	dsa: b53: avoid 'maybe-uninitialized' warning	2016-06-29 05:07:12 -04:00
b53_priv.h	net: dsa: b53: Plug in VLAN support	2016-06-09 22:21:29 -07:00
b53_regs.h	net: dsa: b53: Add bridge support	2016-06-09 22:21:29 -07:00
b53_spi.c
b53_srab.c
Kconfig
Makefile