12cb90ba89
This structure is only used to copy into other structure, so declare
it as const.
This issue was detected using Coccinelle and the following semantic patch:
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct gpio_chip i@p = { ... };
@ok@
identifier r.i;
expression e;
position p;
@@
e = i@p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct gpio_chip e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct gpio_chip i = { ... };
In the following log you can see a significant difference in the code size
and data segment, hence in the dec segment. This log is the output
of the size command, before and after the code change:
before:
text data bss dec hex filename
13129 2808 192 16129 3f01 drivers/pinctrl/qcom/pinctrl-msm.o
after:
text data bss dec hex filename
12839 2720 192 15751 3d87 drivers/pinctrl/qcom/pinctrl-msm.o
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| pinctrl-apq8064.c | ||
| pinctrl-apq8084.c | ||
| pinctrl-ipq4019.c | ||
| pinctrl-ipq8064.c | ||
| pinctrl-ipq8074.c | ||
| pinctrl-mdm9615.c | ||
| pinctrl-msm8x74.c | ||
| pinctrl-msm8660.c | ||
| pinctrl-msm8916.c | ||
| pinctrl-msm8960.c | ||
| pinctrl-msm8994.c | ||
| pinctrl-msm8996.c | ||
| pinctrl-msm.c | ||
| pinctrl-msm.h | ||
| pinctrl-qdf2xxx.c | ||
| pinctrl-spmi-gpio.c | ||
| pinctrl-spmi-mpp.c | ||
| pinctrl-ssbi-gpio.c | ||
| pinctrl-ssbi-mpp.c | ||