62d0fd591d
As the bug report [1] pointed out, <linux/vermagic.h> must be included after <linux/module.h>. I believe we should not impose any include order restriction. We often sort include directives alphabetically, but it is just coding style convention. Technically, we can include header files in any order by making every header self-contained. Currently, arch-specific MODULE_ARCH_VERMAGIC is defined in <asm/module.h>, which is not included from <linux/vermagic.h>. Hence, the straight-forward fix-up would be as follows: |--- a/include/linux/vermagic.h |+++ b/include/linux/vermagic.h |@@ -1,5 +1,6 @@ | /* SPDX-License-Identifier: GPL-2.0 */ | #include <generated/utsrelease.h> |+#include <linux/module.h> | | /* Simply sanity version stamp for modules. */ | #ifdef CONFIG_SMP This works enough, but for further cleanups, I split MODULE_ARCH_VERMAGIC definitions into <asm/vermagic.h>. With this, <linux/module.h> and <linux/vermagic.h> will be orthogonal, and the location of MODULE_ARCH_VERMAGIC definitions will be consistent. For arc and ia64, MODULE_PROC_FAMILY is only used for defining MODULE_ARCH_VERMAGIC. I squashed it. For hexagon, nds32, and xtensa, I removed <asm/modules.h> entirely because they contained nothing but MODULE_ARCH_VERMAGIC definition. Kbuild will automatically generate <asm/modules.h> at build-time, wrapping <asm-generic/module.h>. [1] https://lore.kernel.org/lkml/20200411155623.GA22175@zn.tnic Reported-by: Borislav Petkov <bp@suse.de> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Acked-by: Jessica Yu <jeyu@kernel.org>
52 lines
950 B
C
52 lines
950 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _ASM_ARM_MODULE_H
|
|
#define _ASM_ARM_MODULE_H
|
|
|
|
#include <asm-generic/module.h>
|
|
|
|
struct unwind_table;
|
|
|
|
#ifdef CONFIG_ARM_UNWIND
|
|
enum {
|
|
ARM_SEC_INIT,
|
|
ARM_SEC_DEVINIT,
|
|
ARM_SEC_CORE,
|
|
ARM_SEC_EXIT,
|
|
ARM_SEC_DEVEXIT,
|
|
ARM_SEC_HOT,
|
|
ARM_SEC_UNLIKELY,
|
|
ARM_SEC_MAX,
|
|
};
|
|
#endif
|
|
|
|
struct mod_plt_sec {
|
|
struct elf32_shdr *plt;
|
|
int plt_count;
|
|
};
|
|
|
|
struct mod_arch_specific {
|
|
#ifdef CONFIG_ARM_UNWIND
|
|
struct unwind_table *unwind[ARM_SEC_MAX];
|
|
#endif
|
|
#ifdef CONFIG_ARM_MODULE_PLTS
|
|
struct mod_plt_sec core;
|
|
struct mod_plt_sec init;
|
|
#endif
|
|
};
|
|
|
|
struct module;
|
|
u32 get_module_plt(struct module *mod, unsigned long loc, Elf32_Addr val);
|
|
|
|
#ifdef CONFIG_THUMB2_KERNEL
|
|
#define HAVE_ARCH_KALLSYMS_SYMBOL_VALUE
|
|
static inline unsigned long kallsyms_symbol_value(const Elf_Sym *sym)
|
|
{
|
|
if (ELF_ST_TYPE(sym->st_info) == STT_FUNC)
|
|
return sym->st_value & ~1;
|
|
|
|
return sym->st_value;
|
|
}
|
|
#endif
|
|
|
|
#endif /* _ASM_ARM_MODULE_H */
|