5979afa2c4
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit
|
||
---|---|---|
.. | ||
cfg80211.c | ||
hfa384x_usb.c | ||
hfa384x.h | ||
Kconfig | ||
Makefile | ||
p80211conv.c | ||
p80211conv.h | ||
p80211hdr.h | ||
p80211ioctl.h | ||
p80211metadef.h | ||
p80211metastruct.h | ||
p80211mgmt.h | ||
p80211msg.h | ||
p80211netdev.c | ||
p80211netdev.h | ||
p80211req.c | ||
p80211req.h | ||
p80211types.h | ||
p80211wep.c | ||
prism2fw.c | ||
prism2mgmt.c | ||
prism2mgmt.h | ||
prism2mib.c | ||
prism2sta.c | ||
prism2usb.c | ||
README |
TODO: - checkpatch.pl cleanups - sparse warnings - move to use the in-kernel wireless stack Please send any patches or complaints about this driver to Greg Kroah-Hartman <greg@kroah.com> and don't bother the upstream wireless kernel developers about it, they want nothing to do with it.