forked from Minki/linux
cf9d052aa6
In Linux, if a driver does disable_irq() and later does enable_irq() on its interrupt, I believe it's expecting these properties: * If an interrupt was pending when the driver disabled then it will still be pending after the driver re-enables. * If an edge-triggered interrupt comes in while an interrupt is disabled it should assert when the interrupt is re-enabled. If you think that the above sounds a lot like the disable_irq() and enable_irq() are supposed to be masking/unmasking the interrupt instead of disabling/enabling it then you've made an astute observation. Specifically when talking about interrupts, "mask" usually means to stop posting interrupts but keep tracking them and "disable" means to fully shut off interrupt detection. It's unfortunate that this is so confusing, but presumably this is all the way it is for historical reasons. Perhaps more confusing than the above is that, even though clients of IRQs themselves don't have a way to request mask/unmask vs. disable/enable calls, IRQ chips themselves can implement both. ...and yet more confusing is that if an IRQ chip implements disable/enable then they will be called when a client driver calls disable_irq() / enable_irq(). It does feel like some of the above could be cleared up. However, without any other core interrupt changes it should be clear that when an IRQ chip gets a request to "disable" an IRQ that it has to treat it like a mask of that IRQ. In any case, after that long interlude you can see that the "unmask and clear" can break things. Maulik tried to fix it so that we no longer did "unmask and clear" in commit |
||
---|---|---|
.. | ||
Kconfig | ||
Makefile | ||
pinctrl-apq8064.c | ||
pinctrl-apq8084.c | ||
pinctrl-ipq4019.c | ||
pinctrl-ipq6018.c | ||
pinctrl-ipq8064.c | ||
pinctrl-ipq8074.c | ||
pinctrl-lpass-lpi.c | ||
pinctrl-mdm9615.c | ||
pinctrl-msm8x74.c | ||
pinctrl-msm8226.c | ||
pinctrl-msm8660.c | ||
pinctrl-msm8916.c | ||
pinctrl-msm8953.c | ||
pinctrl-msm8960.c | ||
pinctrl-msm8976.c | ||
pinctrl-msm8994.c | ||
pinctrl-msm8996.c | ||
pinctrl-msm8998.c | ||
pinctrl-msm.c | ||
pinctrl-msm.h | ||
pinctrl-qcs404.c | ||
pinctrl-qdf2xxx.c | ||
pinctrl-sc7180.c | ||
pinctrl-sc7280.c | ||
pinctrl-sdm660.c | ||
pinctrl-sdm845.c | ||
pinctrl-sdx55.c | ||
pinctrl-sm8150.c | ||
pinctrl-sm8250.c | ||
pinctrl-spmi-gpio.c | ||
pinctrl-spmi-mpp.c | ||
pinctrl-ssbi-gpio.c | ||
pinctrl-ssbi-mpp.c |