Shradha Todi 6613bc2301 PCI: endpoint: Fix NULL pointer dereference for ->get_features() ... get_features ops of pci_epc_ops may return NULL, causing NULL pointer dereference in pci_epf_test_alloc_space function. Let us add a check for pci_epc_feature pointer in pci_epf_test_bind before we access it to avoid any such NULL pointer dereference and return -ENOTSUPP in case pci_epc_feature is not found. When the patch is not applied and EPC features is not implemented in the platform driver, we see the following dump due to kernel NULL pointer dereference. Call trace: pci_epf_test_bind+0xf4/0x388 pci_epf_bind+0x3c/0x80 pci_epc_epf_link+0xa8/0xcc configfs_symlink+0x1a4/0x48c vfs_symlink+0x104/0x184 do_symlinkat+0x80/0xd4 __arm64_sys_symlinkat+0x1c/0x24 el0_svc_common.constprop.3+0xb8/0x170 el0_svc_handler+0x70/0x88 el0_svc+0x8/0x640 Code: d2800581 b9403ab9 f9404ebb 8b394f60 (f9400400) ---[ end trace a438e3c5a24f9df0 ]--- Link: https://lore.kernel.org/r/20210324101609.79278-1-shradha.t@samsung.com Fixes: 2c04c5b8ee ("PCI: pci-epf-test: Use pci_epc_get_features() to get EPC features") Signed-off-by: Sriram Dash <dash.sriram@gmail.com> Signed-off-by: Shradha Todi <shradha.t@samsung.com> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>		2021-03-26 15:21:53 +00:00
..
functions	PCI: endpoint: Fix NULL pointer dereference for ->get_features()	2021-03-26 15:21:53 +00:00
Kconfig	PCI: consolidate PCI config entry in drivers/pci	2018-11-23 11:45:34 +09:00
Makefile	PCI: Add SPDX GPL-2.0 when no license was specified	2018-01-26 11:45:16 -06:00
pci-ep-cfs.c	PCI: endpoint: Allow user to create sub-directory of 'EPF Device' directory	2021-02-23 14:12:01 -06:00
pci-epc-core.c	PCI: endpoint: Add pci_epc_ops to map MSI IRQ	2021-02-23 14:11:13 -06:00
pci-epc-mem.c	PCI: Fix kerneldoc warnings	2020-08-05 18:23:14 -05:00
pci-epf-core.c	PCI: endpoint: Add pci_epf_ops to expose function-specific attrs	2021-02-23 14:11:31 -06:00