6473bbfd7e
Using regmap_update_bits(..., mask, 1) with 'mask' following (1 << k) and k greater than 0 is wrong. Indeed, _regmap_update_bits will perform (mask & 1), which results in 0 if LSB of mask is 0. Thus the call regmap_update_bits(..., mask, 1) is in reality equivalent to regmap_update_bits(..., mask, 0). In such a case, the correct use is regmap_update_bits(..., mask, mask). This driver is performing such a mistake with the DRV2667_STANDBY mask, which equals (1 << 6). Fix the driver to make it consistent with the API, and fix the alignment problem at the same time. Please note that this change is untested, as I do not have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> |
||
|---|---|---|
| .. | ||
| 88pm80x_onkey.c | ||
| 88pm860x_onkey.c | ||
| ab8500-ponkey.c | ||
| ad714x-i2c.c | ||
| ad714x-spi.c | ||
| ad714x.c | ||
| ad714x.h | ||
| adxl34x-i2c.c | ||
| adxl34x-spi.c | ||
| adxl34x.c | ||
| adxl34x.h | ||
| apanel.c | ||
| arizona-haptics.c | ||
| ati_remote2.c | ||
| atlas_btns.c | ||
| atmel_captouch.c | ||
| axp20x-pek.c | ||
| bfin_rotary.c | ||
| bma150.c | ||
| cm109.c | ||
| cma3000_d0x_i2c.c | ||
| cma3000_d0x.c | ||
| cma3000_d0x.h | ||
| cobalt_btns.c | ||
| da9052_onkey.c | ||
| da9055_onkey.c | ||
| da9063_onkey.c | ||
| dm355evm_keys.c | ||
| drv260x.c | ||
| drv2665.c | ||
| drv2667.c | ||
| e3x0-button.c | ||
| gp2ap002a00f.c | ||
| gpio_decoder.c | ||
| gpio_tilt_polled.c | ||
| gpio-beeper.c | ||
| hisi_powerkey.c | ||
| hp_sdc_rtc.c | ||
| ideapad_slidebar.c | ||
| ims-pcu.c | ||
| ixp4xx-beeper.c | ||
| Kconfig | ||
| keyspan_remote.c | ||
| kxtj9.c | ||
| m68kspkr.c | ||
| Makefile | ||
| max8925_onkey.c | ||
| max8997_haptic.c | ||
| max77693-haptic.c | ||
| mc13783-pwrbutton.c | ||
| mma8450.c | ||
| mpu3050.c | ||
| palmas-pwrbutton.c | ||
| pcap_keys.c | ||
| pcf8574_keypad.c | ||
| pcf50633-input.c | ||
| pcspkr.c | ||
| pm8xxx-vibrator.c | ||
| pm8941-pwrkey.c | ||
| pmic8xxx-pwrkey.c | ||
| powermate.c | ||
| pwm-beeper.c | ||
| rb532_button.c | ||
| regulator-haptic.c | ||
| retu-pwrbutton.c | ||
| rotary_encoder.c | ||
| sgi_btns.c | ||
| sirfsoc-onkey.c | ||
| soc_button_array.c | ||
| sparcspkr.c | ||
| tps65218-pwrbutton.c | ||
| twl4030-pwrbutton.c | ||
| twl4030-vibra.c | ||
| twl6040-vibra.c | ||
| uinput.c | ||
| wistron_btns.c | ||
| wm831x-on.c | ||
| xen-kbdfront.c | ||
| yealink.c | ||
| yealink.h | ||