linux/drivers/leds/trigger/ledtrig-pattern.c
Baolin Wang 3a40cfe8ba leds: trigger: Fix sleeping function called from invalid context
We will meet below issue due to mutex_lock() is called in interrupt context.
The mutex lock is used to protect the pattern trigger data, but before changing
new pattern trigger data (pattern values or repeat value) by users, we always
cancel the timer firstly to clear previous patterns' performance. That means
there is no race in pattern_trig_timer_function(), so we can drop the mutex
lock in pattern_trig_timer_function() to avoid this issue.

Moreover we can move the timer cancelling into mutex protection, since there
is no deadlock risk if we remove the mutex lock in pattern_trig_timer_function().

BUG: sleeping function called from invalid context at kernel/locking/mutex.c:254
in_atomic(): 1, irqs_disabled(): 0, pid: 0, name: swapper/1
CPU: 1 PID: 0 Comm: swapper/1 Not tainted
4.20.0-rc1-koelsch-00841-ga338c8181013c1a9 #171
Hardware name: Generic R-Car Gen2 (Flattened Device Tree)
[<c020f19c>] (unwind_backtrace) from [<c020aecc>] (show_stack+0x10/0x14)
[<c020aecc>] (show_stack) from [<c07affb8>] (dump_stack+0x7c/0x9c)
[<c07affb8>] (dump_stack) from [<c02417d4>] (___might_sleep+0xf4/0x158)
[<c02417d4>] (___might_sleep) from [<c07c92c4>] (mutex_lock+0x18/0x60)
[<c07c92c4>] (mutex_lock) from [<c067b28c>] (pattern_trig_timer_function+0x1c/0x11c)
[<c067b28c>] (pattern_trig_timer_function) from [<c027f6fc>] (call_timer_fn+0x1c/0x90)
[<c027f6fc>] (call_timer_fn) from [<c027f944>] (expire_timers+0x94/0xa4)
[<c027f944>] (expire_timers) from [<c027fc98>] (run_timer_softirq+0x108/0x15c)
[<c027fc98>] (run_timer_softirq) from [<c02021cc>] (__do_softirq+0x1d4/0x258)
[<c02021cc>] (__do_softirq) from [<c0224d24>] (irq_exit+0x64/0xc4)
[<c0224d24>] (irq_exit) from [<c0268dd0>] (__handle_domain_irq+0x80/0xb4)
[<c0268dd0>] (__handle_domain_irq) from [<c045e1b0>] (gic_handle_irq+0x58/0x90)
[<c045e1b0>] (gic_handle_irq) from [<c02019f8>] (__irq_svc+0x58/0x74)
Exception stack(0xeb483f60 to 0xeb483fa8)
3f60: 00000000 00000000 eb9afaa0 c0217e80 00000000 ffffe000 00000000 c0e06408
3f80: 00000002 c0e0647c c0c6a5f0 00000000 c0e04900 eb483fb0 c0207ea8 c0207e98
3fa0: 60020013 ffffffff
[<c02019f8>] (__irq_svc) from [<c0207e98>] (arch_cpu_idle+0x1c/0x38)
[<c0207e98>] (arch_cpu_idle) from [<c0247ca8>] (do_idle+0x138/0x268)
[<c0247ca8>] (do_idle) from [<c0248050>] (cpu_startup_entry+0x18/0x1c)
[<c0248050>] (cpu_startup_entry) from [<402022ec>] (0x402022ec)

Fixes: 5fd752b6b3 ("leds: core: Introduce LED pattern trigger")
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
2018-11-07 21:43:25 +01:00

401 lines
9.5 KiB
C

// SPDX-License-Identifier: GPL-2.0
/*
* LED pattern trigger
*
* Idea discussed with Pavel Machek. Raphael Teysseyre implemented
* the first version, Baolin Wang simplified and improved the approach.
*/
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/slab.h>
#include <linux/timer.h>
#define MAX_PATTERNS 1024
/*
* When doing gradual dimming, the led brightness will be updated
* every 50 milliseconds.
*/
#define UPDATE_INTERVAL 50
struct pattern_trig_data {
struct led_classdev *led_cdev;
struct led_pattern patterns[MAX_PATTERNS];
struct led_pattern *curr;
struct led_pattern *next;
struct mutex lock;
u32 npatterns;
int repeat;
int last_repeat;
int delta_t;
bool is_indefinite;
bool is_hw_pattern;
struct timer_list timer;
};
static void pattern_trig_update_patterns(struct pattern_trig_data *data)
{
data->curr = data->next;
if (!data->is_indefinite && data->curr == data->patterns)
data->repeat--;
if (data->next == data->patterns + data->npatterns - 1)
data->next = data->patterns;
else
data->next++;
data->delta_t = 0;
}
static int pattern_trig_compute_brightness(struct pattern_trig_data *data)
{
int step_brightness;
/*
* If current tuple's duration is less than the dimming interval,
* we should treat it as a step change of brightness instead of
* doing gradual dimming.
*/
if (data->delta_t == 0 || data->curr->delta_t < UPDATE_INTERVAL)
return data->curr->brightness;
step_brightness = abs(data->next->brightness - data->curr->brightness);
step_brightness = data->delta_t * step_brightness / data->curr->delta_t;
if (data->next->brightness > data->curr->brightness)
return data->curr->brightness + step_brightness;
else
return data->curr->brightness - step_brightness;
}
static void pattern_trig_timer_function(struct timer_list *t)
{
struct pattern_trig_data *data = from_timer(data, t, timer);
for (;;) {
if (!data->is_indefinite && !data->repeat)
break;
if (data->curr->brightness == data->next->brightness) {
/* Step change of brightness */
led_set_brightness(data->led_cdev,
data->curr->brightness);
mod_timer(&data->timer,
jiffies + msecs_to_jiffies(data->curr->delta_t));
if (!data->next->delta_t) {
/* Skip the tuple with zero duration */
pattern_trig_update_patterns(data);
}
/* Select next tuple */
pattern_trig_update_patterns(data);
} else {
/* Gradual dimming */
/*
* If the accumulation time is larger than current
* tuple's duration, we should go next one and re-check
* if we repeated done.
*/
if (data->delta_t > data->curr->delta_t) {
pattern_trig_update_patterns(data);
continue;
}
led_set_brightness(data->led_cdev,
pattern_trig_compute_brightness(data));
mod_timer(&data->timer,
jiffies + msecs_to_jiffies(UPDATE_INTERVAL));
/* Accumulate the gradual dimming time */
data->delta_t += UPDATE_INTERVAL;
}
break;
}
}
static int pattern_trig_start_pattern(struct led_classdev *led_cdev)
{
struct pattern_trig_data *data = led_cdev->trigger_data;
if (!data->npatterns)
return 0;
if (data->is_hw_pattern) {
return led_cdev->pattern_set(led_cdev, data->patterns,
data->npatterns, data->repeat);
}
/* At least 2 tuples for software pattern. */
if (data->npatterns < 2)
return -EINVAL;
data->delta_t = 0;
data->curr = data->patterns;
data->next = data->patterns + 1;
data->timer.expires = jiffies;
add_timer(&data->timer);
return 0;
}
static ssize_t repeat_show(struct device *dev, struct device_attribute *attr,
char *buf)
{
struct led_classdev *led_cdev = dev_get_drvdata(dev);
struct pattern_trig_data *data = led_cdev->trigger_data;
int repeat;
mutex_lock(&data->lock);
repeat = data->last_repeat;
mutex_unlock(&data->lock);
return scnprintf(buf, PAGE_SIZE, "%d\n", repeat);
}
static ssize_t repeat_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
struct led_classdev *led_cdev = dev_get_drvdata(dev);
struct pattern_trig_data *data = led_cdev->trigger_data;
int err, res;
err = kstrtos32(buf, 10, &res);
if (err)
return err;
/* Number 0 and negative numbers except -1 are invalid. */
if (res < -1 || res == 0)
return -EINVAL;
mutex_lock(&data->lock);
del_timer_sync(&data->timer);
if (data->is_hw_pattern)
led_cdev->pattern_clear(led_cdev);
data->last_repeat = data->repeat = res;
/* -1 means repeat indefinitely */
if (data->repeat == -1)
data->is_indefinite = true;
else
data->is_indefinite = false;
err = pattern_trig_start_pattern(led_cdev);
mutex_unlock(&data->lock);
return err < 0 ? err : count;
}
static DEVICE_ATTR_RW(repeat);
static ssize_t pattern_trig_show_patterns(struct pattern_trig_data *data,
char *buf, bool hw_pattern)
{
ssize_t count = 0;
int i;
mutex_lock(&data->lock);
if (!data->npatterns || (data->is_hw_pattern ^ hw_pattern))
goto out;
for (i = 0; i < data->npatterns; i++) {
count += scnprintf(buf + count, PAGE_SIZE - count,
"%d %u ",
data->patterns[i].brightness,
data->patterns[i].delta_t);
}
buf[count - 1] = '\n';
out:
mutex_unlock(&data->lock);
return count;
}
static ssize_t pattern_trig_store_patterns(struct led_classdev *led_cdev,
const char *buf, size_t count,
bool hw_pattern)
{
struct pattern_trig_data *data = led_cdev->trigger_data;
int ccount, cr, offset = 0, err = 0;
mutex_lock(&data->lock);
del_timer_sync(&data->timer);
if (data->is_hw_pattern)
led_cdev->pattern_clear(led_cdev);
data->is_hw_pattern = hw_pattern;
data->npatterns = 0;
while (offset < count - 1 && data->npatterns < MAX_PATTERNS) {
cr = 0;
ccount = sscanf(buf + offset, "%d %u %n",
&data->patterns[data->npatterns].brightness,
&data->patterns[data->npatterns].delta_t, &cr);
if (ccount != 2) {
data->npatterns = 0;
err = -EINVAL;
goto out;
}
offset += cr;
data->npatterns++;
}
err = pattern_trig_start_pattern(led_cdev);
if (err)
data->npatterns = 0;
out:
mutex_unlock(&data->lock);
return err < 0 ? err : count;
}
static ssize_t pattern_show(struct device *dev, struct device_attribute *attr,
char *buf)
{
struct led_classdev *led_cdev = dev_get_drvdata(dev);
struct pattern_trig_data *data = led_cdev->trigger_data;
return pattern_trig_show_patterns(data, buf, false);
}
static ssize_t pattern_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
struct led_classdev *led_cdev = dev_get_drvdata(dev);
return pattern_trig_store_patterns(led_cdev, buf, count, false);
}
static DEVICE_ATTR_RW(pattern);
static ssize_t hw_pattern_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct led_classdev *led_cdev = dev_get_drvdata(dev);
struct pattern_trig_data *data = led_cdev->trigger_data;
return pattern_trig_show_patterns(data, buf, true);
}
static ssize_t hw_pattern_store(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
{
struct led_classdev *led_cdev = dev_get_drvdata(dev);
return pattern_trig_store_patterns(led_cdev, buf, count, true);
}
static DEVICE_ATTR_RW(hw_pattern);
static umode_t pattern_trig_attrs_mode(struct kobject *kobj,
struct attribute *attr, int index)
{
struct device *dev = container_of(kobj, struct device, kobj);
struct led_classdev *led_cdev = dev_get_drvdata(dev);
if (attr == &dev_attr_repeat.attr || attr == &dev_attr_pattern.attr)
return attr->mode;
else if (attr == &dev_attr_hw_pattern.attr && led_cdev->pattern_set)
return attr->mode;
return 0;
}
static struct attribute *pattern_trig_attrs[] = {
&dev_attr_pattern.attr,
&dev_attr_hw_pattern.attr,
&dev_attr_repeat.attr,
NULL
};
static const struct attribute_group pattern_trig_group = {
.attrs = pattern_trig_attrs,
.is_visible = pattern_trig_attrs_mode,
};
static const struct attribute_group *pattern_trig_groups[] = {
&pattern_trig_group,
NULL,
};
static int pattern_trig_activate(struct led_classdev *led_cdev)
{
struct pattern_trig_data *data;
data = kzalloc(sizeof(*data), GFP_KERNEL);
if (!data)
return -ENOMEM;
if (!!led_cdev->pattern_set ^ !!led_cdev->pattern_clear) {
dev_warn(led_cdev->dev,
"Hardware pattern ops validation failed\n");
led_cdev->pattern_set = NULL;
led_cdev->pattern_clear = NULL;
}
data->is_indefinite = true;
data->last_repeat = -1;
mutex_init(&data->lock);
data->led_cdev = led_cdev;
led_set_trigger_data(led_cdev, data);
timer_setup(&data->timer, pattern_trig_timer_function, 0);
led_cdev->activated = true;
return 0;
}
static void pattern_trig_deactivate(struct led_classdev *led_cdev)
{
struct pattern_trig_data *data = led_cdev->trigger_data;
if (!led_cdev->activated)
return;
if (led_cdev->pattern_clear)
led_cdev->pattern_clear(led_cdev);
del_timer_sync(&data->timer);
led_set_brightness(led_cdev, LED_OFF);
kfree(data);
led_cdev->activated = false;
}
static struct led_trigger pattern_led_trigger = {
.name = "pattern",
.activate = pattern_trig_activate,
.deactivate = pattern_trig_deactivate,
.groups = pattern_trig_groups,
};
static int __init pattern_trig_init(void)
{
return led_trigger_register(&pattern_led_trigger);
}
static void __exit pattern_trig_exit(void)
{
led_trigger_unregister(&pattern_led_trigger);
}
module_init(pattern_trig_init);
module_exit(pattern_trig_exit);
MODULE_AUTHOR("Raphael Teysseyre <rteysseyre@gmail.com");
MODULE_AUTHOR("Baolin Wang <baolin.wang@linaro.org");
MODULE_DESCRIPTION("LED Pattern trigger");
MODULE_LICENSE("GPL v2");