5f94e35714
The AFBC decoder used in the Rockchip VOP assumes the use of the
YUV-like colourspace transform (YTR). YTR is lossless for RGB(A)
buffers, which covers the RGBA8 and RGB565 formats supported in
vop_convert_afbc_format. Use of YTR is signaled with the
AFBC_FORMAT_MOD_YTR modifier, which prior to this commit was missing. As
such, a producer would have to generate buffers that do not use YTR,
which the VOP would erroneously decode as YTR, leading to severe visual
corruption.
The upstream AFBC support was developed against a captured frame, which
failed to exercise modifier support. Prior to bring-up of AFBC in Mesa
(in the Panfrost driver), no open userspace respected modifier
reporting. As such, this change is not expected to affect broken
userspaces.
Tested on RK3399 with Panfrost and Weston.
Fixes:
|
||
|---|---|---|
| .. | ||
| analogix_dp-rockchip.c | ||
| cdn-dp-core.c | ||
| cdn-dp-core.h | ||
| cdn-dp-reg.c | ||
| cdn-dp-reg.h | ||
| dw_hdmi-rockchip.c | ||
| dw-mipi-dsi-rockchip.c | ||
| inno_hdmi.c | ||
| inno_hdmi.h | ||
| Kconfig | ||
| Makefile | ||
| rk3066_hdmi.c | ||
| rk3066_hdmi.h | ||
| rockchip_drm_drv.c | ||
| rockchip_drm_drv.h | ||
| rockchip_drm_fb.c | ||
| rockchip_drm_fb.h | ||
| rockchip_drm_fbdev.c | ||
| rockchip_drm_fbdev.h | ||
| rockchip_drm_gem.c | ||
| rockchip_drm_gem.h | ||
| rockchip_drm_vop.c | ||
| rockchip_drm_vop.h | ||
| rockchip_lvds.c | ||
| rockchip_lvds.h | ||
| rockchip_rgb.c | ||
| rockchip_rgb.h | ||
| rockchip_vop_reg.c | ||
| rockchip_vop_reg.h | ||