linux

History

Herbert Xu f398035f2d [IPSEC]: Avoid undefined shift operation when testing algorithm ID The aalgos/ealgos fields are only 32 bits wide. However, af_key tries to test them with the expression 1 << id where id can be as large as 253. This produces different behaviour on different architectures. The following patch explicitly checks whether ID is greater than 31 and fails the check if that's the case. We cannot easily extend the mask to be longer than 32 bits due to exposure to user-space. Besides, this whole interface is obsolete anyway in favour of the xfrm_user interface which doesn't use this bit mask in templates (well not within the kernel anyway). Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>	2007-12-19 23:44:29 -08:00
..
af_key.c	[IPSEC]: Avoid undefined shift operation when testing algorithm ID	2007-12-19 23:44:29 -08:00
Makefile	Linux-2.6.12-rc2	2005-04-16 15:20:36 -07:00

Herbert Xu f398035f2d [IPSEC]: Avoid undefined shift operation when testing algorithm ID

The aalgos/ealgos fields are only 32 bits wide.  However, af_key tries
to test them with the expression 1 << id where id can be as large as
253.  This produces different behaviour on different architectures.

The following patch explicitly checks whether ID is greater than 31
and fails the check if that's the case.

We cannot easily extend the mask to be longer than 32 bits due to
exposure to user-space.  Besides, this whole interface is obsolete
anyway in favour of the xfrm_user interface which doesn't use this
bit mask in templates (well not within the kernel anyway).

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

2007-12-19 23:44:29 -08:00

af_key.c

[IPSEC]: Avoid undefined shift operation when testing algorithm ID

2007-12-19 23:44:29 -08:00

Makefile

Linux-2.6.12-rc2

2005-04-16 15:20:36 -07:00