Subash Abhinov Kasiviswanathan 5c346525d3 net: qualcomm: rmnet: Fix rcu splat in rmnet_is_real_dev_registered ... Xiaolong reported a suspicious rcu_dereference_check in the device unregister notifier callback. Since we do not dereference the rx_handler_data, it's ok to just check for the value of the pointer. Note that this section is already protected by rtnl_lock. [ 101.364846] WARNING: suspicious RCU usage [ 101.365654] 4.13.0-rc6-01701-gceed73a #1 Not tainted [ 101.370873] ----------------------------- [ 101.372472] drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c:57 suspicious rcu_dereference_check() usage! [ 101.374427] [ 101.374427] other info that might help us debug this: [ 101.374427] [ 101.387491] [ 101.387491] rcu_scheduler_active = 2, debug_locks = 1 [ 101.389368] 1 lock held by trinity-main/2809: [ 101.390736] #0: (rtnl_mutex){+.+.+.}, at: [<8146085b>] rtnl_lock+0xf/0x11 [ 101.395482] [ 101.395482] stack backtrace: [ 101.396948] CPU: 0 PID: 2809 Comm: trinity-main Not tainted 4.13.0-rc6-01701-gceed73a #1 [ 101.398857] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.3-20161025_171302-gandalf 04/01/2014 [ 101.401079] Call Trace: [ 101.401656] dump_stack+0xa1/0xeb [ 101.402871] lockdep_rcu_suspicious+0xc7/0xd0 [ 101.403665] rmnet_is_real_dev_registered+0x40/0x4e [ 101.405199] rmnet_config_notify_cb+0x2c/0x142 [ 101.406344] ? wireless_nlevent_flush+0x47/0x71 [ 101.407385] notifier_call_chain+0x2d/0x47 [ 101.408645] raw_notifier_call_chain+0xc/0xe [ 101.409882] call_netdevice_notifiers_info+0x41/0x49 [ 101.411402] call_netdevice_notifiers+0xc/0xe [ 101.412713] rollback_registered_many+0x268/0x36e [ 101.413702] rollback_registered+0x39/0x56 [ 101.414965] unregister_netdevice_queue+0x79/0x88 [ 101.415908] unregister_netdev+0x16/0x1d Fixes: ceed73a2cf ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation") Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org> Reported-by: kernel test robot <xiaolong.ye@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-09-23 19:59:53 -07:00
..
appletalk
arcnet
bonding	net: bonding: fix tlb_dynamic_lb default value	2017-09-12 20:58:12 -07:00
caif
can	can: constify platform_device_id	2017-08-13 20:12:23 -07:00
cris
dsa	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-05 20:03:35 -07:00
ethernet	net: qualcomm: rmnet: Fix rcu splat in rmnet_is_real_dev_registered	2017-09-23 19:59:53 -07:00
fddi	net: defxx: constify eisa_device_id	2017-08-19 17:13:41 -07:00
fjes
hamradio
hippi
hyperv	hv_netvsc: fix send buffer failure on MTU change	2017-09-21 15:17:16 -07:00
ieee802154	ieee802154: ca8210: Fix a potential NULL pointer dereference	2017-08-20 20:51:30 +02:00
ipvlan	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2017-09-03 17:08:42 -07:00
phy	net: phy: Fix truncation of large IRQ numbers in phy_attached_print()	2017-09-21 20:35:17 -07:00
plip
ppp	ppp: fix xmit recursion detection on ppp channels	2017-08-08 21:06:11 -07:00
slip
team
usb	lan78xx: Use default values loaded from EEPROM/OTP after reset	2017-09-21 15:22:53 -07:00
vmxnet3
wan	- For the randstruct plugin, enable automatic randomization of structures	2017-09-07 20:30:19 -07:00
wimax
wireless	wireless-drivers fixes for 4.14	2017-09-08 10:09:57 -07:00
xen-netback	xen-netback: update ubuf_info initialization to anonymous union	2017-08-28 15:11:50 -07:00
dummy.c
eql.c
geneve.c	geneve: use netlink_ext_ack for error reporting in rtnl operations	2017-08-11 13:45:02 -07:00
gtp.c
ifb.c
Kconfig	x86/lguest: Remove lguest support	2017-08-24 09:57:28 +02:00
LICENSE.SRC
loopback.c
macsec.c	macsec: add genl family module alias	2017-08-22 14:25:50 -07:00
macvlan.c	macvlan: add offload features for encapsulation	2017-08-18 16:06:54 -07:00
macvtap.c
Makefile	irda: move drivers/net/irda to drivers/staging/irda/drivers	2017-08-28 16:42:57 -07:00
mdio.c
mii.c
netconsole.c
nlmon.c
ntb_netdev.c
rionet.c
sb1000.c
Space.c
sungem_phy.c
tap.c	tun/tap: use paren's with sizeof	2017-08-16 11:01:57 -07:00
tun.c	tun: rename generic_xdp to skb_xdp	2017-09-05 14:26:41 -07:00
veth.c
virtio_net.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-01 17:42:05 -07:00
vrf.c	net: vrf: avoid gcc-4.6 warning	2017-09-15 14:22:21 -07:00
vsockmon.c
vxlan.c	vxlan: factor out VXLAN-GPE next protocol	2017-08-29 15:16:52 -07:00
xen-netfront.c	xen-netfront: be more drop monitor friendly	2017-08-30 15:56:16 -07:00