linux/arch/arm64
Greg Hackmann 5ad356eabc arm64: mm: check for upper PAGE_SHIFT bits in pfn_valid()
ARM64's pfn_valid() shifts away the upper PAGE_SHIFT bits of the input
before seeing if the PFN is valid.  This leads to false positives when
some of the upper bits are set, but the lower bits match a valid PFN.

For example, the following userspace code looks up a bogus entry in
/proc/kpageflags:

    int pagemap = open("/proc/self/pagemap", O_RDONLY);
    int pageflags = open("/proc/kpageflags", O_RDONLY);
    uint64_t pfn, val;

    lseek64(pagemap, [...], SEEK_SET);
    read(pagemap, &pfn, sizeof(pfn));
    if (pfn & (1UL << 63)) {        /* valid PFN */
        pfn &= ((1UL << 55) - 1);   /* clear flag bits */
        pfn |= (1UL << 55);
        lseek64(pageflags, pfn * sizeof(uint64_t), SEEK_SET);
        read(pageflags, &val, sizeof(val));
    }

On ARM64 this causes the userspace process to crash with SIGSEGV rather
than reading (1 << KPF_NOPAGE).  kpageflags_read() treats the offset as
valid, and stable_page_flags() will try to access an address between the
user and kernel address ranges.

Fixes: c1cc155261 ("arm64: MMU initialisation")
Cc: stable@vger.kernel.org
Signed-off-by: Greg Hackmann <ghackmann@google.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
2018-08-17 10:27:14 +01:00
..
boot ARM64: hisi fixes for 4.18 2018-06-29 14:06:49 -07:00
configs arm64: defconfig: renormalize based on recent additions 2018-06-23 10:24:25 -07:00
crypto crypto: arm64/aes-blk - fix and move skcipher_walk_done out of kernel_neon_begin, _end 2018-06-15 23:06:46 +08:00
include arm64: drop unused kernel_neon_begin_partial() macro 2018-07-31 10:13:50 +01:00
kernel arm64: Avoid calling stop_machine() when patching jump labels 2018-08-17 10:26:44 +01:00
kvm arm64: Add support for STACKLEAK gcc plugin 2018-07-26 11:36:34 +01:00
lib arm64: export tishift functions to modules 2018-05-21 19:00:48 +01:00
mm arm64: mm: check for upper PAGE_SHIFT bits in pfn_valid() 2018-08-17 10:27:14 +01:00
net bpf, arm64: save 4 bytes in prologue when ebpf insns came from cbpf 2018-05-14 19:11:45 -07:00
xen arm64: mm: Add additional parameter to uaccess_ttbr0_disable 2018-01-17 13:57:49 +01:00
Kconfig arm64: Add support for STACKLEAK gcc plugin 2018-07-26 11:36:34 +01:00
Kconfig.debug
Kconfig.platforms arm64: dts: renesas: Add Renesas R8A77990 Kconfig support 2018-05-16 10:44:01 +02:00
Makefile arm64: build with baremetal linker target instead of Linux when available 2018-07-23 15:30:19 +01:00