linux/drivers/scsi/qla2xxx
Martin Wilck 3cf92f4bfc scsi: qla2xxx: cleanup trace buffer initialization
Avoid code duplication between qla2x00_alloc_offload_mem() and
qla2x00_alloc_fw_dump() by moving the FCE and EFT buffer allocation and
initialization to separate functions. Cleanly track failure and success by
making sure that the ha->eft, ha->fce and respective eft_dma, fce_dma
members are set if and only if the buffers are properly allocated and
initialized. Avoid pointless buffer reallocation.  Eliminate some goto
statements. Make sure the fce_enabled flag is cleared when the FCE buffer
is freed.

Fixes: ad0a0b01f0 ("scsi: qla2xxx: Fix Firmware dump size for Extended login and Exchange Offload")
Fixes: a28d9e4ef9 ("scsi: qla2xxx: Add support for multiple fwdump templates/segments")
Cc: Joe Carnuccio <joe.carnuccio@cavium.com>
Cc: Quinn Tran <qutran@marvell.com>
Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2019-08-19 21:51:00 -04:00
..
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
qla_attr.c scsi: qla2xxx: Check the PCI info string output buffer size 2019-08-12 21:34:07 -04:00
qla_bsg.c scsi: qla2xxx: Enable type checking for the SRB free and done callback functions 2019-08-12 21:34:08 -04:00
qla_bsg.h scsi: qla2xxx: Add 28xx flash primary/secondary status/image mechanism 2019-03-19 12:22:55 -04:00
qla_dbg.c scsi: qla2xxx: Declare the fourth ql_dump_buffer() argument const 2019-08-12 21:34:05 -04:00
qla_dbg.h scsi: qla2xxx: Cleanups for NVRAM/Flash read/write path 2019-03-19 12:22:54 -04:00
qla_def.h scsi: qla2xxx: Introduce qla2x00_els_dcmd2_free() 2019-08-12 21:34:09 -04:00
qla_devtbl.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
qla_dfs.c scsi: qla2xxx: Reduce the number of casts in GID list code 2019-08-12 21:34:05 -04:00
qla_dsd.h scsi: qla2xxx: Include the <asm/unaligned.h> header file from qla_dsd.h 2019-08-12 21:34:04 -04:00
qla_fw.h scsi: qla2xxx: Make it explicit that ELS pass-through IOCBs use little endian 2019-08-12 21:34:08 -04:00
qla_gbl.h scsi: qla2xxx: Introduce qla2x00_els_dcmd2_free() 2019-08-12 21:34:09 -04:00
qla_gs.c scsi: qla2xxx: Remove two superfluous if-tests 2019-08-12 21:34:09 -04:00
qla_init.c scsi: qla2xxx: cleanup trace buffer initialization 2019-08-19 21:51:00 -04:00
qla_inline.h scsi: qla2xxx: Introduce the function qla2xxx_init_sp() 2019-08-12 21:34:08 -04:00
qla_iocb.c scsi: qla2xxx: Fix a NULL pointer dereference 2019-08-12 21:39:46 -04:00
qla_isr.c scsi: qla2xxx: Inline the qla2x00_fcport_event_handler() function 2019-08-12 21:34:09 -04:00
qla_mbx.c scsi: qla2xxx: Enable type checking for the SRB free and done callback functions 2019-08-12 21:34:08 -04:00
qla_mid.c scsi: qla2xxx: Enable type checking for the SRB free and done callback functions 2019-08-12 21:34:08 -04:00
qla_mr.c scsi: qla2xxx: Complain if sp->done() is not called from the completion path 2019-08-12 21:34:09 -04:00
qla_mr.h scsi: qla2xxx: Introduce the dsd32 and dsd64 data structures 2019-04-29 17:24:51 -04:00
qla_nvme.c scsi: qla2xxx: Introduce qla2xxx_get_next_handle() 2019-08-12 21:34:08 -04:00
qla_nvme.h scsi: qla2xxx: Modify NVMe include directives 2019-08-12 21:34:08 -04:00
qla_nx2.c scsi: qla2xxx: Suppress a Coveritiy complaint about integer overflow 2019-08-12 21:34:07 -04:00
qla_nx2.h scsi: qla2xxx: Remove unused symbols 2018-02-12 11:43:24 -05:00
qla_nx.c scsi: qla2xxx: Let the compiler check the type of the SCSI command context pointer 2019-08-12 21:34:09 -04:00
qla_nx.h scsi: qla2xxx: Improve Linux kernel coding style conformance 2019-08-12 21:34:04 -04:00
qla_os.c scsi: qla2xxx: cleanup trace buffer initialization 2019-08-19 21:51:00 -04:00
qla_settings.h
qla_sup.c scsi: qla2xxx: Change the return type of qla24xx_read_flash_data() 2019-08-12 21:34:07 -04:00
qla_target.c scsi: qla2xxx: Make sure that aborted commands are freed 2019-08-12 21:34:08 -04:00
qla_target.h scsi: qla2xxx: Introduce the be_id_t and le_id_t data types for FC src/dst IDs 2019-08-12 21:34:07 -04:00
qla_tmpl.c scsi: qla2xxx: Complain if a soft reset fails 2019-08-12 21:34:07 -04:00
qla_tmpl.h scsi: qla2xxx: Correction and improvement to fwdt processing 2019-03-19 12:22:55 -04:00
qla_version.h scsi: qla2xxx: Update driver version to 10.01.00.18-k 2019-08-07 18:08:12 -04:00
tcm_qla2xxx.c scsi: qla2xxx: Make sure that aborted commands are freed 2019-08-12 21:34:08 -04:00
tcm_qla2xxx.h scsi: qla2xxx: deadlock by configfs_depend_item 2018-12-19 21:26:38 -05:00