forked from Minki/linux
7724325a19
The data_mutex is initialized too late, as it is needed for each device driver's power control, causing an OOPS: dvb-usb: found a 'TerraTec/qanu USB2.0 Highspeed DVB-T Receiver' in warm state. BUG: unable to handle kernel NULL pointer dereference at (null) IP: [<ffffffff846617af>] __mutex_lock_slowpath+0x6f/0x100 PGD 0 Oops: 0002 [#1] SMP Modules linked in: dvb_usb_cinergyT2(+) dvb_usb CPU: 0 PID: 2029 Comm: modprobe Not tainted 4.9.0-rc4-dvbmod #24 Hardware name: FUJITSU LIFEBOOK A544/FJNBB35 , BIOS Version 1.17 05/09/2014 task: ffff88020e943840 task.stack: ffff8801f36ec000 RIP: 0010:[<ffffffff846617af>] [<ffffffff846617af>] __mutex_lock_slowpath+0x6f/0x100 RSP: 0018:ffff8801f36efb10 EFLAGS: 00010282 RAX: 0000000000000000 RBX: ffff88021509bdc8 RCX: 00000000c0000100 RDX: 0000000000000001 RSI: 0000000000000000 RDI: ffff88021509bdcc RBP: ffff8801f36efb58 R08: ffff88021f216320 R09: 0000000000100000 R10: ffff88021f216320 R11: 00000023fee6c5a1 R12: ffff88020e943840 R13: ffff88021509bdcc R14: 00000000ffffffff R15: ffff88021509bdd0 FS: 00007f21adb86740(0000) GS:ffff88021f200000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000000 CR3: 0000000215bce000 CR4: 00000000001406f0 Call Trace: mutex_lock+0x16/0x25 cinergyt2_power_ctrl+0x1f/0x60 [dvb_usb_cinergyT2] dvb_usb_device_init+0x21e/0x5d0 [dvb_usb] cinergyt2_usb_probe+0x21/0x50 [dvb_usb_cinergyT2] usb_probe_interface+0xf3/0x2a0 driver_probe_device+0x208/0x2b0 __driver_attach+0x87/0x90 driver_probe_device+0x2b0/0x2b0 bus_for_each_dev+0x52/0x80 bus_add_driver+0x1a3/0x220 driver_register+0x56/0xd0 usb_register_driver+0x77/0x130 do_one_initcall+0x46/0x180 free_vmap_area_noflush+0x38/0x70 kmem_cache_alloc+0x84/0xc0 do_init_module+0x50/0x1be load_module+0x1d8b/0x2100 find_symbol_in_section+0xa0/0xa0 SyS_finit_module+0x89/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 Code: e8 a7 1d 00 00 8b 03 83 f8 01 0f 84 97 00 00 00 48 8b 43 10 4c 8d 7b 08 48 89 63 10 4c 89 3c 24 41 be ff ff ff ff 48 89 44 24 08 <48> 89 20 4c 89 64 24 10 eb 1a 49 c7 44 24 08 02 00 00 00 c6 43 RIP [<ffffffff846617af>] __mutex_lock_slowpath+0x6f/0x100 RSP <ffff8801f36efb10> CR2: 0000000000000000 So, move it to the struct dvb_usb_device and initialize it before calling the driver's callbacks. Reported-by: Jörg Otte <jrg.otte@gmail.com> Tested-by: Jörg Otte <jrg.otte@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
422 lines
10 KiB
C
422 lines
10 KiB
C
/* DVB USB library compliant Linux driver for the WideView/ Yakumo/ Hama/
|
|
* Typhoon/ Yuan/ Miglia DVB-T USB2.0 receiver.
|
|
*
|
|
* Copyright (C) 2004-5 Patrick Boettcher (patrick.boettcher@posteo.de)
|
|
*
|
|
* Thanks to Steve Chang from WideView for providing support for the WT-220U.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the Free
|
|
* Software Foundation, version 2.
|
|
*
|
|
* see Documentation/dvb/README.dvb-usb for more information
|
|
*/
|
|
#include "dtt200u.h"
|
|
|
|
/* debug */
|
|
int dvb_usb_dtt200u_debug;
|
|
module_param_named(debug,dvb_usb_dtt200u_debug, int, 0644);
|
|
MODULE_PARM_DESC(debug, "set debugging level (1=info,xfer=2 (or-able))." DVB_USB_DEBUG_STATUS);
|
|
|
|
DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
|
|
|
|
struct dtt200u_state {
|
|
unsigned char data[80];
|
|
};
|
|
|
|
static int dtt200u_power_ctrl(struct dvb_usb_device *d, int onoff)
|
|
{
|
|
struct dtt200u_state *st = d->priv;
|
|
int ret = 0;
|
|
|
|
mutex_lock(&d->data_mutex);
|
|
|
|
st->data[0] = SET_INIT;
|
|
|
|
if (onoff)
|
|
ret = dvb_usb_generic_write(d, st->data, 2);
|
|
|
|
mutex_unlock(&d->data_mutex);
|
|
return ret;
|
|
}
|
|
|
|
static int dtt200u_streaming_ctrl(struct dvb_usb_adapter *adap, int onoff)
|
|
{
|
|
struct dvb_usb_device *d = adap->dev;
|
|
struct dtt200u_state *st = d->priv;
|
|
int ret;
|
|
|
|
mutex_lock(&d->data_mutex);
|
|
st->data[0] = SET_STREAMING;
|
|
st->data[1] = onoff;
|
|
|
|
ret = dvb_usb_generic_write(adap->dev, st->data, 2);
|
|
if (ret < 0)
|
|
goto ret;
|
|
|
|
if (onoff)
|
|
goto ret;
|
|
|
|
st->data[0] = RESET_PID_FILTER;
|
|
ret = dvb_usb_generic_write(adap->dev, st->data, 1);
|
|
|
|
ret:
|
|
mutex_unlock(&d->data_mutex);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int dtt200u_pid_filter(struct dvb_usb_adapter *adap, int index, u16 pid, int onoff)
|
|
{
|
|
struct dvb_usb_device *d = adap->dev;
|
|
struct dtt200u_state *st = d->priv;
|
|
int ret;
|
|
|
|
pid = onoff ? pid : 0;
|
|
|
|
mutex_lock(&d->data_mutex);
|
|
st->data[0] = SET_PID_FILTER;
|
|
st->data[1] = index;
|
|
st->data[2] = pid & 0xff;
|
|
st->data[3] = (pid >> 8) & 0x1f;
|
|
|
|
ret = dvb_usb_generic_write(adap->dev, st->data, 4);
|
|
mutex_unlock(&d->data_mutex);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int dtt200u_rc_query(struct dvb_usb_device *d)
|
|
{
|
|
struct dtt200u_state *st = d->priv;
|
|
u32 scancode;
|
|
int ret;
|
|
|
|
mutex_lock(&d->data_mutex);
|
|
st->data[0] = GET_RC_CODE;
|
|
|
|
ret = dvb_usb_generic_rw(d, st->data, 1, st->data, 5, 0);
|
|
if (ret < 0)
|
|
goto ret;
|
|
|
|
if (st->data[0] == 1) {
|
|
enum rc_type proto = RC_TYPE_NEC;
|
|
|
|
scancode = st->data[1];
|
|
if ((u8) ~st->data[1] != st->data[2]) {
|
|
/* Extended NEC */
|
|
scancode = scancode << 8;
|
|
scancode |= st->data[2];
|
|
proto = RC_TYPE_NECX;
|
|
}
|
|
scancode = scancode << 8;
|
|
scancode |= st->data[3];
|
|
|
|
/* Check command checksum is ok */
|
|
if ((u8) ~st->data[3] == st->data[4])
|
|
rc_keydown(d->rc_dev, proto, scancode, 0);
|
|
else
|
|
rc_keyup(d->rc_dev);
|
|
} else if (st->data[0] == 2) {
|
|
rc_repeat(d->rc_dev);
|
|
} else {
|
|
rc_keyup(d->rc_dev);
|
|
}
|
|
|
|
if (st->data[0] != 0)
|
|
deb_info("st->data: %*ph\n", 5, st->data);
|
|
|
|
ret:
|
|
mutex_unlock(&d->data_mutex);
|
|
return ret;
|
|
}
|
|
|
|
static int dtt200u_frontend_attach(struct dvb_usb_adapter *adap)
|
|
{
|
|
adap->fe_adap[0].fe = dtt200u_fe_attach(adap->dev);
|
|
return 0;
|
|
}
|
|
|
|
static struct dvb_usb_device_properties dtt200u_properties;
|
|
static struct dvb_usb_device_properties wt220u_fc_properties;
|
|
static struct dvb_usb_device_properties wt220u_properties;
|
|
static struct dvb_usb_device_properties wt220u_zl0353_properties;
|
|
static struct dvb_usb_device_properties wt220u_miglia_properties;
|
|
|
|
static int dtt200u_usb_probe(struct usb_interface *intf,
|
|
const struct usb_device_id *id)
|
|
{
|
|
if (0 == dvb_usb_device_init(intf, &dtt200u_properties,
|
|
THIS_MODULE, NULL, adapter_nr) ||
|
|
0 == dvb_usb_device_init(intf, &wt220u_properties,
|
|
THIS_MODULE, NULL, adapter_nr) ||
|
|
0 == dvb_usb_device_init(intf, &wt220u_fc_properties,
|
|
THIS_MODULE, NULL, adapter_nr) ||
|
|
0 == dvb_usb_device_init(intf, &wt220u_zl0353_properties,
|
|
THIS_MODULE, NULL, adapter_nr) ||
|
|
0 == dvb_usb_device_init(intf, &wt220u_miglia_properties,
|
|
THIS_MODULE, NULL, adapter_nr))
|
|
return 0;
|
|
|
|
return -ENODEV;
|
|
}
|
|
|
|
static struct usb_device_id dtt200u_usb_table [] = {
|
|
{ USB_DEVICE(USB_VID_WIDEVIEW, USB_PID_DTT200U_COLD) },
|
|
{ USB_DEVICE(USB_VID_WIDEVIEW, USB_PID_DTT200U_WARM) },
|
|
{ USB_DEVICE(USB_VID_WIDEVIEW, USB_PID_WT220U_COLD) },
|
|
{ USB_DEVICE(USB_VID_WIDEVIEW, USB_PID_WT220U_WARM) },
|
|
{ USB_DEVICE(USB_VID_WIDEVIEW, USB_PID_WT220U_ZL0353_COLD) },
|
|
{ USB_DEVICE(USB_VID_WIDEVIEW, USB_PID_WT220U_ZL0353_WARM) },
|
|
{ USB_DEVICE(USB_VID_WIDEVIEW, USB_PID_WT220U_FC_COLD) },
|
|
{ USB_DEVICE(USB_VID_WIDEVIEW, USB_PID_WT220U_FC_WARM) },
|
|
{ USB_DEVICE(USB_VID_WIDEVIEW, USB_PID_WT220U_ZAP250_COLD) },
|
|
{ USB_DEVICE(USB_VID_MIGLIA, USB_PID_WT220U_ZAP250_COLD) },
|
|
{ 0 },
|
|
};
|
|
MODULE_DEVICE_TABLE(usb, dtt200u_usb_table);
|
|
|
|
static struct dvb_usb_device_properties dtt200u_properties = {
|
|
.usb_ctrl = CYPRESS_FX2,
|
|
.firmware = "dvb-usb-dtt200u-01.fw",
|
|
|
|
.size_of_priv = sizeof(struct dtt200u_state),
|
|
|
|
.num_adapters = 1,
|
|
.adapter = {
|
|
{
|
|
.num_frontends = 1,
|
|
.fe = {{
|
|
.caps = DVB_USB_ADAP_HAS_PID_FILTER | DVB_USB_ADAP_NEED_PID_FILTERING,
|
|
.pid_filter_count = 15,
|
|
|
|
.streaming_ctrl = dtt200u_streaming_ctrl,
|
|
.pid_filter = dtt200u_pid_filter,
|
|
.frontend_attach = dtt200u_frontend_attach,
|
|
/* parameter for the MPEG2-data transfer */
|
|
.stream = {
|
|
.type = USB_BULK,
|
|
.count = 7,
|
|
.endpoint = 0x02,
|
|
.u = {
|
|
.bulk = {
|
|
.buffersize = 4096,
|
|
}
|
|
}
|
|
},
|
|
}},
|
|
}
|
|
},
|
|
.power_ctrl = dtt200u_power_ctrl,
|
|
|
|
.rc.core = {
|
|
.rc_interval = 300,
|
|
.rc_codes = RC_MAP_DTT200U,
|
|
.rc_query = dtt200u_rc_query,
|
|
.allowed_protos = RC_BIT_NEC,
|
|
},
|
|
|
|
.generic_bulk_ctrl_endpoint = 0x01,
|
|
|
|
.num_device_descs = 1,
|
|
.devices = {
|
|
{ .name = "WideView/Yuan/Yakumo/Hama/Typhoon DVB-T USB2.0 (WT-200U)",
|
|
.cold_ids = { &dtt200u_usb_table[0], NULL },
|
|
.warm_ids = { &dtt200u_usb_table[1], NULL },
|
|
},
|
|
{ NULL },
|
|
}
|
|
};
|
|
|
|
static struct dvb_usb_device_properties wt220u_properties = {
|
|
.usb_ctrl = CYPRESS_FX2,
|
|
.firmware = "dvb-usb-wt220u-02.fw",
|
|
|
|
.size_of_priv = sizeof(struct dtt200u_state),
|
|
|
|
.num_adapters = 1,
|
|
.adapter = {
|
|
{
|
|
.num_frontends = 1,
|
|
.fe = {{
|
|
.caps = DVB_USB_ADAP_HAS_PID_FILTER | DVB_USB_ADAP_NEED_PID_FILTERING,
|
|
.pid_filter_count = 15,
|
|
|
|
.streaming_ctrl = dtt200u_streaming_ctrl,
|
|
.pid_filter = dtt200u_pid_filter,
|
|
.frontend_attach = dtt200u_frontend_attach,
|
|
/* parameter for the MPEG2-data transfer */
|
|
.stream = {
|
|
.type = USB_BULK,
|
|
.count = 7,
|
|
.endpoint = 0x02,
|
|
.u = {
|
|
.bulk = {
|
|
.buffersize = 4096,
|
|
}
|
|
}
|
|
},
|
|
}},
|
|
}
|
|
},
|
|
.power_ctrl = dtt200u_power_ctrl,
|
|
|
|
.rc.core = {
|
|
.rc_interval = 300,
|
|
.rc_codes = RC_MAP_DTT200U,
|
|
.rc_query = dtt200u_rc_query,
|
|
.allowed_protos = RC_BIT_NEC,
|
|
},
|
|
|
|
.generic_bulk_ctrl_endpoint = 0x01,
|
|
|
|
.num_device_descs = 1,
|
|
.devices = {
|
|
{ .name = "WideView WT-220U PenType Receiver (Typhoon/Freecom)",
|
|
.cold_ids = { &dtt200u_usb_table[2], &dtt200u_usb_table[8], NULL },
|
|
.warm_ids = { &dtt200u_usb_table[3], NULL },
|
|
},
|
|
{ NULL },
|
|
}
|
|
};
|
|
|
|
static struct dvb_usb_device_properties wt220u_fc_properties = {
|
|
.usb_ctrl = CYPRESS_FX2,
|
|
.firmware = "dvb-usb-wt220u-fc03.fw",
|
|
|
|
.size_of_priv = sizeof(struct dtt200u_state),
|
|
|
|
.num_adapters = 1,
|
|
.adapter = {
|
|
{
|
|
.num_frontends = 1,
|
|
.fe = {{
|
|
.caps = DVB_USB_ADAP_HAS_PID_FILTER | DVB_USB_ADAP_NEED_PID_FILTERING,
|
|
.pid_filter_count = 15,
|
|
|
|
.streaming_ctrl = dtt200u_streaming_ctrl,
|
|
.pid_filter = dtt200u_pid_filter,
|
|
.frontend_attach = dtt200u_frontend_attach,
|
|
/* parameter for the MPEG2-data transfer */
|
|
.stream = {
|
|
.type = USB_BULK,
|
|
.count = 7,
|
|
.endpoint = 0x06,
|
|
.u = {
|
|
.bulk = {
|
|
.buffersize = 4096,
|
|
}
|
|
}
|
|
},
|
|
}},
|
|
}
|
|
},
|
|
.power_ctrl = dtt200u_power_ctrl,
|
|
|
|
.rc.core = {
|
|
.rc_interval = 300,
|
|
.rc_codes = RC_MAP_DTT200U,
|
|
.rc_query = dtt200u_rc_query,
|
|
.allowed_protos = RC_BIT_NEC,
|
|
},
|
|
|
|
.generic_bulk_ctrl_endpoint = 0x01,
|
|
|
|
.num_device_descs = 1,
|
|
.devices = {
|
|
{ .name = "WideView WT-220U PenType Receiver (Typhoon/Freecom)",
|
|
.cold_ids = { &dtt200u_usb_table[6], NULL },
|
|
.warm_ids = { &dtt200u_usb_table[7], NULL },
|
|
},
|
|
{ NULL },
|
|
}
|
|
};
|
|
|
|
static struct dvb_usb_device_properties wt220u_zl0353_properties = {
|
|
.usb_ctrl = CYPRESS_FX2,
|
|
.firmware = "dvb-usb-wt220u-zl0353-01.fw",
|
|
|
|
.size_of_priv = sizeof(struct dtt200u_state),
|
|
|
|
.num_adapters = 1,
|
|
.adapter = {
|
|
{
|
|
.num_frontends = 1,
|
|
.fe = {{
|
|
.caps = DVB_USB_ADAP_HAS_PID_FILTER | DVB_USB_ADAP_NEED_PID_FILTERING,
|
|
.pid_filter_count = 15,
|
|
|
|
.streaming_ctrl = dtt200u_streaming_ctrl,
|
|
.pid_filter = dtt200u_pid_filter,
|
|
.frontend_attach = dtt200u_frontend_attach,
|
|
/* parameter for the MPEG2-data transfer */
|
|
.stream = {
|
|
.type = USB_BULK,
|
|
.count = 7,
|
|
.endpoint = 0x02,
|
|
.u = {
|
|
.bulk = {
|
|
.buffersize = 4096,
|
|
}
|
|
}
|
|
},
|
|
}},
|
|
}
|
|
},
|
|
.power_ctrl = dtt200u_power_ctrl,
|
|
|
|
.rc.core = {
|
|
.rc_interval = 300,
|
|
.rc_codes = RC_MAP_DTT200U,
|
|
.rc_query = dtt200u_rc_query,
|
|
.allowed_protos = RC_BIT_NEC,
|
|
},
|
|
|
|
.generic_bulk_ctrl_endpoint = 0x01,
|
|
|
|
.num_device_descs = 1,
|
|
.devices = {
|
|
{ .name = "WideView WT-220U PenType Receiver (based on ZL353)",
|
|
.cold_ids = { &dtt200u_usb_table[4], NULL },
|
|
.warm_ids = { &dtt200u_usb_table[5], NULL },
|
|
},
|
|
{ NULL },
|
|
}
|
|
};
|
|
|
|
static struct dvb_usb_device_properties wt220u_miglia_properties = {
|
|
.usb_ctrl = CYPRESS_FX2,
|
|
.firmware = "dvb-usb-wt220u-miglia-01.fw",
|
|
|
|
.size_of_priv = sizeof(struct dtt200u_state),
|
|
|
|
.num_adapters = 1,
|
|
.generic_bulk_ctrl_endpoint = 0x01,
|
|
|
|
.num_device_descs = 1,
|
|
.devices = {
|
|
{ .name = "WideView WT-220U PenType Receiver (Miglia)",
|
|
.cold_ids = { &dtt200u_usb_table[9], NULL },
|
|
/* This device turns into WT220U_ZL0353_WARM when fw
|
|
has been uploaded */
|
|
.warm_ids = { NULL },
|
|
},
|
|
{ NULL },
|
|
}
|
|
};
|
|
|
|
/* usb specific object needed to register this driver with the usb subsystem */
|
|
static struct usb_driver dtt200u_usb_driver = {
|
|
.name = "dvb_usb_dtt200u",
|
|
.probe = dtt200u_usb_probe,
|
|
.disconnect = dvb_usb_device_exit,
|
|
.id_table = dtt200u_usb_table,
|
|
};
|
|
|
|
module_usb_driver(dtt200u_usb_driver);
|
|
|
|
MODULE_AUTHOR("Patrick Boettcher <patrick.boettcher@posteo.de>");
|
|
MODULE_DESCRIPTION("Driver for the WideView/Yakumo/Hama/Typhoon/Club3D/Miglia DVB-T USB2.0 devices");
|
|
MODULE_VERSION("1.0");
|
|
MODULE_LICENSE("GPL");
|