Eric Dumazet
560ee196fe
net_sched: fix NULL deref in fifo_set_limit()
syzbot reported another NULL deref in fifo_set_limit() [1]
I could repro the issue with :
unshare -n
tc qd add dev lo root handle 1:0 tbf limit 200000 burst 70000 rate 100Mbit
tc qd replace dev lo parent 1:0 pfifo_fast
tc qd change dev lo root handle 1:0 tbf limit 300000 burst 70000 rate 100Mbit
pfifo_fast does not have a change() operation.
Make fifo_set_limit() more robust about this.
[1]
BUG: kernel NULL pointer dereference, address: 0000000000000000
PGD 1cf99067 P4D 1cf99067 PUD 7ca49067 PMD 0
Oops: 0010 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 14443 Comm: syz-executor959 Not tainted 5.15.0-rc3-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:0x0
Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6.
RSP: 0018:ffffc9000e2f7310 EFLAGS: 00010246
RAX: dffffc0000000000 RBX: ffffffff8d6ecc00 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffff888024c27910 RDI: ffff888071e34000
RBP: ffff888071e34000 R08: 0000000000000001 R09: ffffffff8fcfb947
R10: 0000000000000001 R11: 0000000000000000 R12: ffff888024c27910
R13: ffff888071e34018 R14: 0000000000000000 R15: ffff88801ef74800
FS: 00007f321d897700(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffd6 CR3: 00000000722c3000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
fifo_set_limit net/sched/sch_fifo.c:242 [inline]
fifo_set_limit+0x198/0x210 net/sched/sch_fifo.c:227
tbf_change+0x6ec/0x16d0 net/sched/sch_tbf.c:418
qdisc_change net/sched/sch_api.c:1332 [inline]
tc_modify_qdisc+0xd9a/0x1a60 net/sched/sch_api.c:1634
rtnetlink_rcv_msg+0x413/0xb80 net/core/rtnetlink.c:5572
netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2504
netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline]
netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1340
netlink_sendmsg+0x86d/0xdb0 net/netlink/af_netlink.c:1929
sock_sendmsg_nosec net/socket.c:704 [inline]
sock_sendmsg+0xcf/0x120 net/socket.c:724
____sys_sendmsg+0x6e8/0x810 net/socket.c:2409
___sys_sendmsg+0xf3/0x170 net/socket.c:2463
__sys_sendmsg+0xe5/0x1b0 net/socket.c:2492
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
Fixes: fb0305ce1b ("net-sched: consolidate default fifo qdisc setup")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Link: https://lore.kernel.org/r/20210930212239.3430364-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2021-10-01 14:59:10 -07:00
..
2021-07-22 16:19:03 +02:00
2021-09-05 08:36:44 +09:00
2021-08-13 16:30:35 -07:00
2021-07-27 20:11:45 +01:00
2021-07-23 14:20:25 +01:00
2021-08-03 11:21:39 +01:00
2021-09-03 15:33:47 -07:00
2021-09-01 09:51:16 -07:00
2021-09-28 09:29:28 +02:00
2021-09-28 17:30:36 -07:00
2021-09-14 12:51:15 +01:00
2021-08-05 13:27:50 +01:00
2021-09-30 14:18:40 +01:00
2021-09-08 11:28:35 +01:00
2021-08-05 13:27:50 +01:00
2021-09-21 13:52:16 +01:00
2021-08-03 13:05:26 +01:00
2021-08-24 07:38:29 -07:00
2021-08-13 06:41:22 -07:00
2021-09-28 13:21:16 +01:00
2021-09-28 13:21:16 +01:00
2021-08-09 10:13:32 +01:00
2021-09-09 11:00:20 +01:00
2021-08-05 13:27:50 +01:00
2021-09-27 12:00:34 +02:00
2021-09-07 14:06:08 +01:00
2021-09-08 11:29:16 +01:00
2021-07-23 17:17:56 +01:00
2021-09-30 13:06:47 +01:00
2021-09-01 17:18:56 -07:00
2021-09-21 03:46:56 +02:00
2021-08-30 12:23:18 +01:00
2021-07-30 18:35:47 +02:00
2021-08-05 13:27:50 +01:00
2021-08-13 14:09:19 -07:00
2021-08-19 18:09:18 -07:00
2021-09-10 10:00:59 +01:00
2021-08-05 13:27:50 +01:00
2021-09-02 11:37:02 +01:00
2021-08-18 15:35:50 -07:00
2021-08-18 10:12:11 +01:00
2021-10-01 14:59:10 -07:00
2021-09-24 10:36:19 +01:00
2021-09-21 10:54:16 +01:00
2021-09-08 15:55:42 -07:00
2021-08-04 12:35:07 +01:00
2021-09-13 12:43:10 +01:00
2021-09-30 14:18:40 +01:00
2021-09-06 02:25:16 -04:00
2021-08-26 11:04:55 +02:00
2021-08-27 11:16:29 +01:00
2021-07-29 15:06:49 +01:00
2021-07-29 15:06:49 +01:00
2021-08-31 16:43:06 -07:00