Lv Yunlong 3093ee182f RDMA/siw: Fix a use after free in siw_alloc_mr ... Our code analyzer reported a UAF. In siw_alloc_mr(), it calls siw_mr_add_mem(mr,..). In the implementation of siw_mr_add_mem(), mem is assigned to mr->mem and then mem is freed via kfree(mem) if xa_alloc_cyclic() failed. Here, mr->mem still point to a freed object. After, the execution continue up to the err_out branch of siw_alloc_mr, and the freed mr->mem is used in siw_mr_drop_mem(mr). My patch moves "mr->mem = mem" behind the if (xa_alloc_cyclic(..)<0) {} section, to avoid the uaf. Fixes: 2251334dca ("rdma/siw: application buffer management") Link: https://lore.kernel.org/r/20210426011647.3561-1-lyl2019@mail.ustc.edu.cn Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn> Reviewed-by: Bernard Metzler <bmt@zurich.ihm.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>		2021-04-27 15:19:21 -03:00
..
rdmavt	RDMA: Support more than 255 rdma ports	2021-03-26 09:31:21 -03:00
rxe	RDMA/rxe: Fix a bug in rxe_fill_ip_info()	2021-04-21 16:09:04 -03:00
siw	RDMA/siw: Fix a use after free in siw_alloc_mr	2021-04-27 15:19:21 -03:00
Makefile	rdma/siw: addition to kernel build environment	2019-07-02 17:03:41 -03:00