Files
linux/include/net
Yunsheng Lin 89837eb4b2 net: sched: add barrier to ensure correct ordering for lockless qdisc
The spin_trylock() was assumed to contain the implicit
barrier needed to ensure the correct ordering between
STATE_MISSED setting/clearing and STATE_MISSED checking
in commit a90c57f2ce ("net: sched: fix packet stuck
problem for lockless qdisc").

But it turns out that spin_trylock() only has load-acquire
semantic, for strongly-ordered system(like x86), the compiler
barrier implicitly contained in spin_trylock() seems enough
to ensure the correct ordering. But for weakly-orderly system
(like arm64), the store-release semantic is needed to ensure
the correct ordering as clear_bit() and test_bit() is store
operation, see queued_spin_lock().

So add the explicit barrier to ensure the correct ordering
for the above case.

Fixes: a90c57f2ce ("net: sched: fix packet stuck problem for lockless qdisc")
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-06-21 11:51:41 -07:00
..
2021-06-03 15:05:06 -07:00
2019-01-23 11:18:00 -08:00
2020-05-05 13:23:29 -07:00
2021-04-19 12:25:11 +02:00
2019-12-09 10:36:44 -08:00
2020-06-22 21:12:44 -07:00
2020-11-10 17:56:54 -08:00
2021-03-30 13:29:39 -07:00
2019-12-09 10:36:44 -08:00
2020-03-04 13:25:55 -08:00
2019-04-22 21:47:25 -07:00
2019-10-05 16:29:00 -07:00
2020-06-18 20:46:23 -07:00
2019-12-09 10:28:43 -08:00