leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
4d5504ec54
linux/drivers/net/wireless
History
Arend van Spriel 4d5504ec54 brcmfmac: add missing curly braces in brcmf_fws_txstatus_suppressed() 
The 0-day testing from Fenguang Wu issued the following warning:

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git master
head:   4b074b0762
commit: 1e86d69662
    [33/59] brcmfmac: Update fwsignal to fix out of order tx.

>> drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c:1393:2-56:
    code aligned with following code on line 1394

vim +1393 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c

84bcc0c3  1387 	}
84bcc0c3  1388
84bcc0c3  1389 	entry->generation = genbit;
84bcc0c3  1390
2747e5f7  1391 	ret = brcmf_proto_hdrpull(fws->drvr, false, &ifidx, skb);
2747e5f7  1392 	if (ret == 0)
1e86d696 @1393 		brcmf_skb_htod_tag_set_field(skb, GENERATION, ..
1e86d696 @1394 		brcmf_skbcb(skb)->htod_seq = seq;
1e86d696  1395 		if (brcmf_skb_htod_seq_get_field(skb, FROMFW)) {
1e86d696  1396 			brcmf_skb_htod_seq_set_field(skb, ..
1e86d696  1397 			brcmf_skb_htod_seq_set_field(skb, ..

This warning is valid and the if statement needs curly braces here.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2013-12-18 15:18:20 -05:00
..
ath net: wirelesse: wcn36xx: pull allocation outside of critical section 2013-12-18 15:18:19 -05:00
b43 Merge branch 'for-linus-dma-masks' of git://git.linaro.org/people/rmk/linux-arm 2013-11-14 07:55:21 +09:00
b43legacy Merge branch 'for-linus-dma-masks' of git://git.linaro.org/people/rmk/linux-arm 2013-11-14 07:55:21 +09:00
brcm80211 brcmfmac: add missing curly braces in brcmf_fws_txstatus_suppressed() 2013-12-18 15:18:20 -05:00
cw1200 wireless: cw1200: Use consistent internal locking conventions 2013-12-05 14:54:47 -05:00
hostap net:drivers/net: Miscellaneous conversions to ETH_ALEN 2013-10-02 17:04:45 -04:00
ipw2x00 wireless: ipw2100: remove unnecessary pci_set_drvdata() 2013-12-05 14:56:31 -05:00
iwlegacy iwl3945: do not print RFKILL message 2013-12-05 14:54:44 -05:00
iwlwifi Merge branch 'for-john' of git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next 2013-12-18 15:09:58 -05:00
libertas drivers/net/wireless: Fix FSF address in file headers 2013-12-11 10:56:20 -05:00
libertas_tf
mwifiex Merge remote-tracking branch 'wireless-next/master' into mac80211-next 2013-12-16 11:23:45 +01:00
orinoco Merge git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next 2013-10-07 15:40:44 -04:00
p54 drivers/net/wireless: Fix FSF address in file headers 2013-12-11 10:56:20 -05:00
prism54 prism54: Fix FSF address in file headers 2013-12-11 10:56:20 -05:00
rt2x00 rt2x00: Fix FSF address in file headers 2013-12-11 10:56:19 -05:00
rtl818x rtl8187: Increase RX queue depth 2013-12-05 14:54:53 -05:00
rtlwifi rtlwifi: rtl8192c-common: Fix sparse warning 2013-12-09 15:37:55 -05:00
ti wl1251: return -ENOMEM if kzalloc fails 2013-12-05 14:54:32 -05:00
zd1211rw zd1211rw: Fix FSF address in file headers 2013-12-11 10:56:19 -05:00
adm8211.c wireless: adm8211: remove unnecessary pci_set_drvdata() 2013-09-26 15:13:42 -04:00
adm8211.h
airo_cs.c
airo.c wireless: airo: remove unnecessary pci_set_drvdata() 2013-09-26 15:13:42 -04:00
airo.h
at76c50x-usb.c
at76c50x-usb.h
atmel_cs.c drivers/net/wireless: Fix FSF address in file headers 2013-12-11 10:56:20 -05:00
atmel_pci.c drivers/net/wireless: Fix FSF address in file headers 2013-12-11 10:56:20 -05:00
atmel.c drivers/net/wireless: Fix FSF address in file headers 2013-12-11 10:56:20 -05:00
atmel.h drivers/net/wireless: Fix FSF address in file headers 2013-12-11 10:56:20 -05:00
Kconfig
mac80211_hwsim.c Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless 2013-12-06 09:50:45 -05:00
mac80211_hwsim.h
Makefile
mwl8k.c wireless: mwl8k: remove unnecessary pci_set_drvdata() 2013-09-26 15:13:44 -04:00
ray_cs.c drivers/net/wireless: Fix FSF address in file headers 2013-12-11 10:56:20 -05:00
ray_cs.h
rayctl.h
rndis_wlan.c drivers/net/wireless: Fix FSF address in file headers 2013-12-11 10:56:20 -05:00
wl3501_cs.c
wl3501.h
zd1201.c Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless 2013-08-28 10:36:09 -04:00
zd1201.h