58383c7842
The name .dev in a struct is normally reserved for a struct device that is let us say a superclass to the thing described by the struct. struct gpio_chip stands out by confusingly using a struct device *dev to point to the parent device (such as a platform_device) that represents the hardware. As we want to give gpio_chip:s real devices, this is not working. We need to rename this member to parent. This was done by two coccinelle scripts, I guess it is possible to combine them into one, but I don't know such stuff. They look like this: @@ struct gpio_chip *var; @@ -var->dev +var->parent and: @@ struct gpio_chip var; @@ -var.dev +var.parent and: @@ struct bgpio_chip *var; @@ -var->gc.dev +var->gc.parent Plus a few instances of bgpio that I couldn't figure out how to teach Coccinelle to rewrite. This patch hits all over the place, but I *strongly* prefer this solution to any piecemal approaches that just exercise patch mechanics all over the place. It mainly hits drivers/gpio and drivers/pinctrl which is my own backyard anyway. Cc: Haavard Skinnemoen <hskinnemoen@gmail.com> Cc: Rafał Miłecki <zajec5@gmail.com> Cc: Richard Purdie <rpurdie@rpsys.net> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com> Cc: Alek Du <alek.du@intel.com> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Lee Jones <lee.jones@linaro.org> Acked-by: Jiri Kosina <jkosina@suse.cz> Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no> Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
94 lines
2.2 KiB
C
94 lines
2.2 KiB
C
/*
|
|
* MOXA ART SoCs GPIO driver.
|
|
*
|
|
* Copyright (C) 2013 Jonas Jensen
|
|
*
|
|
* Jonas Jensen <jonas.jensen@gmail.com>
|
|
*
|
|
* This file is licensed under the terms of the GNU General Public
|
|
* License version 2. This program is licensed "as is" without any
|
|
* warranty of any kind, whether express or implied.
|
|
*/
|
|
|
|
#include <linux/err.h>
|
|
#include <linux/init.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/io.h>
|
|
#include <linux/gpio.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/of_gpio.h>
|
|
#include <linux/pinctrl/consumer.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/timer.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/basic_mmio_gpio.h>
|
|
|
|
#define GPIO_DATA_OUT 0x00
|
|
#define GPIO_DATA_IN 0x04
|
|
#define GPIO_PIN_DIRECTION 0x08
|
|
|
|
static int moxart_gpio_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
struct resource *res;
|
|
struct bgpio_chip *bgc;
|
|
void __iomem *base;
|
|
int ret;
|
|
|
|
bgc = devm_kzalloc(dev, sizeof(*bgc), GFP_KERNEL);
|
|
if (!bgc)
|
|
return -ENOMEM;
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
base = devm_ioremap_resource(dev, res);
|
|
if (IS_ERR(base))
|
|
return PTR_ERR(base);
|
|
|
|
ret = bgpio_init(bgc, dev, 4, base + GPIO_DATA_IN,
|
|
base + GPIO_DATA_OUT, NULL,
|
|
base + GPIO_PIN_DIRECTION, NULL,
|
|
BGPIOF_READ_OUTPUT_REG_SET);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "bgpio_init failed\n");
|
|
return ret;
|
|
}
|
|
|
|
bgc->gc.label = "moxart-gpio";
|
|
bgc->gc.request = gpiochip_generic_request;
|
|
bgc->gc.free = gpiochip_generic_free;
|
|
bgc->data = bgc->read_reg(bgc->reg_set);
|
|
bgc->gc.base = 0;
|
|
bgc->gc.ngpio = 32;
|
|
bgc->gc.parent = dev;
|
|
bgc->gc.owner = THIS_MODULE;
|
|
|
|
ret = gpiochip_add(&bgc->gc);
|
|
if (ret) {
|
|
dev_err(dev, "%s: gpiochip_add failed\n",
|
|
dev->of_node->full_name);
|
|
return ret;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static const struct of_device_id moxart_gpio_match[] = {
|
|
{ .compatible = "moxa,moxart-gpio" },
|
|
{ }
|
|
};
|
|
|
|
static struct platform_driver moxart_gpio_driver = {
|
|
.driver = {
|
|
.name = "moxart-gpio",
|
|
.of_match_table = moxart_gpio_match,
|
|
},
|
|
.probe = moxart_gpio_probe,
|
|
};
|
|
module_platform_driver(moxart_gpio_driver);
|
|
|
|
MODULE_DESCRIPTION("MOXART GPIO chip driver");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Jonas Jensen <jonas.jensen@gmail.com>");
|