linux/tools/perf/ui
Namhyung Kim d50bf78ff6 perf ui/gtk: Fix segmentation fault on perf_hpp__for_each_format loop
The commit 2b8bfa6bb8 ("perf tools: Centralize default columns init in
perf_hpp__init") moves initialization of common overhead column to
perf_hpp__init() but forgot about the gtk code.

So the gtk code added the same column to the list twice causing infinite
loop when iterating it by perf_hpp__for_each_format loop.  When I run
perf report --gtk, I can see following messages indefinitely.

  (perf:11687): Gtk-CRITICAL **: IA__gtk_main_quit: assertion 'main_loops != NULL' failed
  perf: Segmentation fault

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1375766056-19377-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2013-08-07 17:35:39 -03:00
..
browsers perf annotate browser: Fix typo 2013-08-07 17:35:37 -03:00
gtk perf ui/gtk: Fix segmentation fault on perf_hpp__for_each_format loop 2013-08-07 17:35:39 -03:00
stdio perf tools: Move hist_entry__period_snprintf into stdio code 2013-07-12 13:54:18 -03:00
tui perf tools: Remove dependency on libnewt 2013-04-01 12:23:21 -03:00
browser.c perf tools: Remove dependency on libnewt 2013-04-01 12:23:21 -03:00
browser.h perf tools: Remove dependency on libnewt 2013-04-01 12:23:21 -03:00
helpline.c perf ui/helpline: Introduce ui_helpline__vshow() 2012-12-09 08:46:04 -03:00
helpline.h perf ui/helpline: Introduce ui_helpline__vshow() 2012-12-09 08:46:04 -03:00
hist.c perf tools: Move hist_entry__period_snprintf into stdio code 2013-07-12 13:54:18 -03:00
keysyms.h perf hists browser: Add option for runtime switching perf data file 2013-02-06 18:09:24 -03:00
libslang.h perf tools: Move UI bits to tools/perf/ui directory 2012-04-11 17:16:40 -03:00
progress.c perf ui: Add ui_progress__finish() 2012-11-14 16:52:56 -03:00
progress.h perf ui: Add ui_progress__finish() 2012-11-14 16:52:56 -03:00
setup.c perf tools: Centralize default columns init in perf_hpp__init 2013-07-12 13:53:59 -03:00
ui.h perf tools: Remove dependency on libnewt 2013-04-01 12:23:21 -03:00
util.c perf evsel: Introduce perf_evsel__open_strerror method 2013-01-24 16:40:09 -03:00
util.h perf ui: Introduce struct perf_error_ops 2012-06-19 13:06:18 -03:00