leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
4953d2c25a
linux/drivers/staging/rtl8712
History
Haneen Mohammed e0e982b436 Staging: rtl8712: replace memcpy with ether_addr_copy 
This patch replace memcpy with ethe_addr_copy to address the following
warning generated by checkpatch.pl: ""Prefer ether_addr_copy over memcpy
if the Ethernet addresses are __aligned(2)"

Follwoing is the output of pahole for the relevant datastructures:
1- for  "iwe.u.ap_addr.sa_data" and "wrqu->ap_addr.sa_data"

struct sockaddr {
        sa_family_t                sa_family;            /*     0     2 */
        char                       sa_data[14];          /*     2    14 */

        /* size: 16, cachelines: 1, members: 2 */
        /* last cacheline: 16 bytes */
};

struct iw_event {
        __u16                      len;                  /*     0     2 */
        __u16                      cmd;                  /*     2     2 */

        /* XXX 4 bytes hole, try to pack */

        union iwreq_data           u;                    /*     8    16 */

        /* size: 24, cachelines: 1, members: 3 */
        /* sum members: 20, holes: 1, sum holes: 4 */
        /* last cacheline: 24 bytes */
};

2- for  "pnetwork->network.MacAddress" and "pcur_bss->MacAddress"

struct wlan_network {
        struct list_head           list;                 /*     0    16 */
        int                        network_type;         /*    16     4 */
        int                        fixed;                /*    20     4 */
        unsigned int               last_scanned;         /*    24     4 */
        int                        aid;                  /*    28     4 */
        int                        join_res;             /*    32     4 */
        struct ndis_wlan_bssid_ex  network;              /*    36   884 */
        /* --- cacheline 14 boundary (896 bytes) was 24 bytes ago ---   */

        /* size: 920, cachelines: 15, members: 7 */
        /* last cacheline: 24 bytes */
};

struct ndis_wlan_bssid_ex {
        u32                        Length;               /*     0     4 */
        unsigned char              MacAddress[6];        /*     4     6 */
        u8                         Reserved[2];          /*    10     2 */
        struct ndis_802_11_ssid    Ssid;                 /*    12    36 */
        u32                        Privacy;              /*    48     4 */
        s32                        Rssi;                 /*    52     4 */
        enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;  /*    56     4 */
        struct NDIS_802_11_CONFIGURATION Configuration;  /*    60    32 */
        /* --- cacheline 1 boundary (64 bytes) was 28 bytes ago --- */
        enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; /* 92     4 */
        NDIS_802_11_RATES_EX       SupportedRates;       /*    96    16 */
        u32                        IELength;             /*   112     4 */
        u8                         IEs[768];             /*   116   768 */
        /* --- cacheline 13 boundary (832 bytes) was 52 bytes ago --- */

        /* size: 884, cachelines: 14, members: 12 */
        /* last cacheline: 52 bytes */
};

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-03-18 10:32:39 +01:00
..
basic_types.h
drv_types.h staging: rtl8712: Do coding style cleanup 2015-02-07 17:39:50 +08:00
ethernet.h
hal_init.c Staging rtl8172: Remove unnecessary typecast 2015-03-09 13:37:22 +01:00
ieee80211.c staging: rtl8712: remove unused variables 2014-10-29 17:37:26 +08:00
ieee80211.h
Kconfig
Makefile
mlme_linux.c Staging: rtl8712: Eliminate use of _init_timer 2015-03-06 09:54:34 -08:00
mlme_osdep.h
mp_custom_oid.h
os_intfs.c Staging: rtl8712: Eliminate use of _cancel_timer_ex 2015-03-16 15:46:07 +01:00
osdep_intf.h
osdep_service.h Staging: rtl8712: Eliminate use of _cancel_timer 2015-03-16 15:46:07 +01:00
recv_linux.c Staging: rtl8712: Eliminate use of _init_timer 2015-03-06 09:54:34 -08:00
recv_osdep.h staging: rtl8712: recv_linux: Remove unused function 2015-01-25 19:59:18 +08:00
rtl871x_cmd.c Staging: rtl8712: Eliminate use of _cancel_timer 2015-03-16 15:46:07 +01:00
rtl871x_cmd.h
rtl871x_debug.h
rtl871x_eeprom.c staging: rtl8712: rewrite the right hand side of an assignment 2015-02-26 15:23:47 -08:00
rtl871x_eeprom.h
rtl871x_event.h
rtl871x_ht.h
rtl871x_io.c
rtl871x_io.h
rtl871x_ioctl_linux.c Staging: rtl8712: replace memcpy with ether_addr_copy 2015-03-18 10:32:39 +01:00
rtl871x_ioctl_rtl.c
rtl871x_ioctl_rtl.h
rtl871x_ioctl_set.c Staging: rtl8712: Eliminate use of _set_timer 2015-03-01 17:02:11 -08:00
rtl871x_ioctl_set.h
rtl871x_ioctl.h
rtl871x_led.h
rtl871x_mlme.c Staging: rtl8712: fix potential null pointer dereference 2015-03-16 15:48:20 +01:00
rtl871x_mlme.h
rtl871x_mp_ioctl.c staging: rtl8712: remove unused function 2015-01-25 19:59:19 +08:00
rtl871x_mp_ioctl.h staging: rtl8712: rtl871x_mp_ioctl.c: Remove some unused functions 2015-01-17 14:10:03 -08:00
rtl871x_mp_phy_regdef.h
rtl871x_mp.c staging: rtl8712: remove extra parentheses around right bit shift operation 2015-03-06 15:22:43 -08:00
rtl871x_mp.h
rtl871x_pwrctrl.c Staging: rtl8712: Eliminate use of _cancel_timer_ex 2015-03-16 15:46:07 +01:00
rtl871x_pwrctrl.h staging: rtl8712: remove spaces before commas 2015-01-17 14:20:25 -08:00
rtl871x_recv.c staing: rtl8712: else after return or break warning 2015-02-26 15:08:36 -08:00
rtl871x_recv.h staging: rtl8712: remove unused variables 2014-10-29 17:37:26 +08:00
rtl871x_rf.h
rtl871x_security.c drivers: staging: rtl8712: Removed unnecessary parentheses 2015-03-09 13:37:22 +01:00
rtl871x_security.h Staging: rtl8712: Eliminate use of _init_timer 2015-03-06 09:54:34 -08:00
rtl871x_sta_mgt.c Staging: rtl8712: Eliminate use of _cancel_timer_ex 2015-03-16 15:46:07 +01:00
rtl871x_wlan_sme.h
rtl871x_xmit.c Staging: rtl8712: Eliminate use of _cancel_timer 2015-03-16 15:46:07 +01:00
rtl871x_xmit.h
rtl8712_bitdef.h
rtl8712_cmd.c staging: rtl8712: rewrite the right hand side of an assignment 2015-02-26 15:23:47 -08:00
rtl8712_cmd.h staging: rtl8712: remove spaces before commas 2015-01-17 14:20:25 -08:00
rtl8712_cmdctrl_bitdef.h
rtl8712_cmdctrl_regdef.h
rtl8712_debugctrl_bitdef.h
rtl8712_debugctrl_regdef.h
rtl8712_edcasetting_bitdef.h
rtl8712_edcasetting_regdef.h
rtl8712_efuse.c staging: rtl8712: remove unused variables 2014-10-29 17:37:26 +08:00
rtl8712_efuse.h
rtl8712_event.h staging: rtl8712: remove spaces before commas 2015-01-17 14:20:25 -08:00
rtl8712_fifoctrl_bitdef.h
rtl8712_fifoctrl_regdef.h
rtl8712_gp_bitdef.h
rtl8712_gp_regdef.h
rtl8712_hal.h
rtl8712_interrupt_bitdef.h
rtl8712_io.c
rtl8712_led.c Staging: rtl8712: Eliminate use of _cancel_timer_ex 2015-03-16 15:46:07 +01:00
rtl8712_macsetting_bitdef.h
rtl8712_macsetting_regdef.h
rtl8712_powersave_bitdef.h
rtl8712_powersave_regdef.h
rtl8712_ratectrl_bitdef.h
rtl8712_ratectrl_regdef.h
rtl8712_recv.c staging: rtl8712: remove extra parentheses around right bit shift operation 2015-03-06 15:22:43 -08:00
rtl8712_recv.h
rtl8712_regdef.h
rtl8712_security_bitdef.h
rtl8712_spec.h
rtl8712_syscfg_bitdef.h
rtl8712_syscfg_regdef.h
rtl8712_timectrl_bitdef.h
rtl8712_timectrl_regdef.h
rtl8712_wmac_bitdef.h
rtl8712_wmac_regdef.h
rtl8712_xmit.c
rtl8712_xmit.h
sta_info.h staging: rtl8712: remove spaces before commas 2015-01-17 14:20:25 -08:00
TODO
usb_halinit.c
usb_intf.c staging: rtl8712: fix Prefer ether_addr_copy() over memcpy() 2015-02-07 17:15:43 +08:00
usb_ops_linux.c staging: rtl8712: remove unused variables 2014-10-29 17:37:26 +08:00
usb_ops.c
usb_ops.h
usb_osintf.h
wifi.h Staging: rtl8712: Replace __constant_cpu_to_le16 2015-03-16 15:48:20 +01:00
wlan_bssdef.h
xmit_linux.c staging: rtl8712: remove unused variables 2014-10-29 17:37:26 +08:00
xmit_osdep.h