Files
linux/drivers/gpu/drm
Thomas Hellström 48da0f67c5 drm/i915: Fix vm use-after-free in vma destruction
In vma destruction, the following race may occur:

Thread 1:	    		  Thread 2:
i915_vma_destroy();

  ...
  list_del_init(vma->vm_link);
  ...
  mutex_unlock(vma->vm->mutex);
				  __i915_vm_release();
release_references();

And in release_reference() we dereference vma->vm to get to the
vm gt pointer, leading to a use-after free.

However, __i915_vm_release() grabs the vm->mutex so the vm won't be
destroyed before vma->vm->mutex is released, so extract the gt pointer
under the vm->mutex to avoid the vma->vm dereference in
release_references().

v2: Fix a typo in the commit message (Andi Shyti)

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5944
Fixes: e1a7ab4fca ("drm/i915: Remove the vm open count")

Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Acked-by: Nirmoy Das <nirmoy.das@intel.con>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220620123659.381772-1-thomas.hellstrom@linux.intel.com
(cherry picked from commit 1926a6b759)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
2022-07-12 18:16:40 -04:00
..
2022-06-09 10:27:49 +02:00
2022-04-25 11:17:45 +02:00
2022-02-07 16:35:35 -08:00
2022-04-25 11:17:45 +02:00
2022-04-07 11:31:52 +02:00
2022-04-25 10:18:52 +03:00
2022-06-14 11:15:19 +02:00
2022-02-07 16:35:35 -08:00
2022-03-16 09:36:13 +01:00
2022-02-07 16:35:35 -08:00
2022-05-04 14:09:34 +02:00
2022-04-12 09:27:20 +03:00
2022-04-07 12:53:53 +02:00
2021-11-30 09:41:28 +01:00
2021-11-30 09:41:28 +01:00
2022-02-07 16:35:35 -08:00
2022-04-12 09:27:20 +03:00