leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
476525004a
linux/drivers/bcma
History
Hauke Mehrtens 1f03bf06e4 bcma: fix invalid PMU chip control masks 
Commit b9562545ef ("bcma: complete workaround for BCMA43224 and
BCM4313") introduced the wrong masks for setting the chip control
registers - the "mask" parameter is inverse.

It should be the mask of bits *not* changed, which is admittedly a bit
non-intuitive.

The incorrect mask not only causes the driver to not work correctly on
the chips affected (eg the BCM43224 on the Macbook Air 4,2) but the
state persists over a soft reset, causing the next boot to not
necessarily see the device correctly.

Reported-and-tested-by: Linus Torvalds <torvalds@linux-foundation.org>
Tested-by: Seth Forshee <seth.forshee@canonical.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>
Cc: Arend Van Spriel <arend@broadcom.com>
Cc: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Cc: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-07-26 12:46:54 -07:00
..
bcma_private.h bcma: add place for flash memory support 2012-07-17 15:11:40 -04:00
core.c bcma: use custom printing functions 2012-07-09 16:36:36 -04:00
driver_chipcommon_nflash.c bcma: add place for flash memory support 2012-07-17 15:11:40 -04:00
driver_chipcommon_pmu.c bcma: fix invalid PMU chip control masks 2012-07-26 12:46:54 -07:00
driver_chipcommon_sflash.c bcma: add place for flash memory support 2012-07-17 15:11:40 -04:00
driver_chipcommon.c bcma: fix CC driver compilation on MIPS 2012-07-11 15:40:21 -04:00
driver_gmac_cmn.c bcma: add trivial GBIT MAC COMMON driver 2012-07-12 15:27:18 -04:00
driver_mips.c bcma: add place for flash memory support 2012-07-17 15:11:40 -04:00
driver_pci_host.c bcma: use custom printing functions 2012-07-09 16:36:36 -04:00
driver_pci.c bcma: fix null pointer in bcma_core_pci_irq_ctl 2012-06-08 13:47:07 -04:00
host_pci.c bcma: use custom printing functions 2012-07-09 16:36:36 -04:00
host_soc.c bcma: add SOC bus 2011-08-08 14:29:25 -04:00
Kconfig bcma: add place for flash memory support 2012-07-17 15:11:40 -04:00
main.c bcma: add trivial GBIT MAC COMMON driver 2012-07-12 15:27:18 -04:00
Makefile bcma: add place for flash memory support 2012-07-17 15:11:40 -04:00
README bcma: add Broadcom specific AMBA bus driver 2011-05-10 15:54:54 -04:00
scan.c bcma: add new cores at the end of list 2012-07-12 15:27:18 -04:00
scan.h bcma: fix typo - reading number of slave wrappers 2012-07-12 15:27:17 -04:00
sprom.c bcma: use custom printing functions 2012-07-09 16:36:36 -04:00
TODO bcma: add Broadcom specific AMBA bus driver 2011-05-10 15:54:54 -04:00

README 

Broadcom introduced new bus as replacement for older SSB. It is based on AMBA,
however from programming point of view there is nothing AMBA specific we use.

Standard AMBA drivers are platform specific, have hardcoded addresses and use
AMBA standard fields like CID and PID.

In case of Broadcom's cards every device consists of:
1) Broadcom specific AMBA device. It is put on AMBA bus, but can not be treated
   as standard AMBA device. Reading it's CID or PID can cause machine lockup.
2) AMBA standard devices called ports or wrappers. They have CIDs (AMBA_CID)
   and PIDs (0x103BB369), but we do not use that info for anything. One of that
   devices is used for managing Broadcom specific core.

Addresses of AMBA devices are not hardcoded in driver and have to be read from
EPROM.

In this situation we decided to introduce separated bus. It can contain up to
16 devices identified by Broadcom specific fields: manufacturer, id, revision
and class.