Chris Wilson 457db89b53 drm/i915: Mark the userptr invalidate workqueue as WQ_MEM_RECLAIM ... Commit 21cc6431e0 ("drm/i915: Mark the userptr invalidate workqueue as WQ_MEM_RECLAIM") tried to fixup the check_flush_dependency warning for hitting i915_gem_userptr_mn_invalidate_range_start from within the shrinker, but I failed to notice userptr has 2 similarly named workqueues. I marked up i915-userptr-acquire as WQ_MEM_RECLAIM whereas we only wait upon i915-userptr-release from inside the reclaim paths. [62530.869510] workqueue: PF_MEMALLOC task 7983(gem_shrink) is flushing !WQ_MEM_RECLAIM i915-userptr-release: (null) [62530.869515] ------------[ cut here ]------------ [62530.869519] WARNING: CPU: 1 PID: 7983 at kernel/workqueue.c:2434 check_flush_dependency+0x7f/0x110 [62530.869519] Modules linked in: pegasus mii ip6table_filter ip6_tables bnep iptable_filter snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic binfmt_misc nls_iso8859_1 intel_rapl x86_pkg_temp_thermal intel_powerclamp coretemp snd_hda_intel snd_hda_codec kvm_intel snd_hda_core snd_hwdep kvm snd_pcm irqbypass snd_seq_midi snd_seq_midi_event snd_rawmidi crct10dif_pclmul crc32_pclmul 8250_dw ghash_clmulni_intel snd_seq pcbc snd_seq_device snd_timer btusb aesni_intel btrtl btbcm aes_x86_64 iwlwifi btintel crypto_simd glue_helper cryptd bluetooth snd intel_cstate input_leds idma64 intel_rapl_perf ecdh_generic serio_raw soundcore cfg80211 wmi_bmof virt_dma intel_lpss_pci intel_lpss acpi_als kfifo_buf industrialio winbond_cir soc_button_array rc_core spidev tpm_crb intel_hid acpi_pad mac_hid sparse_keymap [62530.869546] parport_pc ppdev lp parport ip_tables x_tables autofs4 hid_generic usbhid i915 i2c_algo_bit prime_numbers drm_kms_helper syscopyarea e1000e sysfillrect sysimgblt fb_sys_fops ahci ptp pps_core libahci drm wmi video i2c_hid hid [62530.869557] CPU: 1 PID: 7983 Comm: gem_shrink Tainted: G U W L 4.14.0-rc8-drm-tip-ww45-commit-1342299+ #1 [62530.869558] Hardware name: Intel Corporation CoffeeLake Client Platform/CoffeeLake H DDR4 RVP, BIOS CNLSFWR1.R00.X098.A00.1707301945 07/30/2017 [62530.869559] task: ffffa1049dbeec80 task.stack: ffffae7d05c44000 [62530.869560] RIP: 0010:check_flush_dependency+0x7f/0x110 [62530.869561] RSP: 0018:ffffae7d05c473a0 EFLAGS: 00010286 [62530.869562] RAX: 000000000000006e RBX: ffffa1049540f400 RCX: ffffffffa3e55788 [62530.869562] RDX: 0000000000000000 RSI: 0000000000000092 RDI: 0000000000000202 [62530.869563] RBP: ffffae7d05c473c0 R08: 000000000000006e R09: 000000000038bb0e [62530.869563] R10: 0000000000000000 R11: 000000000000006e R12: ffffa1049dbeec80 [62530.869564] R13: 0000000000000000 R14: 0000000000000000 R15: ffffae7d05c473e0 [62530.869565] FS: 00007f621b129880(0000) GS:ffffa1050b240000(0000) knlGS:0000000000000000 [62530.869566] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [62530.869566] CR2: 00007f6214400000 CR3: 0000000353a17003 CR4: 00000000003606e0 [62530.869567] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [62530.869567] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [62530.869568] Call Trace: [62530.869570] flush_workqueue+0x115/0x3d0 [62530.869573] ? wake_up_process+0x15/0x20 [62530.869596] i915_gem_userptr_mn_invalidate_range_start+0x12f/0x160 [i915] [62530.869614] ? i915_gem_userptr_mn_invalidate_range_start+0x12f/0x160 [i915] [62530.869616] __mmu_notifier_invalidate_range_start+0x55/0x80 [62530.869618] try_to_unmap_one+0x791/0x8b0 [62530.869620] ? call_rwsem_down_read_failed+0x18/0x30 [62530.869622] rmap_walk_anon+0x10b/0x260 [62530.869624] rmap_walk+0x48/0x60 [62530.869625] try_to_unmap+0x93/0xf0 [62530.869626] ? page_remove_rmap+0x2a0/0x2a0 [62530.869627] ? page_not_mapped+0x20/0x20 [62530.869629] ? page_get_anon_vma+0x90/0x90 [62530.869630] ? invalid_mkclean_vma+0x20/0x20 [62530.869631] migrate_pages+0x946/0xaa0 [62530.869633] ? __ClearPageMovable+0x10/0x10 [62530.869635] ? isolate_freepages_block+0x3c0/0x3c0 [62530.869636] compact_zone+0x22f/0x970 [62530.869638] compact_zone_order+0xa3/0xd0 [62530.869640] try_to_compact_pages+0x1a5/0x2a0 [62530.869641] ? try_to_compact_pages+0x1a5/0x2a0 [62530.869643] __alloc_pages_direct_compact+0x50/0x110 [62530.869644] __alloc_pages_slowpath+0x4da/0xf30 [62530.869646] __alloc_pages_nodemask+0x262/0x280 [62530.869648] alloc_pages_vma+0x165/0x1e0 [62530.869649] shmem_alloc_hugepage+0xd0/0x130 [62530.869651] ? __radix_tree_insert+0x45/0x230 [62530.869652] ? __vm_enough_memory+0x29/0x130 [62530.869654] shmem_alloc_and_acct_page+0x10d/0x1e0 [62530.869655] shmem_getpage_gfp+0x426/0xc00 [62530.869657] shmem_fault+0xa0/0x1e0 [62530.869659] ? file_update_time+0x60/0x110 [62530.869660] __do_fault+0x1e/0xc0 [62530.869661] __handle_mm_fault+0xa35/0x1170 [62530.869662] handle_mm_fault+0xcc/0x1c0 [62530.869664] __do_page_fault+0x262/0x4f0 [62530.869666] do_page_fault+0x2e/0xe0 [62530.869667] page_fault+0x22/0x30 [62530.869668] RIP: 0033:0x404335 [62530.869669] RSP: 002b:00007fff7829e420 EFLAGS: 00010216 [62530.869670] RAX: 00007f6210400000 RBX: 0000000000000004 RCX: 0000000000b80000 [62530.869670] RDX: 0000000000002e01 RSI: 0000000000008000 RDI: 0000000000000004 [62530.869671] RBP: 0000000000000019 R08: 0000000000000002 R09: 0000000000000000 [62530.869671] R10: 0000000000000559 R11: 0000000000000246 R12: 0000000008000000 [62530.869672] R13: 00000000004042f0 R14: 0000000000000004 R15: 000000000000007e [62530.869673] Code: 00 8b b0 18 05 00 00 48 8d 8b b0 00 00 00 48 8d 90 c0 06 00 00 4d 89 f0 48 c7 c7 40 c0 c8 a3 c6 05 68 c5 e8 00 01 e8 c2 68 04 00 <0f> ff 4d 85 ed 74 18 49 8b 45 20 48 8b 70 08 8b 86 00 01 00 00 [62530.869691] ---[ end trace 01e01ad0ff5781f8 ]--- Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103739 Fixes: 21cc6431e0 ("drm/i915: Mark the userptr invalidate workqueue as WQ_MEM_RECLAIM") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Michał Winiarski <michal.winiarski@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20171114173520.8829-1-chris@chris-wilson.co.uk Reviewed-by: Matthew Auld <matthew.auld@intel.com> (cherry picked from commit 41729bf224) Signed-off-by: Jani Nikula <jani.nikula@intel.com>		2017-11-21 11:40:01 +02:00
..
amd	drm/amd/amdgpu: Enabling ACP clock in hw_init (v2)	2017-11-03 15:44:46 -04:00
arc	drm/arc: Use drm_gem_fb_create()	2017-09-02 14:23:06 +02:00
arm	drm/arm/mali: Use drm_gem_fb_create()	2017-08-27 19:29:46 +02:00
armada	drm/armada: Replace drm_framebuffer_reference/unreference() with _get/put()	2017-10-16 15:02:44 -04:00
ast	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
atmel-hlcdc	drm/atmel-hlcdc: Use drm_gem_fb_create()	2017-08-27 19:30:15 +02:00
bochs	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
bridge	drm/bridge: adv7511: Fix a use after free	2017-10-18 09:38:43 +05:30
cirrus	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
etnaviv	drm/etnaviv: short-circuit perfmon ioctls	2017-10-22 18:41:56 +02:00
exynos	Linux 4.14-rc7	2017-11-02 12:40:41 +10:00
fsl-dcu	drm/fsl-dcu: Use drm_gem_fb_create()	2017-10-01 17:00:20 +02:00
gma500	drm/gma500: use ARRAY_SIZE	2017-10-16 11:29:05 +02:00
hisilicon	drm/hisilicon: Ensure LDI regs are properly configured.	2017-11-01 10:36:50 +08:00
i2c	drm: i2c: tda998x: constify i2c_device_id	2017-08-22 08:33:44 +02:00
i810	drm/pci: Deprecate drm_pci_init/exit completely	2017-06-20 10:41:03 +02:00
i915	drm/i915: Mark the userptr invalidate workqueue as WQ_MEM_RECLAIM	2017-11-21 11:40:01 +02:00
imx	Merge tag 'drm-misc-next-2017-09-20' of git://anongit.freedesktop.org/git/drm-misc into drm-next	2017-09-28 05:46:15 +10:00
lib	mm: treewide: remove GFP_TEMPORARY allocation flag	2017-09-13 18:53:16 -07:00
mediatek	drm/mediatek: hdmi: clean up drm_bridge_add call	2017-08-21 08:49:24 +05:30
meson	drm/meson: Use drm_gem_fb_create()	2017-10-01 17:01:39 +02:00
mga	Merge airlied/drm-next into drm-misc-next	2017-07-26 13:43:33 +02:00
mgag200	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
msm	Linux 4.14-rc7	2017-11-02 12:40:41 +10:00
mxsfb	drm/mxsfb: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb()	2017-10-01 17:02:20 +02:00
nouveau	drm/nouveau/bios/timing: mark expected switch fall-throughs	2017-11-03 09:12:10 +10:00
omapdrm	omapdrm: omapdss_hdmi_ops: add lost_hotplug op	2017-10-12 10:49:14 +03:00
panel	drm/panel: simple: add Toshiba LT089AC19000	2017-10-19 11:48:44 +02:00
pl111	drm/pl111: Add handling of Versatile platforms	2017-09-10 23:58:42 +02:00
qxl	qxl: fix framebuffer unpinning	2017-09-25 08:35:53 +02:00
r128	drm/pci: Deprecate drm_pci_init/exit completely	2017-06-20 10:41:03 +02:00
radeon	Merge tag 'drm-amdkfd-next-2017-11-02' of git://people.freedesktop.org/~gabbayo/linux into drm-next	2017-11-03 05:12:24 +10:00
rcar-du	drm/rcar-du: Use drm_gem_fb_create()	2017-10-01 17:02:53 +02:00
rockchip	drm/rockchip: add PINCTRL dependency for LVDS	2017-10-13 09:43:16 +08:00
savage	drm/pci: Deprecate drm_pci_init/exit completely	2017-06-20 10:41:03 +02:00
selftests	mm: treewide: remove GFP_TEMPORARY allocation flag	2017-09-13 18:53:16 -07:00
shmobile	drm/shmobile: Use drm_gem_fb_create()	2017-10-01 17:03:22 +02:00
sis	drm/pci: Deprecate drm_pci_init/exit completely	2017-06-20 10:41:03 +02:00
sti	drm/sti: Use drm_gem_fb_create()	2017-08-27 19:30:49 +02:00
stm	drm/stm: ltdc: remove bridge from driver internal structure	2017-10-10 11:32:48 +02:00
sun4i	drm/sun4i: Add support for A20 display pipeline components	2017-10-17 19:49:17 +02:00
tdfx	drm/pci: Deprecate drm_pci_init/exit completely	2017-06-20 10:41:03 +02:00
tegra	drm/tegra: hdmi: Add cec-notifier support	2017-10-20 14:19:54 +02:00
tilcdc	tilcdc changes for v4.15	2017-10-17 10:13:47 +10:00
tinydrm	drm/tinydrm: Remove explicit .best_encoder assignment	2017-10-13 17:34:51 +02:00
ttm	drm/ttm: Downgrade pr_err to pr_debug for memory allocation failures	2017-11-04 09:48:28 -04:00
tve200	drm/tve200: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb()	2017-10-01 17:04:36 +02:00
udl	Merge tag 'drm-misc-next-2017-10-20' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-10-24 16:51:05 +10:00
vc4	drm/vc4: Fix sleeps during the IRQ handler for DSI transactions.	2017-10-19 13:20:09 -07:00
vgem	drm/vgem: switch to drm_*_get(), drm_*_put() helpers	2017-08-11 11:41:43 -04:00
via	drm/via: use ARRAY_SIZE	2017-10-16 11:29:28 +02:00
virtio	Merge airlied/drm-next into drm-misc-next	2017-10-03 11:09:16 +02:00
vmwgfx	drm: Reorganize drm_pending_event to support future event types [v2]	2017-10-21 07:23:40 +10:00
zte	drm/zte: Use drm_gem_fb_create()	2017-08-27 19:31:06 +02:00
ati_pcigart.c
drm_agpsupport.c	drm/agpsupport: Remove extra blank line	2017-09-20 09:54:19 -07:00
drm_atomic_helper.c	Merge tag 'drm-misc-next-2017-10-20' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-10-24 16:51:05 +10:00
drm_atomic.c	drm: Reorganize drm_pending_event to support future event types [v2]	2017-10-21 07:23:40 +10:00
drm_auth.c	drm: Check mode object lease status in all master ioctl paths [v4]	2017-10-25 16:31:30 +10:00
drm_blend.c	mm: treewide: remove GFP_TEMPORARY allocation flag	2017-09-13 18:53:16 -07:00
drm_bridge.c	drm/bridge: change return type of drm_bridge_add function	2017-08-21 08:51:53 +05:30
drm_bufs.c	switch compat_drm_mapbufs() to drm_ioctl_kernel()	2017-07-04 13:16:26 -04:00
drm_cache.c
drm_color_mgmt.c	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
drm_connector.c	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
drm_context.c
drm_crtc_helper_internal.h
drm_crtc_helper.c	drm: Replace kzalloc with kcalloc	2017-10-13 15:49:03 -04:00
drm_crtc_internal.h	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
drm_crtc.c	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
drm_debugfs_crc.c	drm/atomic: Prepare drm_modeset_lock infrastructure for interruptible waiting, v2.	2017-09-13 09:50:52 +02:00
drm_debugfs.c
drm_dma.c
drm_dp_aux_dev.c	drm_dp_aux_dev: switch to read_iter/write_iter	2017-07-08 20:51:46 -04:00
drm_dp_dual_mode_helper.c	drm: Add retries for lspcon mode detection	2017-10-13 12:13:54 +03:00
drm_dp_helper.c	drm/dp: WARN about invalid/unknown link rates and bw codes	2017-10-11 18:41:44 +03:00
drm_dp_mst_topology.c	drm/dp/mst: Sideband message transaction to power up/down nodes	2017-09-11 16:03:57 +03:00
drm_drv.c	drm: Add new LEASE debug level	2017-10-25 16:31:29 +10:00
drm_dumb_buffers.c	drm/dumb-buffers: Add defaults for .dumb_map_offset and .dumb_destroy	2017-07-29 13:51:44 +02:00
drm_edid_load.c	drm: add backwards compatibility support for drm_kms_helper.edid_firmware	2017-09-19 18:11:45 +03:00
drm_edid.c	drm: handle override and firmware EDID at drm_do_get_edid() level	2017-09-19 17:49:25 +03:00
drm_encoder_slave.c
drm_encoder.c	drm: Check mode object lease status in all master ioctl paths [v4]	2017-10-25 16:31:30 +10:00
drm_fb_cma_helper.c	drm/fb-cma-helper: Remove unused functions	2017-10-01 17:05:39 +02:00
drm_fb_helper.c	drm: Replace kzalloc with kcalloc	2017-10-13 15:49:03 -04:00
drm_file.c	drm: Document device unplug infrastructure	2017-08-11 10:48:03 +02:00
drm_flip_work.c
drm_fourcc.c
drm_framebuffer.c	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
drm_gem_cma_helper.c	drm/gem-cma-helper: Change the level of the allocation failure message	2017-10-16 15:19:57 +02:00
drm_gem_framebuffer_helper.c	drm/gem-fb-helper: Improve documentation	2017-10-08 15:02:51 +02:00
drm_gem.c	drm: fix typo in drm_gem_get_pages() comment	2017-10-04 18:04:28 +02:00
drm_global.c
drm_hashtab.c
drm_info.c
drm_internal.h	drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls [v3]	2017-10-23 11:15:03 +10:00
drm_ioc32.c	Merge airlied/drm-next into drm-misc-next	2017-07-26 13:43:33 +02:00
drm_ioctl.c	drm: Add four ioctls for managing drm mode object leases [v7]	2017-10-25 16:31:30 +10:00
drm_irq.c
drm_kms_helper_common.c	drm: add backwards compatibility support for drm_kms_helper.edid_firmware	2017-09-19 18:11:45 +03:00
drm_lease.c	drm: Add four ioctls for managing drm mode object leases [v7]	2017-10-25 16:31:30 +10:00
drm_legacy.h	switch compat_drm_mapbufs() to drm_ioctl_kernel()	2017-07-04 13:16:26 -04:00
drm_lock.c
drm_memory.c
drm_mipi_dsi.c	drm: Convert to using %pOF instead of full_name	2017-07-26 13:45:06 +02:00
drm_mm.c	lib/interval_tree: fast overlap detection	2017-09-08 18:26:49 -07:00
drm_mode_config.c	drm: Check mode object lease status in all master ioctl paths [v4]	2017-10-25 16:31:30 +10:00
drm_mode_object.c	drm: Add four ioctls for managing drm mode object leases [v7]	2017-10-25 16:31:30 +10:00
drm_modes.c	drm/modes: Fix drm_mode_is_420_only() comment	2017-07-31 14:23:30 +02:00
drm_modeset_helper.c	drm: Plumb modifiers through plane init	2017-08-01 17:50:06 +01:00
drm_modeset_lock.c	drm/atomic: Prepare drm_modeset_lock infrastructure for interruptible waiting, v2.	2017-09-13 09:50:52 +02:00
drm_of.c	drm/drm_of: Move drm_of_panel_bridge_remove_function into header.	2017-10-13 16:59:36 +02:00
drm_panel.c
drm_pci.c	drm/core: clean up references to drm_dev_unref()	2017-09-27 10:53:12 +02:00
drm_plane_helper.c	drm: Replace kzalloc with kcalloc	2017-10-13 15:49:03 -04:00
drm_plane.c	drm: Check mode object lease status in all master ioctl paths [v4]	2017-10-25 16:31:30 +10:00
drm_prime.c	drm/core: clean up references to drm_dev_unref()	2017-09-27 10:53:12 +02:00
drm_print.c
drm_probe_helper.c	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
drm_property.c	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
drm_rect.c
drm_scatter.c
drm_scdc_helper.c	Merge tag 'drm-misc-next-2017-09-20' of git://anongit.freedesktop.org/git/drm-misc into drm-next	2017-09-28 05:46:15 +10:00
drm_simple_kms_helper.c	drm: Plumb modifiers through plane init	2017-08-01 17:50:06 +01:00
drm_syncobj.c	Merge tag 'drm-misc-next-2017-10-16' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-10-17 10:10:17 +10:00
drm_sysfs.c
drm_trace_points.c
drm_trace.h	drm: Use correct path to trace include	2017-09-05 11:11:18 +02:00
drm_vblank.c	drm: Check mode object lease status in all master ioctl paths [v4]	2017-10-25 16:31:30 +10:00
drm_vm.c	Merge branch 'x86-mm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-09-04 12:21:28 -07:00
drm_vma_manager.c	lib/interval_tree: fast overlap detection	2017-09-08 18:26:49 -07:00
Kconfig	Merge branch 'drm-next-4.15' of git://people.freedesktop.org/~agd5f/linux into drm-next	2017-09-28 08:37:02 +10:00
Makefile	drm: Add drm_object lease infrastructure [v5]	2017-10-25 16:31:29 +10:00