forked from Minki/linux
d692403e5c
All netdevs which can accept TC offloads must implement
.ndo_set_features(). nfp_reprs currently do not do that, which
means hw-tc-offload can be turned on and off even when offloads
are active.
Whether the offloads are active is really a question to nfp_ports,
so remove the per-app tc_busy callback indirection thing, and
simply count the number of offloaded items in nfp_port structure.
Fixes: 8a2768732a
("nfp: provide infrastructure for offloading flower based TC filters")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Tested-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
279 lines
6.7 KiB
C
279 lines
6.7 KiB
C
/*
|
|
* Copyright (C) 2017 Netronome Systems, Inc.
|
|
*
|
|
* This software is dual licensed under the GNU General License Version 2,
|
|
* June 1991 as shown in the file COPYING in the top-level directory of this
|
|
* source tree or the BSD 2-Clause License provided below. You have the
|
|
* option to license this software under the complete terms of either license.
|
|
*
|
|
* The BSD 2-Clause License:
|
|
*
|
|
* Redistribution and use in source and binary forms, with or
|
|
* without modification, are permitted provided that the following
|
|
* conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer in the documentation and/or other materials
|
|
* provided with the distribution.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
|
|
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
|
|
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
|
|
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
* SOFTWARE.
|
|
*/
|
|
|
|
#include <linux/lockdep.h>
|
|
#include <linux/netdevice.h>
|
|
#include <net/switchdev.h>
|
|
|
|
#include "nfpcore/nfp_cpp.h"
|
|
#include "nfpcore/nfp_nsp.h"
|
|
#include "nfp_app.h"
|
|
#include "nfp_main.h"
|
|
#include "nfp_net.h"
|
|
#include "nfp_port.h"
|
|
|
|
struct nfp_port *nfp_port_from_netdev(struct net_device *netdev)
|
|
{
|
|
if (nfp_netdev_is_nfp_net(netdev)) {
|
|
struct nfp_net *nn = netdev_priv(netdev);
|
|
|
|
return nn->port;
|
|
}
|
|
|
|
if (nfp_netdev_is_nfp_repr(netdev)) {
|
|
struct nfp_repr *repr = netdev_priv(netdev);
|
|
|
|
return repr->port;
|
|
}
|
|
|
|
WARN(1, "Unknown netdev type for nfp_port\n");
|
|
|
|
return NULL;
|
|
}
|
|
|
|
static int
|
|
nfp_port_attr_get(struct net_device *netdev, struct switchdev_attr *attr)
|
|
{
|
|
struct nfp_port *port;
|
|
|
|
port = nfp_port_from_netdev(netdev);
|
|
if (!port)
|
|
return -EOPNOTSUPP;
|
|
|
|
switch (attr->id) {
|
|
case SWITCHDEV_ATTR_ID_PORT_PARENT_ID: {
|
|
const u8 *serial;
|
|
/* N.B: attr->u.ppid.id is binary data */
|
|
attr->u.ppid.id_len = nfp_cpp_serial(port->app->cpp, &serial);
|
|
memcpy(&attr->u.ppid.id, serial, attr->u.ppid.id_len);
|
|
break;
|
|
}
|
|
default:
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
const struct switchdev_ops nfp_port_switchdev_ops = {
|
|
.switchdev_port_attr_get = nfp_port_attr_get,
|
|
};
|
|
|
|
int nfp_port_setup_tc(struct net_device *netdev, enum tc_setup_type type,
|
|
void *type_data)
|
|
{
|
|
struct nfp_port *port;
|
|
|
|
port = nfp_port_from_netdev(netdev);
|
|
if (!port)
|
|
return -EOPNOTSUPP;
|
|
|
|
return nfp_app_setup_tc(port->app, netdev, type, type_data);
|
|
}
|
|
|
|
int nfp_port_set_features(struct net_device *netdev, netdev_features_t features)
|
|
{
|
|
struct nfp_port *port;
|
|
|
|
port = nfp_port_from_netdev(netdev);
|
|
if (!port)
|
|
return 0;
|
|
|
|
if ((netdev->features & NETIF_F_HW_TC) > (features & NETIF_F_HW_TC) &&
|
|
port->tc_offload_cnt) {
|
|
netdev_err(netdev, "Cannot disable HW TC offload while offloads active\n");
|
|
return -EBUSY;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
struct nfp_port *
|
|
nfp_port_from_id(struct nfp_pf *pf, enum nfp_port_type type, unsigned int id)
|
|
{
|
|
struct nfp_port *port;
|
|
|
|
lockdep_assert_held(&pf->lock);
|
|
|
|
if (type != NFP_PORT_PHYS_PORT)
|
|
return NULL;
|
|
|
|
list_for_each_entry(port, &pf->ports, port_list)
|
|
if (port->eth_id == id)
|
|
return port;
|
|
|
|
return NULL;
|
|
}
|
|
|
|
struct nfp_eth_table_port *__nfp_port_get_eth_port(struct nfp_port *port)
|
|
{
|
|
if (!port)
|
|
return NULL;
|
|
if (port->type != NFP_PORT_PHYS_PORT)
|
|
return NULL;
|
|
|
|
return port->eth_port;
|
|
}
|
|
|
|
struct nfp_eth_table_port *nfp_port_get_eth_port(struct nfp_port *port)
|
|
{
|
|
if (!__nfp_port_get_eth_port(port))
|
|
return NULL;
|
|
|
|
if (test_bit(NFP_PORT_CHANGED, &port->flags))
|
|
if (nfp_net_refresh_eth_port(port))
|
|
return NULL;
|
|
|
|
return __nfp_port_get_eth_port(port);
|
|
}
|
|
|
|
int
|
|
nfp_port_get_phys_port_name(struct net_device *netdev, char *name, size_t len)
|
|
{
|
|
struct nfp_eth_table_port *eth_port;
|
|
struct nfp_port *port;
|
|
int n;
|
|
|
|
port = nfp_port_from_netdev(netdev);
|
|
if (!port)
|
|
return -EOPNOTSUPP;
|
|
|
|
switch (port->type) {
|
|
case NFP_PORT_PHYS_PORT:
|
|
eth_port = __nfp_port_get_eth_port(port);
|
|
if (!eth_port)
|
|
return -EOPNOTSUPP;
|
|
|
|
if (!eth_port->is_split)
|
|
n = snprintf(name, len, "p%d", eth_port->label_port);
|
|
else
|
|
n = snprintf(name, len, "p%ds%d", eth_port->label_port,
|
|
eth_port->label_subport);
|
|
break;
|
|
case NFP_PORT_PF_PORT:
|
|
n = snprintf(name, len, "pf%d", port->pf_id);
|
|
break;
|
|
case NFP_PORT_VF_PORT:
|
|
n = snprintf(name, len, "pf%dvf%d", port->pf_id, port->vf_id);
|
|
break;
|
|
default:
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
if (n >= len)
|
|
return -EINVAL;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* nfp_port_configure() - helper to set the interface configured bit
|
|
* @netdev: net_device instance
|
|
* @configed: Desired state
|
|
*
|
|
* Helper to set the ifup/ifdown state on the PHY only if there is a physical
|
|
* interface associated with the netdev.
|
|
*
|
|
* Return:
|
|
* 0 - configuration successful (or no change);
|
|
* -ERRNO - configuration failed.
|
|
*/
|
|
int nfp_port_configure(struct net_device *netdev, bool configed)
|
|
{
|
|
struct nfp_eth_table_port *eth_port;
|
|
struct nfp_port *port;
|
|
int err;
|
|
|
|
port = nfp_port_from_netdev(netdev);
|
|
eth_port = __nfp_port_get_eth_port(port);
|
|
if (!eth_port)
|
|
return 0;
|
|
|
|
err = nfp_eth_set_configured(port->app->cpp, eth_port->index, configed);
|
|
return err < 0 && err != -EOPNOTSUPP ? err : 0;
|
|
}
|
|
|
|
int nfp_port_init_phy_port(struct nfp_pf *pf, struct nfp_app *app,
|
|
struct nfp_port *port, unsigned int id)
|
|
{
|
|
/* Check if vNIC has external port associated and cfg is OK */
|
|
if (!pf->eth_tbl || id >= pf->eth_tbl->count) {
|
|
nfp_err(app->cpp,
|
|
"NSP port entries don't match vNICs (no entry %d)\n",
|
|
id);
|
|
return -EINVAL;
|
|
}
|
|
if (pf->eth_tbl->ports[id].override_changed) {
|
|
nfp_warn(app->cpp,
|
|
"Config changed for port #%d, reboot required before port will be operational\n",
|
|
pf->eth_tbl->ports[id].index);
|
|
port->type = NFP_PORT_INVALID;
|
|
return 0;
|
|
}
|
|
|
|
port->eth_port = &pf->eth_tbl->ports[id];
|
|
port->eth_id = pf->eth_tbl->ports[id].index;
|
|
if (pf->mac_stats_mem)
|
|
port->eth_stats =
|
|
pf->mac_stats_mem + port->eth_id * NFP_MAC_STATS_SIZE;
|
|
|
|
return 0;
|
|
}
|
|
|
|
struct nfp_port *
|
|
nfp_port_alloc(struct nfp_app *app, enum nfp_port_type type,
|
|
struct net_device *netdev)
|
|
{
|
|
struct nfp_port *port;
|
|
|
|
port = kzalloc(sizeof(*port), GFP_KERNEL);
|
|
if (!port)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
port->netdev = netdev;
|
|
port->type = type;
|
|
port->app = app;
|
|
|
|
list_add_tail(&port->port_list, &app->pf->ports);
|
|
|
|
return port;
|
|
}
|
|
|
|
void nfp_port_free(struct nfp_port *port)
|
|
{
|
|
if (!port)
|
|
return;
|
|
list_del(&port->port_list);
|
|
kfree(port);
|
|
}
|